[INFO] fetching crate did-simple 0.0.2... [INFO] checking did-simple-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate did-simple 0.0.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate did-simple 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate did-simple 0.0.2 [INFO] finished tweaking crates.io crate did-simple 0.0.2 [INFO] tweaked toml for crates.io crate did-simple 0.0.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 47 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1caa800fda25462bf822573a4c965177c74c883c8a1c8e6fe0bc547cc93ba531 [INFO] running `Command { std: "docker" "start" "-a" "1caa800fda25462bf822573a4c965177c74c883c8a1c8e6fe0bc547cc93ba531", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1caa800fda25462bf822573a4c965177c74c883c8a1c8e6fe0bc547cc93ba531", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1caa800fda25462bf822573a4c965177c74c883c8a1c8e6fe0bc547cc93ba531", kill_on_drop: false }` [INFO] [stdout] 1caa800fda25462bf822573a4c965177c74c883c8a1c8e6fe0bc547cc93ba531 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 535d777f0e4df518963fa09a318ca36f2a2f5e5f90b28a419901f0145dcd675e [INFO] running `Command { std: "docker" "start" "-a" "535d777f0e4df518963fa09a318ca36f2a2f5e5f90b28a419901f0145dcd675e", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking did-simple v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/methods/key.rs:121:6 [INFO] [stdout] | [INFO] [stdout] 93 | fn try_from(value: DidUrl) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let s = value.as_utf8_bytes().clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | s, [INFO] [stdout] 123 | | mb_value: decoded_multibase, [INFO] [stdout] 124 | | key_algo, [INFO] [stdout] 125 | | pubkey_bytes, [INFO] [stdout] 126 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utf8bytes.rs:79:6 [INFO] [stdout] | [INFO] [stdout] 77 | fn try_from(value: Bytes) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let _s = std::str::from_utf8(value.as_ref())?; [INFO] [stdout] 79 | Ok(Self(value)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `did-simple` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/methods/key.rs:121:6 [INFO] [stdout] | [INFO] [stdout] 93 | fn try_from(value: DidUrl) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let s = value.as_utf8_bytes().clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | s, [INFO] [stdout] 123 | | mb_value: decoded_multibase, [INFO] [stdout] 124 | | key_algo, [INFO] [stdout] 125 | | pubkey_bytes, [INFO] [stdout] 126 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utf8bytes.rs:79:6 [INFO] [stdout] | [INFO] [stdout] 77 | fn try_from(value: Bytes) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let _s = std::str::from_utf8(value.as_ref())?; [INFO] [stdout] 79 | Ok(Self(value)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/varint.rs:244:3 [INFO] [stdout] | [INFO] [stdout] 239 | let mut iterators = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | / iterators [INFO] [stdout] 245 | | .into_iter() [INFO] [stdout] 246 | | .flatten() [INFO] [stdout] 247 | | .chain([vec![]]) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/varint.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 239 | let mut iterators = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | / (0..=u8::MAX) [INFO] [stdout] 252 | | .combinations_with_replacement(LEN) [INFO] [stdout] 253 | | .cartesian_product(SPECIAL_BYTES) [INFO] [stdout] 254 | | .map(|(mut bytes, special)| { [INFO] [stdout] 255 | | bytes.push(*special); [INFO] [stdout] 256 | | bytes [INFO] [stdout] 257 | | }), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `did-simple` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "535d777f0e4df518963fa09a318ca36f2a2f5e5f90b28a419901f0145dcd675e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "535d777f0e4df518963fa09a318ca36f2a2f5e5f90b28a419901f0145dcd675e", kill_on_drop: false }` [INFO] [stdout] 535d777f0e4df518963fa09a318ca36f2a2f5e5f90b28a419901f0145dcd675e