[INFO] fetching crate dicomweb-util 0.1.0... [INFO] checking dicomweb-util-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dicomweb-util 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate dicomweb-util 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dicomweb-util 0.1.0 [INFO] finished tweaking crates.io crate dicomweb-util 0.1.0 [INFO] tweaked toml for crates.io crate dicomweb-util 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 78 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding byteordered v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding ctor v0.1.26 (latest: v0.2.8) [INFO] [stderr] Adding dicom v0.4.0 (latest: v0.7.1) [INFO] [stderr] Adding dicom-core v0.4.1 (latest: v0.7.1) [INFO] [stderr] Adding dicom-dictionary-std v0.4.0 (latest: v0.7.0) [INFO] [stderr] Adding dicom-encoding v0.4.0 (latest: v0.7.1) [INFO] [stderr] Adding dicom-object v0.4.0 (latest: v0.7.1) [INFO] [stderr] Adding dicom-parser v0.4.0 (latest: v0.7.1) [INFO] [stderr] Adding dicom-transfer-syntax-registry v0.4.0 (latest: v0.7.1) [INFO] [stderr] Adding dicom-ul v0.3.0 (latest: v0.7.1) [INFO] [stderr] Adding enum-as-inner v0.3.4 (latest: v0.6.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding inventory v0.1.11 (latest: v0.3.15) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding snafu v0.6.10 (latest: v0.8.4) [INFO] [stderr] Adding snafu-derive v0.6.10 (latest: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 60a8179b860dbe80e9560a203b839ceec684c5d905e13cbe9d0be35f629ff5c2 [INFO] running `Command { std: "docker" "start" "-a" "60a8179b860dbe80e9560a203b839ceec684c5d905e13cbe9d0be35f629ff5c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "60a8179b860dbe80e9560a203b839ceec684c5d905e13cbe9d0be35f629ff5c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60a8179b860dbe80e9560a203b839ceec684c5d905e13cbe9d0be35f629ff5c2", kill_on_drop: false }` [INFO] [stdout] 60a8179b860dbe80e9560a203b839ceec684c5d905e13cbe9d0be35f629ff5c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 642da8b3cc6979f1e62c3f36e916d6dbbc66ae3c7dbb0d698d46c5af951f4f57 [INFO] running `Command { std: "docker" "start" "-a" "642da8b3cc6979f1e62c3f36e916d6dbbc66ae3c7dbb0d698d46c5af951f4f57", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking safe-transmute v0.11.3 [INFO] [stderr] Compiling inventory v0.1.11 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling ghost v0.1.17 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking byteordered v0.5.0 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling snafu-derive v0.6.10 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Compiling inventory-impl v0.1.11 [INFO] [stderr] Compiling enum-as-inner v0.3.4 [INFO] [stderr] Checking snafu v0.6.10 [INFO] [stderr] Checking dicom-core v0.4.1 [INFO] [stderr] Checking dicom-dictionary-std v0.4.0 [INFO] [stderr] Checking dicom-encoding v0.4.0 [INFO] [stderr] Checking dicom-transfer-syntax-registry v0.4.0 [INFO] [stderr] Checking dicom-parser v0.4.0 [INFO] [stderr] Checking dicom-ul v0.3.0 [INFO] [stderr] Checking dicom-object v0.4.0 [INFO] [stderr] Checking dicom v0.4.0 [INFO] [stderr] Checking dicomweb-util v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `dicom::object::mem::InMemElement` [INFO] [stdout] --> src/lib.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use dicom::object::mem::InMemElement; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FileMetaTableBuilder` and `FileMetaTable` [INFO] [stdout] --> src/lib.rs:4:25 [INFO] [stdout] | [INFO] [stdout] 4 | DefaultDicomObject, FileMetaTable, FileMetaTableBuilder, InMemDicomObject, [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Level`, `info`, `log_enabled`, and `warn` [INFO] [stdout] --> src/lib.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | use log::{debug, error, info, log_enabled, trace, warn, Level}; [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ ^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `borrow::Borrow` [INFO] [stdout] --> src/lib.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | use std::{borrow::Borrow, io::BufRead}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/lib.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | io::{self, Cursor, Read}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `dicom::object::mem::InMemElement` [INFO] [stdout] --> src/lib.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use dicom::object::mem::InMemElement; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FileMetaTableBuilder` and `FileMetaTable` [INFO] [stdout] --> src/lib.rs:4:25 [INFO] [stdout] | [INFO] [stdout] 4 | DefaultDicomObject, FileMetaTable, FileMetaTableBuilder, InMemDicomObject, [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Level`, `info`, `log_enabled`, and `warn` [INFO] [stdout] --> src/lib.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | use log::{debug, error, info, log_enabled, trace, warn, Level}; [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ ^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `borrow::Borrow` [INFO] [stdout] --> src/lib.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | use std::{borrow::Borrow, io::BufRead}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/lib.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | io::{self, Cursor, Read}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `dicom::dicom_core::chrono::FixedOffset::east`: use `east_opt()` instead [INFO] [stdout] --> src/decode.rs:90:67 [INFO] [stdout] | [INFO] [stdout] 90 | ... let default_offset = FixedOffset::east(0); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `dicom::dicom_core::chrono::FixedOffset::east`: use `east_opt()` instead [INFO] [stdout] --> src/decode.rs:90:67 [INFO] [stdout] | [INFO] [stdout] 90 | ... let default_offset = FixedOffset::east(0); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `elt` [INFO] [stdout] --> src/decode.rs:207:37 [INFO] [stdout] | [INFO] [stdout] 207 | ... let elt = DataElement::new(tag, VR::SQ, value); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_elt` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/encode.rs:41:68 [INFO] [stdout] | [INFO] [stdout] 41 | dicom::core::DicomValue::Sequence { items, size } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `size: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `elt` [INFO] [stdout] --> src/decode.rs:207:37 [INFO] [stdout] | [INFO] [stdout] 207 | ... let elt = DataElement::new(tag, VR::SQ, value); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_elt` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/encode.rs:41:68 [INFO] [stdout] | [INFO] [stdout] 41 | dicom::core::DicomValue::Sequence { items, size } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `size: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Value` should have a snake case name [INFO] [stdout] --> src/lib.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | pub Value: Vec, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn encode_dicom_to_json(dicom: InMemDicomObject) -> DICOMJsonObject { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | / dicom [INFO] [stdout] 12 | | .into_iter() [INFO] [stdout] 13 | | .map(|elt| { [INFO] [stdout] 14 | | let mut eltmap = HashMap::new(); [INFO] [stdout] ... | [INFO] [stdout] 68 | | ) [INFO] [stdout] 69 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:44:63 [INFO] [stdout] | [INFO] [stdout] 44 | ... .map(|i| encode_dicom_to_json(i.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dicomweb-util` (lib) due to 3 previous errors; 9 warnings emitted [INFO] [stdout] warning: structure field `Value` should have a snake case name [INFO] [stdout] --> src/lib.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | pub Value: Vec, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn encode_dicom_to_json(dicom: InMemDicomObject) -> DICOMJsonObject { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | / dicom [INFO] [stdout] 12 | | .into_iter() [INFO] [stdout] 13 | | .map(|elt| { [INFO] [stdout] 14 | | let mut eltmap = HashMap::new(); [INFO] [stdout] ... | [INFO] [stdout] 68 | | ) [INFO] [stdout] 69 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:44:63 [INFO] [stdout] | [INFO] [stdout] 44 | ... .map(|i| encode_dicom_to_json(i.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dicomweb-util` (lib test) due to 3 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "642da8b3cc6979f1e62c3f36e916d6dbbc66ae3c7dbb0d698d46c5af951f4f57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "642da8b3cc6979f1e62c3f36e916d6dbbc66ae3c7dbb0d698d46c5af951f4f57", kill_on_drop: false }` [INFO] [stdout] 642da8b3cc6979f1e62c3f36e916d6dbbc66ae3c7dbb0d698d46c5af951f4f57