[INFO] fetching crate dicom-json 0.7.1... [INFO] checking dicom-json-0.7.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dicom-json 0.7.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate dicom-json 0.7.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dicom-json 0.7.1 [INFO] finished tweaking crates.io crate dicom-json 0.7.1 [INFO] tweaked toml for crates.io crate dicom-json 0.7.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 129 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] [stderr] Adding zstd v0.12.4 (latest: v0.13.2) [INFO] [stderr] Adding zstd-safe v6.0.6 (latest: v7.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 58f4a74410acd29e4f417f3c38a314ac52f566962e900ec0d604fd8caca40a0d [INFO] running `Command { std: "docker" "start" "-a" "58f4a74410acd29e4f417f3c38a314ac52f566962e900ec0d604fd8caca40a0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "58f4a74410acd29e4f417f3c38a314ac52f566962e900ec0d604fd8caca40a0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58f4a74410acd29e4f417f3c38a314ac52f566962e900ec0d604fd8caca40a0d", kill_on_drop: false }` [INFO] [stdout] 58f4a74410acd29e4f417f3c38a314ac52f566962e900ec0d604fd8caca40a0d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 45d5825dd0d9debe3437466f72aa6c381da8b53d6f1bbdfb9ed17e7ff4fa5284 [INFO] running `Command { std: "docker" "start" "-a" "45d5825dd0d9debe3437466f72aa6c381da8b53d6f1bbdfb9ed17e7ff4fa5284", kill_on_drop: false }` [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking safe-transmute v0.11.3 [INFO] [stderr] Compiling snafu-derive v0.8.4 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking byteordered v0.6.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Compiling zstd-safe v6.0.6 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking webpki-roots v0.26.5 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking snafu v0.8.4 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Checking dicom-core v0.7.1 [INFO] [stderr] Checking dicom-dictionary-std v0.7.0 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking dicom-encoding v0.7.1 [INFO] [stderr] Checking dicom-parser v0.7.1 [INFO] [stderr] Checking dicom-transfer-syntax-registry v0.7.1 [INFO] [stderr] Checking dicom-object v0.7.1 [INFO] [stderr] Checking dicom-json v0.7.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking zstd v0.12.4 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn from_reader(reader: R) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | serde_json::from_reader::<_, DicomJson>(reader).map(DicomJson::into_inner) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn from_value(value: serde_json::Value) -> Result [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | serde_json::from_value::>(value).map(DicomJson::into_inner) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 100 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | / deserializer [INFO] [stdout] 105 | | .deserialize_map(InMemDicomObjectVisitor::default()) [INFO] [stdout] 106 | | .map(DicomJson::from) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:369:12 [INFO] [stdout] | [INFO] [stdout] 140 | fn visit_map(self, mut map: A) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let mut values: Option<_> = None; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let mut vr = None; [INFO] [stdout] 146 | let mut value: Option = None; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | let value = match (values, inline_binary) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | (Some(values), None) => values, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | Ok(JsonDataElement { [INFO] [stdout] | ____________^ [INFO] [stdout] 370 | | vr, [INFO] [stdout] 371 | | value, [INFO] [stdout] 372 | | bulk_data_uri, [INFO] [stdout] 373 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:416:9 [INFO] [stdout] | [INFO] [stdout] 412 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 416 | deserializer.deserialize_str(TagVisitor).map(DicomJson) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser/mod.rs:22:28 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn to_string(data: T) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | serde_json::to_string(&DicomJson::from(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser/mod.rs:30:35 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn to_string_pretty(data: T) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | serde_json::to_string_pretty(&DicomJson::from(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser/mod.rs:38:26 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn to_value(data: T) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | serde_json::to_value(DicomJson::from(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser/mod.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn to_vec(data: T) -> Result, serde_json::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | serde_json::to_vec(&DicomJson::from(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser/mod.rs:55:36 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn to_writer(writer: W, data: T) -> Result<(), serde_json::Error> [INFO] [stdout] | --------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | serde_json::to_writer(writer, &DicomJson::from(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dicom-json` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "45d5825dd0d9debe3437466f72aa6c381da8b53d6f1bbdfb9ed17e7ff4fa5284", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45d5825dd0d9debe3437466f72aa6c381da8b53d6f1bbdfb9ed17e7ff4fa5284", kill_on_drop: false }` [INFO] [stdout] 45d5825dd0d9debe3437466f72aa6c381da8b53d6f1bbdfb9ed17e7ff4fa5284