[INFO] fetching crate diatom-core 0.6.1... [INFO] checking diatom-core-0.6.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate diatom-core 0.6.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate diatom-core 0.6.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate diatom-core 0.6.1 [INFO] finished tweaking crates.io crate diatom-core 0.6.1 [INFO] tweaked toml for crates.io crate diatom-core 0.6.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 42 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d79cdbf4abb1bb112e0df8ffcacde9fcdfc3bf26ccd11e247667d0fd2fd4b5ac [INFO] running `Command { std: "docker" "start" "-a" "d79cdbf4abb1bb112e0df8ffcacde9fcdfc3bf26ccd11e247667d0fd2fd4b5ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d79cdbf4abb1bb112e0df8ffcacde9fcdfc3bf26ccd11e247667d0fd2fd4b5ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d79cdbf4abb1bb112e0df8ffcacde9fcdfc3bf26ccd11e247667d0fd2fd4b5ac", kill_on_drop: false }` [INFO] [stdout] d79cdbf4abb1bb112e0df8ffcacde9fcdfc3bf26ccd11e247667d0fd2fd4b5ac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 99a422711fb6206f1cde3a0ad8ff79bad4056c56aeb680e21660c7b26c17e3f6 [INFO] running `Command { std: "docker" "start" "-a" "99a422711fb6206f1cde3a0ad8ff79bad4056c56aeb680e21660c7b26c17e3f6", kill_on_drop: false }` [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking bimap v0.6.3 [INFO] [stderr] Checking more-asserts v0.3.1 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking diatom-core v0.6.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Keyword` and `Operator` [INFO] [stdout] --> src/frontend/mod.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | pub use lexer::{Keyword, Lexer, Operator, Token}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Keyword` and `Operator` [INFO] [stdout] --> src/frontend/mod.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | pub use lexer::{Keyword, Lexer, Operator, Token}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `loc` is never read [INFO] [stdout] --> src/frontend/parser/ast.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | Expr { [INFO] [stdout] | ---- field in this variant [INFO] [stdout] 13 | loc: Loc, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Stmt` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `gc` and `insts` are never read [INFO] [stdout] --> src/interpreter/scanner/capture_scanner.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct CaptureScanner<'a, Buffer: IoWrite> { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 9 | pub register_table: &'a mut RegisterTable, [INFO] [stdout] 10 | pub gc: &'a mut Gc, [INFO] [stdout] | ^^ [INFO] [stdout] 11 | pub insts: &'a mut Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LibDummy` is never constructed [INFO] [stdout] --> src/interpreter/std_core.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 64 | pub(crate) struct LibDummy; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `loc` is never read [INFO] [stdout] --> src/vm/op.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 188 | pub struct OpImport { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 193 | pub loc: Loc, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `loc` is never read [INFO] [stdout] --> src/vm/op.rs:339:9 [INFO] [stdout] | [INFO] [stdout] 338 | pub struct OpMakeClosure { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 339 | pub loc: Loc, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `loc` is never read [INFO] [stdout] --> src/vm/op.rs:1436:9 [INFO] [stdout] | [INFO] [stdout] 1435 | pub struct OpJump { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 1436 | pub loc: Loc, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_manager/mod.rs:64:28 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn look_up_fid(&self, path: impl Into) -> Option { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | self.file_map.get(&PathShow::from(path.into())).cloned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/parser/mod.rs:694:19 [INFO] [stdout] | [INFO] [stdout] 690 | let expr = self.consume_expr(iter, 3, None); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 694 | body: Box::new(expr), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/parser/mod.rs:878:20 [INFO] [stdout] | [INFO] [stdout] 793 | let mut key_vals: Vec<(String, Expr, Loc)> = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 794 | let mut content = self.consume_expr(iter, 0, Some(Op(RBrc))); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 878 | value: Const::Table(key_vals), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gc/key_pool.rs:13:29 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn get_or_insert(&mut self, key: impl Into + AsRef) -> usize { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | .unwrap_or_else(|| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 14 | | self.pool.insert(key.into(), self.pool.len()); [INFO] [stdout] 15 | | self.pool.len() - 1 [INFO] [stdout] 16 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter/mod.rs:390:15 [INFO] [stdout] | [INFO] [stdout] 385 | code: impl AsRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 386 | source: impl AsRef, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 390 | match self.vm.exec(&self.byte_code, &mut self.gc, &mut self.out) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diatom-core` (lib) due to 6 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `loc` is never read [INFO] [stdout] --> src/frontend/parser/ast.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | Expr { [INFO] [stdout] | ---- field in this variant [INFO] [stdout] 13 | loc: Loc, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Stmt` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `gc` and `insts` are never read [INFO] [stdout] --> src/interpreter/scanner/capture_scanner.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct CaptureScanner<'a, Buffer: IoWrite> { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 9 | pub register_table: &'a mut RegisterTable, [INFO] [stdout] 10 | pub gc: &'a mut Gc, [INFO] [stdout] | ^^ [INFO] [stdout] 11 | pub insts: &'a mut Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `loc` is never read [INFO] [stdout] --> src/vm/op.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 188 | pub struct OpImport { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 193 | pub loc: Loc, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `loc` is never read [INFO] [stdout] --> src/vm/op.rs:339:9 [INFO] [stdout] | [INFO] [stdout] 338 | pub struct OpMakeClosure { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 339 | pub loc: Loc, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `loc` is never read [INFO] [stdout] --> src/vm/op.rs:1436:9 [INFO] [stdout] | [INFO] [stdout] 1435 | pub struct OpJump { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 1436 | pub loc: Loc, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_manager/mod.rs:64:28 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn look_up_fid(&self, path: impl Into) -> Option { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | self.file_map.get(&PathShow::from(path.into())).cloned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/parser/mod.rs:694:19 [INFO] [stdout] | [INFO] [stdout] 690 | let expr = self.consume_expr(iter, 3, None); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 694 | body: Box::new(expr), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/parser/mod.rs:878:20 [INFO] [stdout] | [INFO] [stdout] 793 | let mut key_vals: Vec<(String, Expr, Loc)> = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 794 | let mut content = self.consume_expr(iter, 0, Some(Op(RBrc))); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 878 | value: Const::Table(key_vals), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gc/key_pool.rs:13:29 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn get_or_insert(&mut self, key: impl Into + AsRef) -> usize { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | .unwrap_or_else(|| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 14 | | self.pool.insert(key.into(), self.pool.len()); [INFO] [stdout] 15 | | self.pool.len() - 1 [INFO] [stdout] 16 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter/mod.rs:390:15 [INFO] [stdout] | [INFO] [stdout] 385 | code: impl AsRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 386 | source: impl AsRef, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 390 | match self.vm.exec(&self.byte_code, &mut self.gc, &mut self.out) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diatom-core` (lib test) due to 6 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "99a422711fb6206f1cde3a0ad8ff79bad4056c56aeb680e21660c7b26c17e3f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99a422711fb6206f1cde3a0ad8ff79bad4056c56aeb680e21660c7b26c17e3f6", kill_on_drop: false }` [INFO] [stdout] 99a422711fb6206f1cde3a0ad8ff79bad4056c56aeb680e21660c7b26c17e3f6