[INFO] fetching crate diameter 0.7.1... [INFO] checking diameter-0.7.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate diameter 0.7.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate diameter 0.7.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate diameter 0.7.1 [INFO] finished tweaking crates.io crate diameter 0.7.1 [INFO] tweaked toml for crates.io crate diameter 0.7.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate diameter 0.7.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] afaa62a5cf7f3c6eff23c6d7bf71e5a3a7007f7e51d270e3eca70b52ab614345 [INFO] running `Command { std: "docker" "start" "-a" "afaa62a5cf7f3c6eff23c6d7bf71e5a3a7007f7e51d270e3eca70b52ab614345", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "afaa62a5cf7f3c6eff23c6d7bf71e5a3a7007f7e51d270e3eca70b52ab614345", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "afaa62a5cf7f3c6eff23c6d7bf71e5a3a7007f7e51d270e3eca70b52ab614345", kill_on_drop: false }` [INFO] [stdout] afaa62a5cf7f3c6eff23c6d7bf71e5a3a7007f7e51d270e3eca70b52ab614345 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b763370d91695710c0a7509a043747c029d622fabcf570036a6d5698c971cec4 [INFO] running `Command { std: "docker" "start" "-a" "b763370d91695710c0a7509a043747c029d622fabcf570036a6d5698c971cec4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking smallvec v1.12.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking xml-rs v0.8.19 [INFO] [stderr] Checking iana-time-zone v0.1.59 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking serde-xml-rs v0.6.0 [INFO] [stderr] Checking diameter v0.7.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avp/mod.rs:405:12 [INFO] [stdout] | [INFO] [stdout] 399 | pub fn from_name(avp_name: &str, value: AvpValue, dict: Arc) -> Result { [INFO] [stdout] | --------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | Ok(Avp::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 406 | | avp_def.code, [INFO] [stdout] 407 | | avp_def.vendor_id, [INFO] [stdout] 408 | | flags, [INFO] [stdout] 409 | | value, [INFO] [stdout] 410 | | dict, [INFO] [stdout] 411 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avp/group.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 38 | dict: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Result { [INFO] [stdout] 40 | let mut avps = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(Grouped { avps, dict }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diameter.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 196 | dict: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let mut avps = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | Ok(DiameterMessage { header, avps, dict }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/server.rs:101:19 [INFO] [stdout] | [INFO] [stdout] 93 | fn handle_peer(peer_addr: SocketAddr, stream: S, handler: F, dict: Arc) [INFO] [stdout] | ------ ------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | match Self::process_incoming_message(stream, handler, dict).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diameter` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avp/mod.rs:405:12 [INFO] [stdout] | [INFO] [stdout] 399 | pub fn from_name(avp_name: &str, value: AvpValue, dict: Arc) -> Result { [INFO] [stdout] | --------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | Ok(Avp::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 406 | | avp_def.code, [INFO] [stdout] 407 | | avp_def.vendor_id, [INFO] [stdout] 408 | | flags, [INFO] [stdout] 409 | | value, [INFO] [stdout] 410 | | dict, [INFO] [stdout] 411 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avp/group.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 38 | dict: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Result { [INFO] [stdout] 40 | let mut avps = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(Grouped { avps, dict }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avp/group.rs:137:15 [INFO] [stdout] | [INFO] [stdout] 115 | let dict = Arc::new(dict); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | [INFO] [stdout] 117 | let avp = Grouped::new( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let avp = Grouped::decode_from(&mut cursor, encoded.len(), dict).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | match avp.avps()[1].get_value() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diameter.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 196 | dict: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let mut avps = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | Ok(DiameterMessage { header, avps, dict }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/server.rs:101:19 [INFO] [stdout] | [INFO] [stdout] 93 | fn handle_peer(peer_addr: SocketAddr, stream: S, handler: F, dict: Arc) [INFO] [stdout] | ------ ------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | match Self::process_incoming_message(stream, handler, dict).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diameter` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "b763370d91695710c0a7509a043747c029d622fabcf570036a6d5698c971cec4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b763370d91695710c0a7509a043747c029d622fabcf570036a6d5698c971cec4", kill_on_drop: false }` [INFO] [stdout] b763370d91695710c0a7509a043747c029d622fabcf570036a6d5698c971cec4