[INFO] fetching crate dgc 0.0.7... [INFO] checking dgc-0.0.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dgc 0.0.7 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate dgc 0.0.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dgc 0.0.7 [INFO] finished tweaking crates.io crate dgc 0.0.7 [INFO] tweaked toml for crates.io crate dgc 0.0.7 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate dgc 0.0.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 249e0ccfc11e379a2d7541d328e687a99e899dae81d2c484dbcc579c98acc7c8 [INFO] running `Command { std: "docker" "start" "-a" "249e0ccfc11e379a2d7541d328e687a99e899dae81d2c484dbcc579c98acc7c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "249e0ccfc11e379a2d7541d328e687a99e899dae81d2c484dbcc579c98acc7c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "249e0ccfc11e379a2d7541d328e687a99e899dae81d2c484dbcc579c98acc7c8", kill_on_drop: false }` [INFO] [stdout] 249e0ccfc11e379a2d7541d328e687a99e899dae81d2c484dbcc579c98acc7c8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 105d4e3fa480be1e3928c0cd0eb420fa20533814c50e9198b95a7ff3e2f32196 [INFO] running `Command { std: "docker" "start" "-a" "105d4e3fa480be1e3928c0cd0eb420fa20533814c50e9198b95a7ff3e2f32196", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling proc-macro2 v1.0.33 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Compiling typenum v1.14.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking signature v1.3.2 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling nom v7.1.0 [INFO] [stderr] Compiling libc v0.2.109 [INFO] [stderr] Compiling semver v1.0.4 [INFO] [stderr] Compiling serde_derive v1.0.131 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Compiling serde v1.0.131 [INFO] [stderr] Checking der v0.4.5 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Compiling oid-registry v0.2.0 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking crypto-bigint v0.2.11 [INFO] [stderr] Compiling ryu v1.0.6 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Compiling serde_json v1.0.72 [INFO] [stderr] Checking ciborium-io v0.2.0 [INFO] [stderr] Checking elliptic-curve v0.10.6 [INFO] [stderr] Checking rusticata-macros v4.0.0 [INFO] [stderr] Checking ciborium-ll v0.2.0 [INFO] [stderr] Checking ecdsa v0.12.4 [INFO] [stderr] Compiling rstest v0.11.0 [INFO] [stderr] Checking aead v0.4.3 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking ed25519 v1.3.0 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking p384 v0.8.0 [INFO] [stderr] Checking p256 v0.9.0 [INFO] [stderr] Checking zeroize v1.4.3 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking data-encoding v2.3.2 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking base45 v3.0.0 [INFO] [stderr] Checking ring-compat v0.3.2 [INFO] [stderr] Compiling der-oid-macro v0.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking der-parser v6.0.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking x509-parser v0.12.0 [INFO] [stderr] Checking ciborium v0.2.0 [INFO] [stderr] Checking dgc v0.0.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dgc.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 21 | fn empty_if_null<'de, D, T>(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let opt = Option::deserialize(deserializer)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(opt.unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dgc` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dgc.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 21 | fn empty_if_null<'de, D, T>(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let opt = Option::deserialize(deserializer)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(opt.unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dgc` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "105d4e3fa480be1e3928c0cd0eb420fa20533814c50e9198b95a7ff3e2f32196", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "105d4e3fa480be1e3928c0cd0eb420fa20533814c50e9198b95a7ff3e2f32196", kill_on_drop: false }` [INFO] [stdout] 105d4e3fa480be1e3928c0cd0eb420fa20533814c50e9198b95a7ff3e2f32196