[INFO] fetching crate dfu 0.4.2... [INFO] checking dfu-0.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dfu 0.4.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate dfu 0.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dfu 0.4.2 [INFO] finished tweaking crates.io crate dfu 0.4.2 [INFO] tweaked toml for crates.io crate dfu 0.4.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 18 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.2.1 (latest: v2.6.0) [INFO] [stderr] Adding memoffset v0.6.5 (latest: v0.9.1) [INFO] [stderr] Adding nix v0.20.2 (latest: v0.29.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b00fb2203f50b958e6ab0b0d8d2f790ee6ca748efb93cfa1c12096747359f8f [INFO] running `Command { std: "docker" "start" "-a" "0b00fb2203f50b958e6ab0b0d8d2f790ee6ca748efb93cfa1c12096747359f8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b00fb2203f50b958e6ab0b0d8d2f790ee6ca748efb93cfa1c12096747359f8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b00fb2203f50b958e6ab0b0d8d2f790ee6ca748efb93cfa1c12096747359f8f", kill_on_drop: false }` [INFO] [stdout] 0b00fb2203f50b958e6ab0b0d8d2f790ee6ca748efb93cfa1c12096747359f8f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c64c2d2b4ab886387bb084c5bf7074428fcc6242c7676631ca69b9d41e472670 [INFO] running `Command { std: "docker" "start" "-a" "c64c2d2b4ab886387bb084c5bf7074428fcc6242c7676631ca69b9d41e472670", kill_on_drop: false }` [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking sysfs-serde v0.2.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking nix v0.20.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking usbapi v0.4.2 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking dfu v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::slice::Iter` [INFO] [stdout] --> src/core.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::slice::Iter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::slice::Iter` [INFO] [stdout] --> src/core.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::slice::Iter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | let mut usb = [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `length`, `descriptor_type`, `attributes`, `detach_timeout`, and `dfu_version` are never read [INFO] [stdout] --> src/core.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 71 | struct DfuDescriptor { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 72 | length: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 73 | descriptor_type: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 74 | attributes: u8, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 75 | detach_timeout: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 76 | transfer_size: u16, [INFO] [stdout] 77 | dfu_version: u8, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | let mut usb = [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:151:12 [INFO] [stdout] | [INFO] [stdout] 123 | fn setup(mut usb: UsbCore, iface_index: u32, alt: u32) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 152 | | usb, [INFO] [stdout] 153 | | timeout, [INFO] [stdout] 154 | | interface: 0, [INFO] [stdout] ... | [INFO] [stdout] 157 | | mem_layout, [INFO] [stdout] 158 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:559:15 [INFO] [stdout] | [INFO] [stdout] 552 | let ctl = self.usb.new_control_out( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 559 | match self [INFO] [stdout] | _______________^ [INFO] [stdout] 560 | | .usb [INFO] [stdout] 561 | | .control_async_wait(ctl, TimeoutMillis::from(self.timeout)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:589:15 [INFO] [stdout] | [INFO] [stdout] 582 | let ctl = self.usb.new_control_in( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 589 | match self [INFO] [stdout] | _______________^ [INFO] [stdout] 590 | | .usb [INFO] [stdout] 591 | | .control_async_wait(ctl, TimeoutMillis::from(self.timeout)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dfu` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `length`, `descriptor_type`, `attributes`, `detach_timeout`, and `dfu_version` are never read [INFO] [stdout] --> src/core.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 71 | struct DfuDescriptor { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 72 | length: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 73 | descriptor_type: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 74 | attributes: u8, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 75 | detach_timeout: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 76 | transfer_size: u16, [INFO] [stdout] 77 | dfu_version: u8, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:151:12 [INFO] [stdout] | [INFO] [stdout] 123 | fn setup(mut usb: UsbCore, iface_index: u32, alt: u32) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 152 | | usb, [INFO] [stdout] 153 | | timeout, [INFO] [stdout] 154 | | interface: 0, [INFO] [stdout] ... | [INFO] [stdout] 157 | | mem_layout, [INFO] [stdout] 158 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:559:15 [INFO] [stdout] | [INFO] [stdout] 552 | let ctl = self.usb.new_control_out( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 559 | match self [INFO] [stdout] | _______________^ [INFO] [stdout] 560 | | .usb [INFO] [stdout] 561 | | .control_async_wait(ctl, TimeoutMillis::from(self.timeout)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:589:15 [INFO] [stdout] | [INFO] [stdout] 582 | let ctl = self.usb.new_control_in( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 589 | match self [INFO] [stdout] | _______________^ [INFO] [stdout] 590 | | .usb [INFO] [stdout] 591 | | .control_async_wait(ctl, TimeoutMillis::from(self.timeout)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dfu` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c64c2d2b4ab886387bb084c5bf7074428fcc6242c7676631ca69b9d41e472670", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c64c2d2b4ab886387bb084c5bf7074428fcc6242c7676631ca69b9d41e472670", kill_on_drop: false }` [INFO] [stdout] c64c2d2b4ab886387bb084c5bf7074428fcc6242c7676631ca69b9d41e472670