[INFO] fetching crate dfrs 0.0.7... [INFO] checking dfrs-0.0.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dfrs 0.0.7 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate dfrs 0.0.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dfrs 0.0.7 [INFO] finished tweaking crates.io crate dfrs 0.0.7 [INFO] tweaked toml for crates.io crate dfrs 0.0.7 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate dfrs 0.0.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 27264ed1b507404e385a4f62f5e5b36c5fe13897943b0511e640b9590b1b39fc [INFO] running `Command { std: "docker" "start" "-a" "27264ed1b507404e385a4f62f5e5b36c5fe13897943b0511e640b9590b1b39fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "27264ed1b507404e385a4f62f5e5b36c5fe13897943b0511e640b9590b1b39fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27264ed1b507404e385a4f62f5e5b36c5fe13897943b0511e640b9590b1b39fc", kill_on_drop: false }` [INFO] [stdout] 27264ed1b507404e385a4f62f5e5b36c5fe13897943b0511e640b9590b1b39fc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cb8d00afc1d34638bf4d52fa65da8c11b08679cac7fd9c7bb24ee485c7680c3f [INFO] running `Command { std: "docker" "start" "-a" "cb8d00afc1d34638bf4d52fa65da8c11b08679cac7fd9c7bb24ee485c7680c3f", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling libc v0.2.83 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking regex-syntax v0.6.22 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling anyhow v1.0.38 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking strum v0.20.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking thread_local v1.1.2 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking regex v1.4.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking nix v0.19.1 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking env_logger v0.8.2 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Compiling strum_macros v0.20.1 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking dfrs v0.0.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `error`, `info`, and `warn` [INFO] [stdout] --> src/errors.rs:2:22 [INFO] [stdout] | [INFO] [stdout] 2 | pub use log::{debug, error, info, warn}; [INFO] [stdout] | ^^^^^ ^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `error`, `info`, and `warn` [INFO] [stdout] --> src/errors.rs:2:22 [INFO] [stdout] | [INFO] [stdout] 2 | pub use log::{debug, error, info, warn}; [INFO] [stdout] | ^^^^^ ^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `base2` is never read [INFO] [stdout] --> src/args.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Args { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 35 | pub base2: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Args` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `mnt_opts`, `mnt_freq`, and `mnt_passno` are never read [INFO] [stdout] --> src/mount.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Mount { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | pub mnt_opts: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 18 | pub mnt_freq: i32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 19 | pub mnt_passno: i32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mount` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 38 | fn column_width(mnt: &[Mount], f: F, heading: &str) -> usize [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | / mnt.iter() [INFO] [stdout] 43 | | .map(f) [INFO] [stdout] 44 | | .chain(std::iter::once(heading.len())) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mount.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn parse_mounts(f: File) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | / BufReader::new(f) [INFO] [stdout] 153 | | .lines() [INFO] [stdout] 154 | | .map(|line| { [INFO] [stdout] 155 | | parse_mount_line(&line?) [INFO] [stdout] 156 | | .context("Failed to parse mount line") [INFO] [stdout] 157 | | .map_err(Error::from) [INFO] [stdout] 158 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mount.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 154 | .map(|line| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | / parse_mount_line(&line?) [INFO] [stdout] 156 | | .context("Failed to parse mount line") [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dfrs` (bin "dfrs") due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `base2` is never read [INFO] [stdout] --> src/args.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Args { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 35 | pub base2: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Args` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 38 | fn column_width(mnt: &[Mount], f: F, heading: &str) -> usize [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | / mnt.iter() [INFO] [stdout] 43 | | .map(f) [INFO] [stdout] 44 | | .chain(std::iter::once(heading.len())) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mount.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn parse_mounts(f: File) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | / BufReader::new(f) [INFO] [stdout] 153 | | .lines() [INFO] [stdout] 154 | | .map(|line| { [INFO] [stdout] 155 | | parse_mount_line(&line?) [INFO] [stdout] 156 | | .context("Failed to parse mount line") [INFO] [stdout] 157 | | .map_err(Error::from) [INFO] [stdout] 158 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mount.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 154 | .map(|line| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | / parse_mount_line(&line?) [INFO] [stdout] 156 | | .context("Failed to parse mount line") [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dfrs` (bin "dfrs" test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cb8d00afc1d34638bf4d52fa65da8c11b08679cac7fd9c7bb24ee485c7680c3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb8d00afc1d34638bf4d52fa65da8c11b08679cac7fd9c7bb24ee485c7680c3f", kill_on_drop: false }` [INFO] [stdout] cb8d00afc1d34638bf4d52fa65da8c11b08679cac7fd9c7bb24ee485c7680c3f