[INFO] fetching crate devpng 0.1.2... [INFO] checking devpng-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate devpng 0.1.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate devpng 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate devpng 0.1.2 [INFO] finished tweaking crates.io crate devpng 0.1.2 [INFO] tweaked toml for crates.io crate devpng 0.1.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4779fc06356eed6cca09a5d9fb8545dcac59f70512cc5d0640f3c6d1f1cdeaf3 [INFO] running `Command { std: "docker" "start" "-a" "4779fc06356eed6cca09a5d9fb8545dcac59f70512cc5d0640f3c6d1f1cdeaf3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4779fc06356eed6cca09a5d9fb8545dcac59f70512cc5d0640f3c6d1f1cdeaf3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4779fc06356eed6cca09a5d9fb8545dcac59f70512cc5d0640f3c6d1f1cdeaf3", kill_on_drop: false }` [INFO] [stdout] 4779fc06356eed6cca09a5d9fb8545dcac59f70512cc5d0640f3c6d1f1cdeaf3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f655ae5edf13cf602e1bbed8350c95861499e9f047a5d816bd95dafb72cb2690 [INFO] running `Command { std: "docker" "start" "-a" "f655ae5edf13cf602e1bbed8350c95861499e9f047a5d816bd95dafb72cb2690", kill_on_drop: false }` [INFO] [stderr] Checking devker v0.1.6 [INFO] [stderr] Checking devpng v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/chunk/bkgd.rs:6:38 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct BkgdMut<'a>(&'a mut [u8], ColourType); [INFO] [stdout] | ------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/chunk/sbit.rs:6:38 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct SbitMut<'a>(&'a mut [u8], ColourType); [INFO] [stdout] | ------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/chunk/trns.rs:6:38 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct TrnsMut<'a>(&'a mut [u8], ColourType); [INFO] [stdout] | ------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/png.rs:22:15 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn store>(&mut self, path: P) -> Result<(), String> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let png = self.datastream.rebuild(&mut Some(&mut self.cache)); [INFO] [stdout] 22 | match std::fs::write(path, png) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `devpng` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/chunk/bkgd.rs:6:38 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct BkgdMut<'a>(&'a mut [u8], ColourType); [INFO] [stdout] | ------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/chunk/sbit.rs:6:38 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct SbitMut<'a>(&'a mut [u8], ColourType); [INFO] [stdout] | ------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/chunk/trns.rs:6:38 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct TrnsMut<'a>(&'a mut [u8], ColourType); [INFO] [stdout] | ------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/png.rs:22:15 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn store>(&mut self, path: P) -> Result<(), String> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let png = self.datastream.rebuild(&mut Some(&mut self.cache)); [INFO] [stdout] 22 | match std::fs::write(path, png) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `devpng` (lib) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f655ae5edf13cf602e1bbed8350c95861499e9f047a5d816bd95dafb72cb2690", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f655ae5edf13cf602e1bbed8350c95861499e9f047a5d816bd95dafb72cb2690", kill_on_drop: false }` [INFO] [stdout] f655ae5edf13cf602e1bbed8350c95861499e9f047a5d816bd95dafb72cb2690