[INFO] fetching crate device_query 2.1.0... [INFO] checking device_query-2.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate device_query 2.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate device_query 2.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate device_query 2.1.0 [INFO] finished tweaking crates.io crate device_query 2.1.0 [INFO] tweaked toml for crates.io crate device_query 2.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate device_query 2.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c944fe78598e0e23dd35eb3cc9d56c818ebd8cf5989b4b6c8c7fc928c74fe212 [INFO] running `Command { std: "docker" "start" "-a" "c944fe78598e0e23dd35eb3cc9d56c818ebd8cf5989b4b6c8c7fc928c74fe212", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c944fe78598e0e23dd35eb3cc9d56c818ebd8cf5989b4b6c8c7fc928c74fe212", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c944fe78598e0e23dd35eb3cc9d56c818ebd8cf5989b4b6c8c7fc928c74fe212", kill_on_drop: false }` [INFO] [stdout] c944fe78598e0e23dd35eb3cc9d56c818ebd8cf5989b4b6c8c7fc928c74fe212 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7652a75eb01e9506c96719a832c6d193e821858823ca0c36d8eab28e1fcf5837 [INFO] running `Command { std: "docker" "start" "-a" "7652a75eb01e9506c96719a832c6d193e821858823ca0c36d8eab28e1fcf5837", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling libc v0.2.123 [INFO] [stderr] Compiling x11 v2.21.0 [INFO] [stderr] Compiling device_query v2.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_events/mod.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 47 | callback: Callback, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ) -> CallbackGuard { [INFO] [stdout] 49 | / EVENT_LOOP [INFO] [stdout] 50 | | .lock() [INFO] [stdout] 51 | | .expect("Couldn't lock EVENT_LOOP") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_events/mod.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 57 | callback: Callback, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | ) -> CallbackGuard { [INFO] [stdout] 59 | / EVENT_LOOP [INFO] [stdout] 60 | | .lock() [INFO] [stdout] 61 | | .expect("Couldn't lock EVENT_LOOP") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_events/mod.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 67 | callback: Callback, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | ) -> CallbackGuard { [INFO] [stdout] 69 | / EVENT_LOOP [INFO] [stdout] 70 | | .lock() [INFO] [stdout] 71 | | .expect("Couldn't lock EVENT_LOOP") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_events/mod.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 77 | callback: Callback, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | ) -> CallbackGuard { [INFO] [stdout] 79 | / EVENT_LOOP [INFO] [stdout] 80 | | .lock() [INFO] [stdout] 81 | | .expect("Couldn't lock EVENT_LOOP") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_events/mod.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 87 | callback: Callback, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | ) -> CallbackGuard { [INFO] [stdout] 89 | / EVENT_LOOP [INFO] [stdout] 90 | | .lock() [INFO] [stdout] 91 | | .expect("Couldn't lock EVENT_LOOP") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_events/event_loop.rs:18:11 [INFO] [stdout] | [INFO] [stdout] 17 | fn keyboard_thread(callbacks: Weak) -> JoinHandle<()> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | spawn(move || { [INFO] [stdout] | ___________^ [INFO] [stdout] 19 | | let device_state = DeviceState::new(); [INFO] [stdout] 20 | | let mut prev_keys = vec![]; [INFO] [stdout] 21 | | while let Some(callbacks) = callbacks.upgrade() { [INFO] [stdout] ... | [INFO] [stdout] 35 | | } [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_events/event_loop.rs:40:11 [INFO] [stdout] | [INFO] [stdout] 39 | fn mouse_thread(callbacks: Weak) -> JoinHandle<()> { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | spawn(move || { [INFO] [stdout] | ___________^ [INFO] [stdout] 41 | | let device_state = DeviceState::new(); [INFO] [stdout] 42 | | let mut previous_mouse_state = MouseState::default(); [INFO] [stdout] 43 | | while let Some(callbacks) = callbacks.upgrade() { [INFO] [stdout] ... | [INFO] [stdout] 62 | | } [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `device_query` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_events/mod.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 47 | callback: Callback, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ) -> CallbackGuard { [INFO] [stdout] 49 | / EVENT_LOOP [INFO] [stdout] 50 | | .lock() [INFO] [stdout] 51 | | .expect("Couldn't lock EVENT_LOOP") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_events/mod.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 57 | callback: Callback, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | ) -> CallbackGuard { [INFO] [stdout] 59 | / EVENT_LOOP [INFO] [stdout] 60 | | .lock() [INFO] [stdout] 61 | | .expect("Couldn't lock EVENT_LOOP") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_events/mod.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 67 | callback: Callback, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | ) -> CallbackGuard { [INFO] [stdout] 69 | / EVENT_LOOP [INFO] [stdout] 70 | | .lock() [INFO] [stdout] 71 | | .expect("Couldn't lock EVENT_LOOP") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_events/mod.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 77 | callback: Callback, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | ) -> CallbackGuard { [INFO] [stdout] 79 | / EVENT_LOOP [INFO] [stdout] 80 | | .lock() [INFO] [stdout] 81 | | .expect("Couldn't lock EVENT_LOOP") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_events/mod.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 87 | callback: Callback, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | ) -> CallbackGuard { [INFO] [stdout] 89 | / EVENT_LOOP [INFO] [stdout] 90 | | .lock() [INFO] [stdout] 91 | | .expect("Couldn't lock EVENT_LOOP") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_events/event_loop.rs:18:11 [INFO] [stdout] | [INFO] [stdout] 17 | fn keyboard_thread(callbacks: Weak) -> JoinHandle<()> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | spawn(move || { [INFO] [stdout] | ___________^ [INFO] [stdout] 19 | | let device_state = DeviceState::new(); [INFO] [stdout] 20 | | let mut prev_keys = vec![]; [INFO] [stdout] 21 | | while let Some(callbacks) = callbacks.upgrade() { [INFO] [stdout] ... | [INFO] [stdout] 35 | | } [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_events/event_loop.rs:40:11 [INFO] [stdout] | [INFO] [stdout] 39 | fn mouse_thread(callbacks: Weak) -> JoinHandle<()> { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | spawn(move || { [INFO] [stdout] | ___________^ [INFO] [stdout] 41 | | let device_state = DeviceState::new(); [INFO] [stdout] 42 | | let mut previous_mouse_state = MouseState::default(); [INFO] [stdout] 43 | | while let Some(callbacks) = callbacks.upgrade() { [INFO] [stdout] ... | [INFO] [stdout] 62 | | } [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `device_query` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "7652a75eb01e9506c96719a832c6d193e821858823ca0c36d8eab28e1fcf5837", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7652a75eb01e9506c96719a832c6d193e821858823ca0c36d8eab28e1fcf5837", kill_on_drop: false }` [INFO] [stdout] 7652a75eb01e9506c96719a832c6d193e821858823ca0c36d8eab28e1fcf5837