[INFO] fetching crate detour3 0.1.0... [INFO] checking detour3-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate detour3 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate detour3 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate detour3 0.1.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate detour3 0.1.0 [INFO] tweaked toml for crates.io crate detour3 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate detour3 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 70987a7ceaf557f699863276e71689d73db72429008324ca27885599830244db [INFO] running `Command { std: "docker" "start" "-a" "70987a7ceaf557f699863276e71689d73db72429008324ca27885599830244db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "70987a7ceaf557f699863276e71689d73db72429008324ca27885599830244db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70987a7ceaf557f699863276e71689d73db72429008324ca27885599830244db", kill_on_drop: false }` [INFO] [stdout] 70987a7ceaf557f699863276e71689d73db72429008324ca27885599830244db [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f15403fc1bb2cdc6a1d6add9daf0e3a0b8790e60c63e919530087964ab963188 [INFO] running `Command { std: "docker" "start" "-a" "f15403fc1bb2cdc6a1d6add9daf0e3a0b8790e60c63e919530087964ab963188", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling cc v1.0.78 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Checking slice-pool v0.4.1 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling generic-array v0.14.6 [INFO] [stderr] Compiling libudis86-sys v0.2.1 [INFO] [stderr] Checking region v3.0.0 [INFO] [stderr] Checking mmap-fixed-fixed v0.1.3 [INFO] [stderr] Checking detour3 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `core_intrinsics` is internal to the compiler or standard library [INFO] [stdout] --> src/lib.rs:8:28 [INFO] [stdout] | [INFO] [stdout] 8 | feature(naked_functions, core_intrinsics) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: using it is strongly discouraged [INFO] [stdout] = note: `#[warn(internal_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `abi_thiscall` has been stable since 1.73.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:4:29 [INFO] [stdout] | [INFO] [stdout] 4 | feature(unboxed_closures, abi_thiscall, tuple_trait) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `abi_thiscall` has been stable since 1.73.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:4:29 [INFO] [stdout] | [INFO] [stdout] 4 | feature(unboxed_closures, abi_thiscall, tuple_trait) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alloc/mod.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | let mut allocator = self.0.lock().unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | / allocator [INFO] [stdout] 25 | | .allocate(origin, size) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alloc/mod.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 26 | .map(|data| ExecutableMemory { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | allocator: self.0.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alloc/proximity.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 25 | self.allocate_memory(&memory_range, size).or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | // ... otherwise allocate a pool within the memory range [INFO] [stdout] 27 | self.allocate_pool(&memory_range, origin, size).map(|pool| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alloc/proximity.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 88 | let before = region_search::before(origin, Some(range.clone())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let after = region_search::after(origin, Some(range.clone())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | / after [INFO] [stdout] 95 | | .chain(before) [INFO] [stdout] 96 | | .filter_map(|result| match result { [INFO] [stdout] 97 | | Ok(address) => Self::allocate_fixed_pool(address, size).map(Ok), [INFO] [stdout] 98 | | Err(error) => Some(Err(error)), [INFO] [stdout] 99 | | }) [INFO] [stdout] 100 | | .next() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alloc/proximity.rs:101:18 [INFO] [stdout] | [INFO] [stdout] 88 | let before = region_search::before(origin, Some(range.clone())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let after = region_search::after(origin, Some(range.clone())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | .unwrap_or(Err(Error::OutOfMemory)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arch/x86/trampoline/mod.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 65 | let mut emitter = pic::CodeEmitter::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(Trampoline { [INFO] [stdout] | ________^ [INFO] [stdout] 89 | | prolog_size: self.total_bytes_disassembled, [INFO] [stdout] 90 | | emitter, [INFO] [stdout] 91 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arch/detour.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 27 | let mut pool = memory::POOL.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let trampoline = arch::Trampoline::new(target, margin)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let relay = if let Some(emitter) = arch::meta::relay_builder(target, detour)? { [INFO] [stdout] | ----- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(Detour { [INFO] [stdout] | ________^ [INFO] [stdout] 51 | | patcher: UnsafeCell::new(arch::Patcher::new( [INFO] [stdout] 52 | | target, [INFO] [stdout] 53 | | detour, [INFO] [stdout] ... | [INFO] [stdout] 58 | | relay, [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/detours/statik.rs:201:16 [INFO] [stdout] | [INFO] [stdout] 201 | unsafe { Box::from_raw(previous) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 201 | unsafe { let _ = Box::from_raw(previous); }; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pic/thunk.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn new GenericArray + 'static>(callback: T) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | FixedThunk(Box::new(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pic/thunk.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 36 | pub unsafe fn new Vec + 'static>(callback: T, size: usize) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | UnsafeThunk { [INFO] [stdout] 38 | callback: Box::new(callback), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `detour3` (lib) due to 10 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alloc/mod.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | let mut allocator = self.0.lock().unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | / allocator [INFO] [stdout] 25 | | .allocate(origin, size) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alloc/mod.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 26 | .map(|data| ExecutableMemory { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | allocator: self.0.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alloc/proximity.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 25 | self.allocate_memory(&memory_range, size).or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | // ... otherwise allocate a pool within the memory range [INFO] [stdout] 27 | self.allocate_pool(&memory_range, origin, size).map(|pool| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alloc/proximity.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 88 | let before = region_search::before(origin, Some(range.clone())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let after = region_search::after(origin, Some(range.clone())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | / after [INFO] [stdout] 95 | | .chain(before) [INFO] [stdout] 96 | | .filter_map(|result| match result { [INFO] [stdout] 97 | | Ok(address) => Self::allocate_fixed_pool(address, size).map(Ok), [INFO] [stdout] 98 | | Err(error) => Some(Err(error)), [INFO] [stdout] 99 | | }) [INFO] [stdout] 100 | | .next() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alloc/proximity.rs:101:18 [INFO] [stdout] | [INFO] [stdout] 88 | let before = region_search::before(origin, Some(range.clone())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let after = region_search::after(origin, Some(range.clone())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | .unwrap_or(Err(Error::OutOfMemory)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arch/x86/trampoline/mod.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 65 | let mut emitter = pic::CodeEmitter::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(Trampoline { [INFO] [stdout] | ________^ [INFO] [stdout] 89 | | prolog_size: self.total_bytes_disassembled, [INFO] [stdout] 90 | | emitter, [INFO] [stdout] 91 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arch/detour.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 27 | let mut pool = memory::POOL.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let trampoline = arch::Trampoline::new(target, margin)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let relay = if let Some(emitter) = arch::meta::relay_builder(target, detour)? { [INFO] [stdout] | ----- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(Detour { [INFO] [stdout] | ________^ [INFO] [stdout] 51 | | patcher: UnsafeCell::new(arch::Patcher::new( [INFO] [stdout] 52 | | target, [INFO] [stdout] 53 | | detour, [INFO] [stdout] ... | [INFO] [stdout] 58 | | relay, [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/detours/statik.rs:201:16 [INFO] [stdout] | [INFO] [stdout] 201 | unsafe { Box::from_raw(previous) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 201 | unsafe { let _ = Box::from_raw(previous); }; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pic/thunk.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn new GenericArray + 'static>(callback: T) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | FixedThunk(Box::new(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pic/thunk.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 36 | pub unsafe fn new Vec + 'static>(callback: T, size: usize) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | UnsafeThunk { [INFO] [stdout] 38 | callback: Box::new(callback), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `detour3` (lib test) due to 10 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f15403fc1bb2cdc6a1d6add9daf0e3a0b8790e60c63e919530087964ab963188", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f15403fc1bb2cdc6a1d6add9daf0e3a0b8790e60c63e919530087964ab963188", kill_on_drop: false }` [INFO] [stdout] f15403fc1bb2cdc6a1d6add9daf0e3a0b8790e60c63e919530087964ab963188