[INFO] fetching crate deskc-thirgen 0.0.0... [INFO] checking deskc-thirgen-0.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate deskc-thirgen 0.0.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate deskc-thirgen 0.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate deskc-thirgen 0.0.0 [INFO] finished tweaking crates.io crate deskc-thirgen 0.0.0 [INFO] tweaked toml for crates.io crate deskc-thirgen 0.0.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 34 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.3.8 (latest: v0.8.11) [INFO] [stderr] Adding chumsky v0.8.0 (latest: v0.9.3) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6651462c22253c8a36286e9209a4eb079339e5ac6a97ca37e941eb2df03e00de [INFO] running `Command { std: "docker" "start" "-a" "6651462c22253c8a36286e9209a4eb079339e5ac6a97ca37e941eb2df03e00de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6651462c22253c8a36286e9209a4eb079339e5ac6a97ca37e941eb2df03e00de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6651462c22253c8a36286e9209a4eb079339e5ac6a97ca37e941eb2df03e00de", kill_on_drop: false }` [INFO] [stdout] 6651462c22253c8a36286e9209a4eb079339e5ac6a97ca37e941eb2df03e00de [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8f8749cf4fa627d9f758e25d658c26bb0a38d0997edcf651bb51061ae90c333 [INFO] running `Command { std: "docker" "start" "-a" "a8f8749cf4fa627d9f758e25d658c26bb0a38d0997edcf651bb51061ae90c333", kill_on_drop: false }` [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking deskc-file v0.0.0 [INFO] [stderr] Checking deskc-types v0.0.0 [INFO] [stderr] Checking deskc-textual-diagnostics v0.0.0 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking deskc-link v0.0.0 [INFO] [stderr] Checking deskc-tokens v0.0.0 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking deskc-hir v0.0.0 [INFO] [stderr] Checking deskc-ast v0.0.0 [INFO] [stderr] Checking deskc-thir v0.0.0 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking ahash v0.3.8 [INFO] [stderr] Checking chumsky v0.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking deskc-hirgen v0.0.0 [INFO] [stderr] Checking deskc-typeinfer v0.0.0 [INFO] [stderr] Checking deskc-thirgen v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn gen_typed_hir(next_id: usize, types: Types, expr: &WithMeta) -> TypedHir { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | / TypedHirGen { [INFO] [stdout] 16 | | types, [INFO] [stdout] 17 | | id_gen: RefCell::new(IdGen { next_id }), [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:63:37 [INFO] [stdout] | [INFO] [stdout] 63 | ... effect: Effect { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 64 | | ... input: self.get_type(input), [INFO] [stdout] 65 | | ... output: self.get_type(output), [INFO] [stdout] 66 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:67:38 [INFO] [stdout] | [INFO] [stdout] 67 | ... handler: self.gen(&*handler), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:139:29 [INFO] [stdout] | [INFO] [stdout] 139 | ty: self.get_type(ty), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:140:31 [INFO] [stdout] | [INFO] [stdout] 140 | expr: self.gen(expr), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtin.rs:92:15 [INFO] [stdout] | [INFO] [stdout] 89 | fn labeled(label: &str, item: Type) -> Type { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | item: Box::new(item), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtin.rs:102:16 [INFO] [stdout] | [INFO] [stdout] 98 | let dividend = thirgen.gen(&args[0]); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let divisor = thirgen.gen(&args[1]); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | input: Box::new(TypedHir { [INFO] [stdout] | ________________^ [INFO] [stdout] 103 | | id: thirgen.next_id(), [INFO] [stdout] 104 | | ty: Type::sum(vec![ [INFO] [stdout] 105 | | Type::label("equal", Type::unit()), [INFO] [stdout] ... | [INFO] [stdout] 118 | | }, [INFO] [stdout] 119 | | }), [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `deskc-thirgen` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a8f8749cf4fa627d9f758e25d658c26bb0a38d0997edcf651bb51061ae90c333", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8f8749cf4fa627d9f758e25d658c26bb0a38d0997edcf651bb51061ae90c333", kill_on_drop: false }` [INFO] [stdout] a8f8749cf4fa627d9f758e25d658c26bb0a38d0997edcf651bb51061ae90c333