[INFO] fetching crate derive-visitor 0.4.0... [INFO] checking derive-visitor-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate derive-visitor 0.4.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate derive-visitor 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate derive-visitor 0.4.0 [INFO] finished tweaking crates.io crate derive-visitor 0.4.0 [INFO] tweaked toml for crates.io crate derive-visitor 0.4.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e10389287398fb0de20ce1e644a67033ced5a399c734e84541d63561798b8f1e [INFO] running `Command { std: "docker" "start" "-a" "e10389287398fb0de20ce1e644a67033ced5a399c734e84541d63561798b8f1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e10389287398fb0de20ce1e644a67033ced5a399c734e84541d63561798b8f1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e10389287398fb0de20ce1e644a67033ced5a399c734e84541d63561798b8f1e", kill_on_drop: false }` [INFO] [stdout] e10389287398fb0de20ce1e644a67033ced5a399c734e84541d63561798b8f1e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 27efdf05d7787a424c982e79a62208c7b472c72cfd3a02eb55f182569de944cb [INFO] running `Command { std: "docker" "start" "-a" "27efdf05d7787a424c982e79a62208c7b472c72cfd3a02eb55f182569de944cb", kill_on_drop: false }` [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling derive-visitor-macros v0.4.0 [INFO] [stderr] Checking derive-visitor v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:306:16 [INFO] [stdout] | [INFO] [stdout] 305 | pub fn visitor_enter_fn(mut fun: F) -> FnVisitor { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | visitor_fn(move |item, event| { [INFO] [stdout] | ________________^ [INFO] [stdout] 307 | | if let Event::Enter = event { [INFO] [stdout] 308 | | fun(item); [INFO] [stdout] 309 | | } [INFO] [stdout] 310 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:317:20 [INFO] [stdout] | [INFO] [stdout] 315 | mut fun: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | ) -> FnVisitor { [INFO] [stdout] 317 | visitor_fn_mut(move |item, event| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 318 | | if let Event::Enter = event { [INFO] [stdout] 319 | | fun(item); [INFO] [stdout] 320 | | } [INFO] [stdout] 321 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:544:29 [INFO] [stdout] | [INFO] [stdout] 544 | for item in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 572 | impl_drive_for_into_iterator! { Option ; T } [INFO] [stdout] | ----------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_drive_for_into_iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 544 | while let Some(item) = self { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 544 | if let Some(item) = self { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:557:29 [INFO] [stdout] | [INFO] [stdout] 557 | for item in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 572 | impl_drive_for_into_iterator! { Option ; T } [INFO] [stdout] | ----------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_drive_for_into_iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 557 | while let Some(item) = self { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 557 | if let Some(item) = self { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:544:29 [INFO] [stdout] | [INFO] [stdout] 544 | for item in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 573 | impl_drive_for_into_iterator! { Result ; T, U } [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_drive_for_into_iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 544 | while let Ok(item) = self { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 544 | if let Ok(item) = self { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:557:29 [INFO] [stdout] | [INFO] [stdout] 557 | for item in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 573 | impl_drive_for_into_iterator! { Result ; T, U } [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_drive_for_into_iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 557 | while let Ok(item) = self { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 557 | if let Ok(item) = self { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `derive-visitor` (lib) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:306:16 [INFO] [stdout] | [INFO] [stdout] 305 | pub fn visitor_enter_fn(mut fun: F) -> FnVisitor { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | visitor_fn(move |item, event| { [INFO] [stdout] | ________________^ [INFO] [stdout] 307 | | if let Event::Enter = event { [INFO] [stdout] 308 | | fun(item); [INFO] [stdout] 309 | | } [INFO] [stdout] 310 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:317:20 [INFO] [stdout] | [INFO] [stdout] 315 | mut fun: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | ) -> FnVisitor { [INFO] [stdout] 317 | visitor_fn_mut(move |item, event| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 318 | | if let Event::Enter = event { [INFO] [stdout] 319 | | fun(item); [INFO] [stdout] 320 | | } [INFO] [stdout] 321 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:544:29 [INFO] [stdout] | [INFO] [stdout] 544 | for item in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 572 | impl_drive_for_into_iterator! { Option ; T } [INFO] [stdout] | ----------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_drive_for_into_iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 544 | while let Some(item) = self { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 544 | if let Some(item) = self { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:557:29 [INFO] [stdout] | [INFO] [stdout] 557 | for item in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 572 | impl_drive_for_into_iterator! { Option ; T } [INFO] [stdout] | ----------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_drive_for_into_iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 557 | while let Some(item) = self { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 557 | if let Some(item) = self { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:544:29 [INFO] [stdout] | [INFO] [stdout] 544 | for item in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 573 | impl_drive_for_into_iterator! { Result ; T, U } [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_drive_for_into_iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 544 | while let Ok(item) = self { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 544 | if let Ok(item) = self { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:557:29 [INFO] [stdout] | [INFO] [stdout] 557 | for item in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 573 | impl_drive_for_into_iterator! { Result ; T, U } [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_drive_for_into_iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 557 | while let Ok(item) = self { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 557 | if let Ok(item) = self { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `derive-visitor` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "27efdf05d7787a424c982e79a62208c7b472c72cfd3a02eb55f182569de944cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27efdf05d7787a424c982e79a62208c7b472c72cfd3a02eb55f182569de944cb", kill_on_drop: false }` [INFO] [stdout] 27efdf05d7787a424c982e79a62208c7b472c72cfd3a02eb55f182569de944cb