[INFO] fetching crate dep-graph 0.2.0... [INFO] checking dep-graph-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dep-graph 0.2.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate dep-graph 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dep-graph 0.2.0 [INFO] finished tweaking crates.io crate dep-graph 0.2.0 [INFO] tweaked toml for crates.io crate dep-graph 0.2.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 77 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding crossbeam-channel v0.4.4 (latest: v0.5.13) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (latest: v0.8.20) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d90d4cb78f3f9520dca4aaa9e8bba73e9028b862e110aa35a836948c4999c1fc [INFO] running `Command { std: "docker" "start" "-a" "d90d4cb78f3f9520dca4aaa9e8bba73e9028b862e110aa35a836948c4999c1fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d90d4cb78f3f9520dca4aaa9e8bba73e9028b862e110aa35a836948c4999c1fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d90d4cb78f3f9520dca4aaa9e8bba73e9028b862e110aa35a836948c4999c1fc", kill_on_drop: false }` [INFO] [stdout] d90d4cb78f3f9520dca4aaa9e8bba73e9028b862e110aa35a836948c4999c1fc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3480a12ab3a8e0b5e31808fbecf50f971f1d95557eafa5dc87d8580654e1354f [INFO] running `Command { std: "docker" "start" "-a" "3480a12ab3a8e0b5e31808fbecf50f971f1d95557eafa5dc87d8580654e1354f", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking dep-graph v0.2.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 37 | let mut deps = InnerDependencyMap::::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let mut rdeps = InnerDependencyMap::::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let mut ready_nodes = Vec::::default(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Arc::new(RwLock::new(deps)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 37 | let mut deps = InnerDependencyMap::::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let mut rdeps = InnerDependencyMap::::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let mut ready_nodes = Vec::::default(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Arc::new(RwLock::new(rdeps)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:76:32 [INFO] [stdout] | [INFO] [stdout] 75 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | DepGraphIter::::new(self.ready_nodes.clone(), self.deps.clone(), self.rdeps) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:76:58 [INFO] [stdout] | [INFO] [stdout] 75 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | DepGraphIter::::new(self.ready_nodes.clone(), self.deps.clone(), self.rdeps) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph_par.rs:175:30 [INFO] [stdout] | [INFO] [stdout] 175 | .for_each(|node| item_ready_tx.send(node.clone()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph_par.rs:194:49 [INFO] [stdout] | [INFO] [stdout] 194 | ... .for_each(|node_id| item_ready_tx.send(node_id.clone()).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph_par.rs:271:27 [INFO] [stdout] | [INFO] [stdout] 267 | fn with_producer(self, callback: CB) -> CB::Output [INFO] [stdout] | ---- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | callback.callback(DepGraphProducer { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 272 | | counter: self.counter.clone(), [INFO] [stdout] 273 | | item_ready_rx: self.item_ready_rx, [INFO] [stdout] 274 | | item_done_tx: self.item_done_tx, [INFO] [stdout] 275 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph_par.rs:330:22 [INFO] [stdout] | [INFO] [stdout] 328 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | Self { [INFO] [stdout] 330 | counter: self.counter.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph_par.rs:331:28 [INFO] [stdout] | [INFO] [stdout] 328 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | item_ready_rx: self.item_ready_rx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph_par.rs:338:13 [INFO] [stdout] | [INFO] [stdout] 336 | fn split_at(self, _: usize) -> (Self, Self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | ( [INFO] [stdout] 338 | / Self { [INFO] [stdout] 339 | | counter: self.counter.clone(), [INFO] [stdout] 340 | | item_ready_rx: self.item_ready_rx.clone(), [INFO] [stdout] 341 | | item_done_tx: self.item_done_tx.clone(), [INFO] [stdout] 342 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph_par.rs:343:13 [INFO] [stdout] | [INFO] [stdout] 336 | fn split_at(self, _: usize) -> (Self, Self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | / Self { [INFO] [stdout] 344 | | counter: self.counter.clone(), [INFO] [stdout] 345 | | item_ready_rx: self.item_ready_rx.clone(), [INFO] [stdout] 346 | | item_done_tx: self.item_done_tx, [INFO] [stdout] 347 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(id: I) -> Node { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | deps: HashSet::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dep-graph` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "3480a12ab3a8e0b5e31808fbecf50f971f1d95557eafa5dc87d8580654e1354f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3480a12ab3a8e0b5e31808fbecf50f971f1d95557eafa5dc87d8580654e1354f", kill_on_drop: false }` [INFO] [stdout] 3480a12ab3a8e0b5e31808fbecf50f971f1d95557eafa5dc87d8580654e1354f