[INFO] fetching crate denumic 0.1.0... [INFO] checking denumic-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate denumic 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate denumic 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate denumic 0.1.0 [INFO] finished tweaking crates.io crate denumic 0.1.0 [INFO] tweaked toml for crates.io crate denumic 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c41e2257dd87b5144596d573bcd047edbb24a6f90e6441da0a80bd27ea27a81f [INFO] running `Command { std: "docker" "start" "-a" "c41e2257dd87b5144596d573bcd047edbb24a6f90e6441da0a80bd27ea27a81f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c41e2257dd87b5144596d573bcd047edbb24a6f90e6441da0a80bd27ea27a81f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c41e2257dd87b5144596d573bcd047edbb24a6f90e6441da0a80bd27ea27a81f", kill_on_drop: false }` [INFO] [stdout] c41e2257dd87b5144596d573bcd047edbb24a6f90e6441da0a80bd27ea27a81f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 07faca4496db3afdd50a3a4c092be615472c5e43d5950f4e7709e6348af0f08d [INFO] running `Command { std: "docker" "start" "-a" "07faca4496db3afdd50a3a4c092be615472c5e43d5950f4e7709e6348af0f08d", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking denumic v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn denumic_impl(args: TokenStream, item: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let tr = parse_macro_input!(args); [INFO] [stdout] | -- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let ty = parse_macro_input!(item); [INFO] [stdout] | -- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | / r#impl::handle(tr, ty) [INFO] [stdout] 131 | | .unwrap_or_else(Error::into_compile_error) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 28 | let mut tr = input.parse::()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let tr_def = input.parse::()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let tr_args = generic_params_to_args(&tr_def.generics); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | tr.segments.last_mut().unwrap().arguments = tr_args; [INFO] [stdout] 32 | Ok(Args { tr, tr_def }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn denumic_impl(args: TokenStream, item: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let tr = parse_macro_input!(args); [INFO] [stdout] | -- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let ty = parse_macro_input!(item); [INFO] [stdout] | -- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | / r#impl::handle(tr, ty) [INFO] [stdout] 131 | | .unwrap_or_else(Error::into_compile_error) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 28 | let mut tr = input.parse::()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let tr_def = input.parse::()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let tr_args = generic_params_to_args(&tr_def.generics); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | tr.segments.last_mut().unwrap().arguments = tr_args; [INFO] [stdout] 32 | Ok(Args { tr, tr_def }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 61 | let mut generics = impl_generics(&tr_def.generics, &ty_def.generics); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | remove_defaults(&mut generics); [INFO] [stdout] 63 | let mut items = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | handle_items(tr, tr_def, ty_def, &mut items)?; [INFO] [stdout] 65 | Ok(ItemImpl { [INFO] [stdout] | ________^ [INFO] [stdout] 66 | | attrs: merge_cfgs([&tr_def.attrs, &ty_def.attrs]), [INFO] [stdout] 67 | | defaultness: None, [INFO] [stdout] 68 | | unsafety: tr_def.unsafety, [INFO] [stdout] ... | [INFO] [stdout] 84 | | items, [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl.rs:254:18 [INFO] [stdout] | [INFO] [stdout] 238 | let mut inputs = sig.inputs.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | let func = Box::new(Expr::Path(ExprPath { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | let args = method_params_to_args(this, &mut inputs); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | let span = this.span(); [INFO] [stdout] 254 | Box::new(Expr::MethodCall(ExprMethodCall { [INFO] [stdout] | __________________^ [INFO] [stdout] 255 | | attrs: vec![], [INFO] [stdout] 256 | | receiver: Box::new(Expr::Call(ExprCall { [INFO] [stdout] 257 | | attrs: vec![], [INFO] [stdout] ... | [INFO] [stdout] 266 | | args: Punctuated::new(), [INFO] [stdout] 267 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl.rs:316:8 [INFO] [stdout] | [INFO] [stdout] 272 | mut call: impl FnMut(&Ident) -> Box, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | let member = v [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | let this = Ident::new("__this", member.span()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | let call = call(&this); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 315 | [INFO] [stdout] 316 | Ok(Arm { [INFO] [stdout] | ________^ [INFO] [stdout] 317 | | attrs: merge_cfgs([&v.attrs]), [INFO] [stdout] 318 | | pat: Pat::Struct(PatStruct { [INFO] [stdout] 319 | | attrs: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 349 | | comma: Some(Token![,](span)), [INFO] [stdout] 350 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:171:5 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn merge_cfgs<'a>(attrs: impl IntoIterator>) -> Vec { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | / attrs [INFO] [stdout] 172 | | .into_iter() [INFO] [stdout] 173 | | .flatten() [INFO] [stdout] 174 | | .filter(|a| matches!(a.style, AttrStyle::Outer) && a.meta.path().is_ident("cfg")) [INFO] [stdout] 175 | | .cloned() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 61 | let mut generics = impl_generics(&tr_def.generics, &ty_def.generics); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | remove_defaults(&mut generics); [INFO] [stdout] 63 | let mut items = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | handle_items(tr, tr_def, ty_def, &mut items)?; [INFO] [stdout] 65 | Ok(ItemImpl { [INFO] [stdout] | ________^ [INFO] [stdout] 66 | | attrs: merge_cfgs([&tr_def.attrs, &ty_def.attrs]), [INFO] [stdout] 67 | | defaultness: None, [INFO] [stdout] 68 | | unsafety: tr_def.unsafety, [INFO] [stdout] ... | [INFO] [stdout] 84 | | items, [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl.rs:254:18 [INFO] [stdout] | [INFO] [stdout] 238 | let mut inputs = sig.inputs.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | let func = Box::new(Expr::Path(ExprPath { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | let args = method_params_to_args(this, &mut inputs); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | let span = this.span(); [INFO] [stdout] 254 | Box::new(Expr::MethodCall(ExprMethodCall { [INFO] [stdout] | __________________^ [INFO] [stdout] 255 | | attrs: vec![], [INFO] [stdout] 256 | | receiver: Box::new(Expr::Call(ExprCall { [INFO] [stdout] 257 | | attrs: vec![], [INFO] [stdout] ... | [INFO] [stdout] 266 | | args: Punctuated::new(), [INFO] [stdout] 267 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl.rs:316:8 [INFO] [stdout] | [INFO] [stdout] 272 | mut call: impl FnMut(&Ident) -> Box, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | let member = v [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | let this = Ident::new("__this", member.span()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | let call = call(&this); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 315 | [INFO] [stdout] 316 | Ok(Arm { [INFO] [stdout] | ________^ [INFO] [stdout] 317 | | attrs: merge_cfgs([&v.attrs]), [INFO] [stdout] 318 | | pat: Pat::Struct(PatStruct { [INFO] [stdout] 319 | | attrs: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 349 | | comma: Some(Token![,](span)), [INFO] [stdout] 350 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:171:5 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn merge_cfgs<'a>(attrs: impl IntoIterator>) -> Vec { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | / attrs [INFO] [stdout] 172 | | .into_iter() [INFO] [stdout] 173 | | .flatten() [INFO] [stdout] 174 | | .filter(|a| matches!(a.style, AttrStyle::Outer) && a.meta.path().is_ident("cfg")) [INFO] [stdout] 175 | | .cloned() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `denumic` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `denumic` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "07faca4496db3afdd50a3a4c092be615472c5e43d5950f4e7709e6348af0f08d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07faca4496db3afdd50a3a4c092be615472c5e43d5950f4e7709e6348af0f08d", kill_on_drop: false }` [INFO] [stdout] 07faca4496db3afdd50a3a4c092be615472c5e43d5950f4e7709e6348af0f08d