[INFO] fetching crate deno_unsync 0.4.1... [INFO] checking deno_unsync-0.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate deno_unsync 0.4.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate deno_unsync 0.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate deno_unsync 0.4.1 [INFO] finished tweaking crates.io crate deno_unsync 0.4.1 [INFO] tweaked toml for crates.io crate deno_unsync 0.4.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 38 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf2f20f8e502245be2e606267afd78086d3c7d9e25339ebf10ecba1a01822dc9 [INFO] running `Command { std: "docker" "start" "-a" "bf2f20f8e502245be2e606267afd78086d3c7d9e25339ebf10ecba1a01822dc9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf2f20f8e502245be2e606267afd78086d3c7d9e25339ebf10ecba1a01822dc9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf2f20f8e502245be2e606267afd78086d3c7d9e25339ebf10ecba1a01822dc9", kill_on_drop: false }` [INFO] [stdout] bf2f20f8e502245be2e606267afd78086d3c7d9e25339ebf10ecba1a01822dc9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 52dca5805fbe0788ba10445258a90cb00044dc657dd85edb120dea861b49f28d [INFO] running `Command { std: "docker" "start" "-a" "52dca5805fbe0788ba10445258a90cb00044dc657dd85edb120dea861b49f28d", kill_on_drop: false }` [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking deno_unsync v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:103:17 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn new(future: TFuture) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | SharedLocal(Rc::new(SharedLocalInner { [INFO] [stdout] | _________________^ [INFO] [stdout] 104 | | data: RefCell::new(SharedLocalData { [INFO] [stdout] 105 | | future_or_output: FutureOrOutput::Future(future), [INFO] [stdout] 106 | | }), [INFO] [stdout] ... | [INFO] [stdout] 110 | | }), [INFO] [stdout] 111 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpsc/mod.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 114 | let shared = Rc::new(RefCell::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | / Sender { [INFO] [stdout] 121 | | shared: shared.clone(), [INFO] [stdout] 122 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpsc/mod.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 114 | let shared = Rc::new(RefCell::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Receiver { shared }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio/split.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn split_io(stream: S) -> (IOReadHalf, IOWriteHalf) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let stream = Rc::new(Split { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | / IOReadHalf { [INFO] [stdout] 26 | | split: stream.clone(), [INFO] [stdout] 27 | | _marker: UnsendMarker::default(), [INFO] [stdout] 28 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio/split.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn split_io(stream: S) -> (IOReadHalf, IOWriteHalf) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let stream = Rc::new(Split { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | / IOWriteHalf { [INFO] [stdout] 30 | | split: stream, [INFO] [stdout] 31 | | is_write_vectored, [INFO] [stdout] 32 | | _marker: UnsendMarker::default(), [INFO] [stdout] 33 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio/task.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 54 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let future = unsafe { MaskFutureAsSend::new(f) }; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | JoinHandle { [INFO] [stdout] 62 | handle: tokio::task::spawn(future), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio/task.rs:76:74 [INFO] [stdout] | [INFO] [stdout] 74 | f: F, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | ) -> JoinHandle { [INFO] [stdout] 76 | let handle = tokio::task::spawn_blocking(|| MaskResultAsSend { result: f() }); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `deno_unsync` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:103:17 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn new(future: TFuture) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | SharedLocal(Rc::new(SharedLocalInner { [INFO] [stdout] | _________________^ [INFO] [stdout] 104 | | data: RefCell::new(SharedLocalData { [INFO] [stdout] 105 | | future_or_output: FutureOrOutput::Future(future), [INFO] [stdout] 106 | | }), [INFO] [stdout] ... | [INFO] [stdout] 110 | | }), [INFO] [stdout] 111 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:241:5 [INFO] [stdout] | [INFO] [stdout] 224 | let notify = Arc::new(Notify::new()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | [INFO] [stdout] 226 | let shared = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let notify = notify.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | let mut tasks = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | / crate::spawn(async move { [INFO] [stdout] 242 | | notify.notify_one(); [INFO] [stdout] 243 | | for task in tasks { [INFO] [stdout] 244 | | task.await.unwrap(); [INFO] [stdout] 245 | | } [INFO] [stdout] 246 | | }) [INFO] [stdout] 247 | | .await [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpsc/mod.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 114 | let shared = Rc::new(RefCell::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | / Sender { [INFO] [stdout] 121 | | shared: shared.clone(), [INFO] [stdout] 122 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpsc/mod.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 114 | let shared = Rc::new(RefCell::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Receiver { shared }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio/split.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn split_io(stream: S) -> (IOReadHalf, IOWriteHalf) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let stream = Rc::new(Split { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | / IOReadHalf { [INFO] [stdout] 26 | | split: stream.clone(), [INFO] [stdout] 27 | | _marker: UnsendMarker::default(), [INFO] [stdout] 28 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio/split.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn split_io(stream: S) -> (IOReadHalf, IOWriteHalf) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let stream = Rc::new(Split { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | / IOWriteHalf { [INFO] [stdout] 30 | | split: stream, [INFO] [stdout] 31 | | is_write_vectored, [INFO] [stdout] 32 | | _marker: UnsendMarker::default(), [INFO] [stdout] 33 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio/task.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 54 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let future = unsafe { MaskFutureAsSend::new(f) }; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | JoinHandle { [INFO] [stdout] 62 | handle: tokio::task::spawn(future), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio/task.rs:76:74 [INFO] [stdout] | [INFO] [stdout] 74 | f: F, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | ) -> JoinHandle { [INFO] [stdout] 76 | let handle = tokio::task::spawn_blocking(|| MaskResultAsSend { result: f() }); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `deno_unsync` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "52dca5805fbe0788ba10445258a90cb00044dc657dd85edb120dea861b49f28d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52dca5805fbe0788ba10445258a90cb00044dc657dd85edb120dea861b49f28d", kill_on_drop: false }` [INFO] [stdout] 52dca5805fbe0788ba10445258a90cb00044dc657dd85edb120dea861b49f28d