[INFO] fetching crate deno_ast 0.42.0... [INFO] checking deno_ast-0.42.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate deno_ast 0.42.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate deno_ast 0.42.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate deno_ast 0.42.0 [INFO] finished tweaking crates.io crate deno_ast 0.42.0 [INFO] tweaked toml for crates.io crate deno_ast 0.42.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 186 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding base64-simd v0.7.0 (latest: v0.8.0) [INFO] [stderr] Adding crc v2.1.0 (latest: v3.2.1) [INFO] [stderr] Adding crc-catalog v1.1.1 (latest: v2.4.0) [INFO] [stderr] Adding dashmap v5.5.3 (latest: v6.0.1) [INFO] [stderr] Adding deno_terminal v0.1.1 (latest: v0.2.0) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding outref v0.1.0 (latest: v0.5.1) [INFO] [stderr] Adding ptr_meta v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding ptr_meta_derive v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding swc_ecma_transforms_optimization v0.208.0 (latest: v0.208.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] efb6bf0fe6711a7817dd1f059814803ed9c8646c5962fc6dc0c53a3f2a8060bb [INFO] running `Command { std: "docker" "start" "-a" "efb6bf0fe6711a7817dd1f059814803ed9c8646c5962fc6dc0c53a3f2a8060bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "efb6bf0fe6711a7817dd1f059814803ed9c8646c5962fc6dc0c53a3f2a8060bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "efb6bf0fe6711a7817dd1f059814803ed9c8646c5962fc6dc0c53a3f2a8060bb", kill_on_drop: false }` [INFO] [stdout] efb6bf0fe6711a7817dd1f059814803ed9c8646c5962fc6dc0c53a3f2a8060bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f1def67266ff5aa83ab7db7bb994ee482378ec29a795db0fc1eb2007e8fbdb2f [INFO] running `Command { std: "docker" "start" "-a" "f1def67266ff5aa83ab7db7bb994ee482378ec29a795db0fc1eb2007e8fbdb2f", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling psm v0.1.22 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking better_scoped_tls v0.1.1 [INFO] [stderr] Compiling ptr_meta_derive v0.1.4 [INFO] [stderr] Compiling stacker v0.1.17 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Checking unicode-id-start v1.2.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Checking data-url v0.3.1 [INFO] [stderr] Checking swc_visit v0.6.2 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking deno_terminal v0.1.1 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking ptr_meta v0.1.4 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling swc_macros_common v0.3.13 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling swc_eq_ignore_macros v0.1.4 [INFO] [stderr] Compiling ast_node v0.9.9 [INFO] [stderr] Compiling from_variant v0.1.9 [INFO] [stderr] Compiling string_enum v0.4.4 [INFO] [stderr] Compiling is-macro v0.3.6 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking triomphe v0.1.13 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking text_lines v0.6.0 [INFO] [stderr] Checking hstr v0.2.12 [INFO] [stderr] Checking swc_allocator v0.1.8 [INFO] [stderr] Checking swc_atoms v0.6.7 [INFO] [stderr] Checking deno_media_type v0.1.4 [INFO] [stderr] Checking swc_common v0.37.5 [INFO] [stderr] Checking swc_ecma_ast v0.118.2 [INFO] [stderr] Checking swc_ecma_parser v0.149.1 [INFO] [stderr] Checking dprint-swc-ext v0.20.0 [INFO] [stderr] Checking deno_ast v0.42.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comments.rs:47:14 [INFO] [stdout] | [INFO] [stdout] 43 | leading: SingleThreadedCommentsMapInner, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | trailing: SingleThreadedCommentsMapInner, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | inner: Arc::new(MultiThreadedCommentsInner { leading, trailing }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexing.rs:51:14 [INFO] [stdout] | [INFO] [stdout] 49 | .map(|token| LexedItem { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | range: token.range().as_byte_range(start_pos), [INFO] [stdout] 51 | inner: TokenOrComment::Token(token.token), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexing.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 55 | tokens.extend(flatten_comments(comments).map(|comment| LexedItem { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | range: comment.range().as_byte_range(start_pos), [INFO] [stdout] 57 | inner: TokenOrComment::Comment { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | kind: comment.kind, [INFO] [stdout] 59 | | text: comment.text, [INFO] [stdout] 60 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexing.rs:76:3 [INFO] [stdout] | [INFO] [stdout] 69 | comments: SingleThreadedComments, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | ) -> impl Iterator { [INFO] [stdout] 71 | let (leading, trailing) = comments.take_all(); [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let leading = Rc::try_unwrap(leading).unwrap().into_inner(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let trailing = Rc::try_unwrap(trailing).unwrap().into_inner(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let mut comments = leading; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | comments.extend(trailing); [INFO] [stdout] 76 | comments.into_iter().flat_map(|el| el.1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsed_source.rs:54:52 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn with(&self, action: impl FnOnce(&Marks) -> T) -> T { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | crate::swc::common::GLOBALS.set(&self.globals, || action(&self.marks)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsed_source.rs:112:43 [INFO] [stdout] | [INFO] [stdout] 112 | .get_or_init(|| SourceTextInfo::new(self.text().clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 94 | params: ParseParams, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | post_process: impl FnOnce(Module, &Globals) -> Module, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / |program, globals| match program { [INFO] [stdout] 101 | | Program::Module(module) => Program::Module(post_process(module, globals)), [INFO] [stdout] 102 | | Program::Script(_) => unreachable!(), [INFO] [stdout] 103 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 116 | params: ParseParams, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | post_process: impl FnOnce(Script, &Globals) -> Script, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | / |program, globals| match program { [INFO] [stdout] 123 | | Program::Module(_) => unreachable!(), [INFO] [stdout] 124 | | Program::Script(script) => Program::Script(post_process(script, globals)), [INFO] [stdout] 125 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:201:6 [INFO] [stdout] | [INFO] [stdout] 136 | params: ParseParams, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | parse_mode: ParseMode, [INFO] [stdout] 138 | post_process: impl FnOnce(Program, &Globals) -> Program, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | ) -> Result { [INFO] [stdout] 140 | let source = strip_bom_from_arc(params.text, /* panic in debug */ true); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let (comments, program, tokens, errors) = [INFO] [stdout] | -------- ------- ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | let (diagnostics, maybe_text_info) = if errors.is_empty() { [INFO] [stdout] | ----------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let source_text_info = SourceTextInfo::new(source.clone()); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let globals = Globals::default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let program = post_process(program, &globals); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | [INFO] [stdout] 178 | let (program, syntax_contexts) = if params.scope_analysis { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let inner = crate::ParsedSourceInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | Ok(ParsedSource(Arc::new(inner))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 164 | .map(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | source_text_info.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:330:13 [INFO] [stdout] | [INFO] [stdout] 323 | err: crate::swc::parser::error::Error, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 324 | specifier: &ModuleSpecifier, [INFO] [stdout] 325 | source: SourceTextInfo, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | kind: err.into_kind(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `deno_ast` (lib) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comments.rs:47:14 [INFO] [stdout] | [INFO] [stdout] 43 | leading: SingleThreadedCommentsMapInner, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | trailing: SingleThreadedCommentsMapInner, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | inner: Arc::new(MultiThreadedCommentsInner { leading, trailing }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comments.rs:264:6 [INFO] [stdout] | [INFO] [stdout] 255 | let module = parse_module(ParseParams { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 264 | (module.comments().as_single_threaded(), module.range().start) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexing.rs:51:14 [INFO] [stdout] | [INFO] [stdout] 49 | .map(|token| LexedItem { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | range: token.range().as_byte_range(start_pos), [INFO] [stdout] 51 | inner: TokenOrComment::Token(token.token), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexing.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 55 | tokens.extend(flatten_comments(comments).map(|comment| LexedItem { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | range: comment.range().as_byte_range(start_pos), [INFO] [stdout] 57 | inner: TokenOrComment::Comment { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | kind: comment.kind, [INFO] [stdout] 59 | | text: comment.text, [INFO] [stdout] 60 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexing.rs:76:3 [INFO] [stdout] | [INFO] [stdout] 69 | comments: SingleThreadedComments, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | ) -> impl Iterator { [INFO] [stdout] 71 | let (leading, trailing) = comments.take_all(); [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let leading = Rc::try_unwrap(leading).unwrap().into_inner(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let trailing = Rc::try_unwrap(trailing).unwrap().into_inner(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let mut comments = leading; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | comments.extend(trailing); [INFO] [stdout] 76 | comments.into_iter().flat_map(|el| el.1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsed_source.rs:54:52 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn with(&self, action: impl FnOnce(&Marks) -> T) -> T { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | crate::swc::common::GLOBALS.set(&self.globals, || action(&self.marks)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsed_source.rs:112:43 [INFO] [stdout] | [INFO] [stdout] 112 | .get_or_init(|| SourceTextInfo::new(self.text().clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 94 | params: ParseParams, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | post_process: impl FnOnce(Module, &Globals) -> Module, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / |program, globals| match program { [INFO] [stdout] 101 | | Program::Module(module) => Program::Module(post_process(module, globals)), [INFO] [stdout] 102 | | Program::Script(_) => unreachable!(), [INFO] [stdout] 103 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 116 | params: ParseParams, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | post_process: impl FnOnce(Script, &Globals) -> Script, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | / |program, globals| match program { [INFO] [stdout] 123 | | Program::Module(_) => unreachable!(), [INFO] [stdout] 124 | | Program::Script(script) => Program::Script(post_process(script, globals)), [INFO] [stdout] 125 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:201:6 [INFO] [stdout] | [INFO] [stdout] 136 | params: ParseParams, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | parse_mode: ParseMode, [INFO] [stdout] 138 | post_process: impl FnOnce(Program, &Globals) -> Program, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | ) -> Result { [INFO] [stdout] 140 | let source = strip_bom_from_arc(params.text, /* panic in debug */ true); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let (comments, program, tokens, errors) = [INFO] [stdout] | -------- ------- ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | let (diagnostics, maybe_text_info) = if errors.is_empty() { [INFO] [stdout] | ----------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let source_text_info = SourceTextInfo::new(source.clone()); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let globals = Globals::default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let program = post_process(program, &globals); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | [INFO] [stdout] 178 | let (program, syntax_contexts) = if params.scope_analysis { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let inner = crate::ParsedSourceInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | Ok(ParsedSource(Arc::new(inner))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 164 | .map(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | source_text_info.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:330:13 [INFO] [stdout] | [INFO] [stdout] 323 | err: crate::swc::parser::error::Error, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 324 | specifier: &ModuleSpecifier, [INFO] [stdout] 325 | source: SourceTextInfo, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | kind: err.into_kind(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `deno_ast` (lib test) due to 13 previous errors [INFO] running `Command { std: "docker" "inspect" "f1def67266ff5aa83ab7db7bb994ee482378ec29a795db0fc1eb2007e8fbdb2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1def67266ff5aa83ab7db7bb994ee482378ec29a795db0fc1eb2007e8fbdb2f", kill_on_drop: false }` [INFO] [stdout] f1def67266ff5aa83ab7db7bb994ee482378ec29a795db0fc1eb2007e8fbdb2f