[INFO] fetching crate deluge-rpc-macro 0.6.2... [INFO] checking deluge-rpc-macro-0.6.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate deluge-rpc-macro 0.6.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate deluge-rpc-macro 0.6.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate deluge-rpc-macro 0.6.2 [INFO] finished tweaking crates.io crate deluge-rpc-macro 0.6.2 [INFO] tweaked toml for crates.io crate deluge-rpc-macro 0.6.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b08838b0285333c190cdebcf58142497f5629381e89503dbc5cf9e356cc52e4f [INFO] running `Command { std: "docker" "start" "-a" "b08838b0285333c190cdebcf58142497f5629381e89503dbc5cf9e356cc52e4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b08838b0285333c190cdebcf58142497f5629381e89503dbc5cf9e356cc52e4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b08838b0285333c190cdebcf58142497f5629381e89503dbc5cf9e356cc52e4f", kill_on_drop: false }` [INFO] [stdout] b08838b0285333c190cdebcf58142497f5629381e89503dbc5cf9e356cc52e4f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4209d7590fe6088ee40e403a9e3f541d1b767c5b8b7f345a45f5a7229bc2eb13 [INFO] running `Command { std: "docker" "start" "-a" "4209d7590fe6088ee40e403a9e3f541d1b767c5b8b7f345a45f5a7229bc2eb13", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking deluge-rpc-macro v0.6.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `rpcness` is never read [INFO] [stdout] --> src/rpc_class.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 36 | struct RpcMethod { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 39 | rpcness: kw::rpc, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RpcMethod` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `impl_token`, `separator`, and `semi_token` are never read [INFO] [stdout] --> src/rpc_class.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 90 | struct RpcClass { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 91 | attrs: Vec, [INFO] [stdout] 92 | impl_token: Token![impl], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 93 | struct_name: Ident, [INFO] [stdout] 94 | separator: Token![::], [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 95 | class_name: Ident, [INFO] [stdout] 96 | semi_token: Token![;], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RpcClass` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc_class.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 125 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 127 | | paren_token: syn::parenthesized!(content in input), [INFO] [stdout] 128 | | args: content.parse_terminated(NestedMeta::parse)?, [INFO] [stdout] 129 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc_class.rs:215:26 [INFO] [stdout] | [INFO] [stdout] 215 | .map(|arg| match arg.as_ref().clone() { Pat::Ident(id) => id.ident.clone(), _ => panic!("args must just be names") }) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `deluge-rpc-macro` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `rpcness` is never read [INFO] [stdout] --> src/rpc_class.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 36 | struct RpcMethod { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 39 | rpcness: kw::rpc, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RpcMethod` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `impl_token`, `separator`, and `semi_token` are never read [INFO] [stdout] --> src/rpc_class.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 90 | struct RpcClass { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 91 | attrs: Vec, [INFO] [stdout] 92 | impl_token: Token![impl], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 93 | struct_name: Ident, [INFO] [stdout] 94 | separator: Token![::], [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 95 | class_name: Ident, [INFO] [stdout] 96 | semi_token: Token![;], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RpcClass` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc_class.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 125 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 127 | | paren_token: syn::parenthesized!(content in input), [INFO] [stdout] 128 | | args: content.parse_terminated(NestedMeta::parse)?, [INFO] [stdout] 129 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc_class.rs:215:26 [INFO] [stdout] | [INFO] [stdout] 215 | .map(|arg| match arg.as_ref().clone() { Pat::Ident(id) => id.ident.clone(), _ => panic!("args must just be names") }) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `deluge-rpc-macro` (lib) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4209d7590fe6088ee40e403a9e3f541d1b767c5b8b7f345a45f5a7229bc2eb13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4209d7590fe6088ee40e403a9e3f541d1b767c5b8b7f345a45f5a7229bc2eb13", kill_on_drop: false }` [INFO] [stdout] 4209d7590fe6088ee40e403a9e3f541d1b767c5b8b7f345a45f5a7229bc2eb13