[INFO] fetching crate delharc 0.6.1... [INFO] checking delharc-0.6.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate delharc 0.6.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate delharc 0.6.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate delharc 0.6.1 [INFO] removed 1 missing examples [INFO] removed 18 missing tests [INFO] finished tweaking crates.io crate delharc 0.6.1 [INFO] tweaked toml for crates.io crate delharc 0.6.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate delharc 0.6.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bb26d983f6ab21fc1821baa83b01d74407f1b11686872d85cd2ce4f210840593 [INFO] running `Command { std: "docker" "start" "-a" "bb26d983f6ab21fc1821baa83b01d74407f1b11686872d85cd2ce4f210840593", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bb26d983f6ab21fc1821baa83b01d74407f1b11686872d85cd2ce4f210840593", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb26d983f6ab21fc1821baa83b01d74407f1b11686872d85cd2ce4f210840593", kill_on_drop: false }` [INFO] [stdout] bb26d983f6ab21fc1821baa83b01d74407f1b11686872d85cd2ce4f210840593 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dceeb5efc3c1667ab8c382952cadaf135d6e3084f90a40a517483c99a80c6b67 [INFO] running `Command { std: "docker" "start" "-a" "dceeb5efc3c1667ab8c382952cadaf135d6e3084f90a40a517483c99a80c6b67", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking crc-any v2.5.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking delharc v0.6.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:159:6 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn parse_file>(path: P) -> std::io::Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | Ok(LhaDecodeReader::new(file)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn new(mut rd: R) -> Result, LhaDecodeError> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let header = match LhaHeader::read(rd.by_ref()).and_then(|h| [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok(h) => h, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | Err(e) => return Err(wrap_err(rd, e)) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | }; [INFO] [stdout] 156 | let decoder = DecoderAny::new_from_header(&header, rd); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let crc = Crc16::default(); [INFO] [stdout] 158 | Ok(LhaDecodeReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 159 | | header, [INFO] [stdout] 160 | | crc, [INFO] [stdout] 161 | | output_length: 0, [INFO] [stdout] 162 | | decoder: Some(decoder) [INFO] [stdout] 163 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:253:24 [INFO] [stdout] | [INFO] [stdout] 247 | let mut limited_rd = self.decoder.take().expect("decoder not empty").into_inner(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | self.begin_new(limited_rd.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 263 | pub fn into_inner(self) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | self.decoder.expect("decoder not empty").into_inner().into_inner() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:273:43 [INFO] [stdout] | [INFO] [stdout] 273 | self.decoder.take().map(|decoder| decoder.into_inner().into_inner()) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header/parser.rs:363:12 [INFO] [stdout] | [INFO] [stdout] 195 | let filename = if raw_header.lha_level < 2 { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | let mut extended_area: Box<[u8]> = Box::new([]); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | let extra_headers = extra_headers.into_boxed_slice(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 362 | [INFO] [stdout] 363 | Ok(Some(LhaHeader { [INFO] [stdout] | ____________^ [INFO] [stdout] 364 | | level: raw_header.lha_level, [INFO] [stdout] 365 | | compression, [INFO] [stdout] 366 | | compressed_size, [INFO] [stdout] ... | [INFO] [stdout] 375 | | extra_headers [INFO] [stdout] 376 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `delharc` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:159:6 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn parse_file>(path: P) -> std::io::Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | Ok(LhaDecodeReader::new(file)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn new(mut rd: R) -> Result, LhaDecodeError> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let header = match LhaHeader::read(rd.by_ref()).and_then(|h| [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok(h) => h, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | Err(e) => return Err(wrap_err(rd, e)) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | }; [INFO] [stdout] 156 | let decoder = DecoderAny::new_from_header(&header, rd); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let crc = Crc16::default(); [INFO] [stdout] 158 | Ok(LhaDecodeReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 159 | | header, [INFO] [stdout] 160 | | crc, [INFO] [stdout] 161 | | output_length: 0, [INFO] [stdout] 162 | | decoder: Some(decoder) [INFO] [stdout] 163 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:253:24 [INFO] [stdout] | [INFO] [stdout] 247 | let mut limited_rd = self.decoder.take().expect("decoder not empty").into_inner(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | self.begin_new(limited_rd.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 263 | pub fn into_inner(self) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | self.decoder.expect("decoder not empty").into_inner().into_inner() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:273:43 [INFO] [stdout] | [INFO] [stdout] 273 | self.decoder.take().map(|decoder| decoder.into_inner().into_inner()) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header/parser.rs:363:12 [INFO] [stdout] | [INFO] [stdout] 195 | let filename = if raw_header.lha_level < 2 { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | let mut extended_area: Box<[u8]> = Box::new([]); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | let extra_headers = extra_headers.into_boxed_slice(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 362 | [INFO] [stdout] 363 | Ok(Some(LhaHeader { [INFO] [stdout] | ____________^ [INFO] [stdout] 364 | | level: raw_header.lha_level, [INFO] [stdout] 365 | | compression, [INFO] [stdout] 366 | | compressed_size, [INFO] [stdout] ... | [INFO] [stdout] 375 | | extra_headers [INFO] [stdout] 376 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `delharc` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "dceeb5efc3c1667ab8c382952cadaf135d6e3084f90a40a517483c99a80c6b67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dceeb5efc3c1667ab8c382952cadaf135d6e3084f90a40a517483c99a80c6b67", kill_on_drop: false }` [INFO] [stdout] dceeb5efc3c1667ab8c382952cadaf135d6e3084f90a40a517483c99a80c6b67