[INFO] fetching crate defmt-test-macros 0.3.1... [INFO] checking defmt-test-macros-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate defmt-test-macros 0.3.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate defmt-test-macros 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate defmt-test-macros 0.3.1 [INFO] finished tweaking crates.io crate defmt-test-macros 0.3.1 [INFO] tweaked toml for crates.io crate defmt-test-macros 0.3.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e8c8efa010b4349da76dd52469fd2a88515a97c18ea9d240ee0129843d8d1b95 [INFO] running `Command { std: "docker" "start" "-a" "e8c8efa010b4349da76dd52469fd2a88515a97c18ea9d240ee0129843d8d1b95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e8c8efa010b4349da76dd52469fd2a88515a97c18ea9d240ee0129843d8d1b95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e8c8efa010b4349da76dd52469fd2a88515a97c18ea9d240ee0129843d8d1b95", kill_on_drop: false }` [INFO] [stdout] e8c8efa010b4349da76dd52469fd2a88515a97c18ea9d240ee0129843d8d1b95 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 591d3306428bbf13507416697cc8e5cfb9110068b50422697d62fc7c4a9bc0db [INFO] running `Command { std: "docker" "start" "-a" "591d3306428bbf13507416697cc8e5cfb9110068b50422697d62fc7c4a9bc0db", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking defmt-test-macros v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:12:11 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn tests(args: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | match tests_impl(args, input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:415:8 [INFO] [stdout] | [INFO] [stdout] 18 | fn tests_impl(args: TokenStream, input: TokenStream) -> parse::Result { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let module: ItemMod = syn::parse(input)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | let items = if let Some(content) = module.content { [INFO] [stdout] | ----- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let mut init = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let mut before_each = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let mut after_each = None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut tests = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let mut untouched_tokens = vec![]; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | let krate = format_ident!("defmt_test"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | let ident = module.ident; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let mut state_ty = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | let (init_fn, init_expr) = if let Some(init) = init { [INFO] [stdout] | ------- --------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | Some(quote!(#init_func)), [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | Some(quote!(#[allow(dead_code)] let mut state = #init_ident();)), [INFO] [stdout] | ---------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | let (before_each_fn, before_each_call) = if let Some(before_each) = before_each { [INFO] [stdout] | -------------- ---------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | let call = if let Some(input) = before_each.input.as_ref() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 301 | quote!(#before_each_ident(&mut state)) [INFO] [stdout] | -------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | } else { [INFO] [stdout] 303 | quote!(#before_each_ident()) [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | (Some(quote!(#before_each_func)), Some(quote!(#call))) [INFO] [stdout] | ------------------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | let (after_each_fn, after_each_call) = if let Some(after_each) = after_each { [INFO] [stdout] | ------------- --------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | let call = if let Some(input) = after_each.input.as_ref() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | quote!(#after_each_ident(&mut state)) [INFO] [stdout] | ------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 335 | } else { [INFO] [stdout] 336 | quote!(#after_each_ident()) [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | (Some(quote!(#after_each_func)), Some(quote!(#call))) [INFO] [stdout] | ------------------------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | let mut unit_test_calls = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 385 | let declare_test_count = { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 386 | let test_cfgs = test_cfgs.clone(); [INFO] [stdout] 387 | / quote!( [INFO] [stdout] 388 | | // We can't evaluate `#[cfg]`s in the macro, but this works too. [INFO] [stdout] 389 | | // Below value can be used to read the number of tests from the produced ELF. [INFO] [stdout] 390 | | #[used] [INFO] [stdout] ... | [INFO] [stdout] 399 | | }; [INFO] [stdout] 400 | | ) [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 401 | }; [INFO] [stdout] 402 | | let unit_test_progress = tests [INFO] [stdout] | | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 415 | Ok(quote!( [INFO] [stdout] | ________^ [INFO] [stdout] | |________| [INFO] [stdout] 416 | | #[cfg(test)] [INFO] [stdout] 417 | | mod #ident { [INFO] [stdout] 418 | | #(#untouched_tokens)* [INFO] [stdout] ... | [INFO] [stdout] 448 | | }) [INFO] [stdout] 449 | | .into()) [INFO] [stdout] | |___________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `defmt-test-macros` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "591d3306428bbf13507416697cc8e5cfb9110068b50422697d62fc7c4a9bc0db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "591d3306428bbf13507416697cc8e5cfb9110068b50422697d62fc7c4a9bc0db", kill_on_drop: false }` [INFO] [stdout] 591d3306428bbf13507416697cc8e5cfb9110068b50422697d62fc7c4a9bc0db