[INFO] fetching crate defmt-macros 0.3.9... [INFO] checking defmt-macros-0.3.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate defmt-macros 0.3.9 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate defmt-macros 0.3.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate defmt-macros 0.3.9 [INFO] finished tweaking crates.io crate defmt-macros 0.3.9 [INFO] tweaked toml for crates.io crate defmt-macros 0.3.9 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding rstest v0.19.0 (latest: v0.22.0) [INFO] [stderr] Adding rstest_macros v0.19.0 (latest: v0.22.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e49b0332ad7ce960e2f81268c392f44f07f5c170f7edb19499c2f4d767937396 [INFO] running `Command { std: "docker" "start" "-a" "e49b0332ad7ce960e2f81268c392f44f07f5c170f7edb19499c2f4d767937396", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e49b0332ad7ce960e2f81268c392f44f07f5c170f7edb19499c2f4d767937396", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e49b0332ad7ce960e2f81268c392f44f07f5c170f7edb19499c2f4d767937396", kill_on_drop: false }` [INFO] [stdout] e49b0332ad7ce960e2f81268c392f44f07f5c170f7edb19499c2f4d767937396 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8e1e3e20fa2d648dc10be5eea1d88a8118880b409dc740b0841f8e88dd2c1a86 [INFO] running `Command { std: "docker" "start" "-a" "8e1e3e20fa2d648dc10be5eea1d88a8118880b409dc740b0841f8e88dd2c1a86", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling defmt-macros v0.3.9 (/opt/rustwide/workdir) [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking defmt-parser v0.3.4 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling rstest_macros v0.19.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derives/format/codegen.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 20 | let mut stmts = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let mut field_patterns = vec![]; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | [INFO] [stdout] 23 | let (encode_fields_stmts, where_predicates) = [INFO] [stdout] | ------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let format_tag = construct::interned_string(&format_string, "derived", false); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Ok(EncodeData { [INFO] [stdout] | ________^ [INFO] [stdout] 34 | | format_tag, [INFO] [stdout] 35 | | stmts, [INFO] [stdout] 36 | | where_predicates, [INFO] [stdout] 37 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derives/format/codegen/enum_data.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 20 | let mut where_predicates = vec![]; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | let mut match_arms = vec![]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let format_tag = construct::interned_string(&format_string, "derived", false); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let stmts = vec![quote!(match self { [INFO] [stdout] | _________-----________- [INFO] [stdout] | |_________|____________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | | #(#match_arms)* [INFO] [stdout] 55 | | })]; [INFO] [stdout] | | - [INFO] [stdout] | |______| [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(EncodeData { [INFO] [stdout] | ________^ [INFO] [stdout] 59 | format_tag, [INFO] [stdout] 60 | stmts, [INFO] [stdout] 61 | where_predicates, [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derives/format/codegen/fields.rs:90:8 [INFO] [stdout] | [INFO] [stdout] 30 | let mut stmts = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let mut where_predicates = vec![]; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Ok((stmts, where_predicates)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_like/dbg.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 17 | let tuple_exprs = args [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | / if tuple_exprs.is_empty() { [INFO] [stdout] 34 | | // for compatibility with `std::dbg!` we also emit a TRACE log in this case [INFO] [stdout] 35 | | quote!(defmt::trace!("")) [INFO] [stdout] 36 | | } else { [INFO] [stdout] 37 | | quote![ (#(#tuple_exprs),*) ] [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_like/intern.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) fn expand(args: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | let literal = parse_macro_input!(args as LitStr); [INFO] [stdout] | ------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | construct::interned_string(&literal.value(), "str", false).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_like/log.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) fn expand(level: Level, args: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | expand_parsed(level, parse_macro_input!(args as Args)).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_like/log.rs:30:27 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|punctuated| punctuated.into_iter().collect::>()) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_like/println.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) fn expand(args: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | expand_parsed(parse_macro_input!(args as Args)).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_like/println.rs:28:27 [INFO] [stdout] | [INFO] [stdout] 28 | .map(|punctuated| punctuated.into_iter().collect::>()) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_like/write.rs:28:27 [INFO] [stdout] | [INFO] [stdout] 28 | .map(|punctuated| punctuated.into_iter().collect()) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/items/bitflags/input.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 21 | let flags; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | struct_attrs: Attribute::parse_outer(input)?, [INFO] [stdout] 24 | | vis: input.parse()?, [INFO] [stdout] 25 | | struct_token: input.parse()?, [INFO] [stdout] ... | [INFO] [stdout] 30 | | flags: Punctuated::parse_terminated(&flags)?, [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/items/bitflags/input.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 61 | let const_attrs = Attribute::parse_outer(input)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | cfg_attrs: extract_cfgs(&const_attrs), [INFO] [stdout] 64 | | const_attrs, [INFO] [stdout] 65 | | const_token: input.parse()?, [INFO] [stdout] ... | [INFO] [stdout] 68 | | value: input.parse()?, [INFO] [stdout] 69 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/items/timestamp.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|punctuated| punctuated.into_iter().collect()) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `defmt-macros` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8e1e3e20fa2d648dc10be5eea1d88a8118880b409dc740b0841f8e88dd2c1a86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e1e3e20fa2d648dc10be5eea1d88a8118880b409dc740b0841f8e88dd2c1a86", kill_on_drop: false }` [INFO] [stdout] 8e1e3e20fa2d648dc10be5eea1d88a8118880b409dc740b0841f8e88dd2c1a86