[INFO] fetching crate declaration 0.1.0... [INFO] checking declaration-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate declaration 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate declaration 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate declaration 0.1.0 [INFO] finished tweaking crates.io crate declaration 0.1.0 [INFO] tweaked toml for crates.io crate declaration 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4b8851723769827081c284aa7456d5a1dbc651081bd6fd71226fb45db9cf97c1 [INFO] running `Command { std: "docker" "start" "-a" "4b8851723769827081c284aa7456d5a1dbc651081bd6fd71226fb45db9cf97c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4b8851723769827081c284aa7456d5a1dbc651081bd6fd71226fb45db9cf97c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b8851723769827081c284aa7456d5a1dbc651081bd6fd71226fb45db9cf97c1", kill_on_drop: false }` [INFO] [stdout] 4b8851723769827081c284aa7456d5a1dbc651081bd6fd71226fb45db9cf97c1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9afdb163edb2291be0d2502273117d85fe0fe990aa6fa5f4ac816f3b75188547 [INFO] running `Command { std: "docker" "start" "-a" "9afdb163edb2291be0d2502273117d85fe0fe990aa6fa5f4ac816f3b75188547", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking declaration v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn apply(&self, t1: Term, t2: Term) -> Result { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(if t1.is_float() || t2.is_float() { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | Term::LiteralFloat(self.apply_literals( [INFO] [stdout] 60 | | t1.extract_f64().expect("Unexpected non-float value"), [INFO] [stdout] 61 | | t2.extract_f64().expect("Unexpected non-float value"), [INFO] [stdout] ... | [INFO] [stdout] 67 | | )?) [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn apply_literals(&self, t1: T, t2: T) -> Result [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | Operator::Add => t1 + t2, [INFO] [stdout] 80 | | Operator::Sub => t1 - t2, [INFO] [stdout] 81 | | Operator::Mul => t1 * t2, [INFO] [stdout] ... | [INFO] [stdout] 87 | | } [INFO] [stdout] 88 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:336:5 [INFO] [stdout] | [INFO] [stdout] 295 | fn infix_to_term(mut terms: Vec) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | let mut stack = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 304 | let mut second = None; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | stack.pop().ok_or(Error::default_parse_error()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:506:13 [INFO] [stdout] | [INFO] [stdout] 495 | let elements = extract_elements( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 500 | let r = shunting_yard(elements); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 501 | let t = infix_to_term(r); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 502 | assert!(t.is_ok()); [INFO] [stdout] 503 | let t = t.unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 506 | / Term::BinaryOperator( [INFO] [stdout] 507 | | Operator::Add, [INFO] [stdout] 508 | | Box::from(Term::BinaryOperator( [INFO] [stdout] 509 | | Operator::Mul, [INFO] [stdout] ... | [INFO] [stdout] 525 | | )) [INFO] [stdout] 526 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `declaration` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn apply(&self, t1: Term, t2: Term) -> Result { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(if t1.is_float() || t2.is_float() { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | Term::LiteralFloat(self.apply_literals( [INFO] [stdout] 60 | | t1.extract_f64().expect("Unexpected non-float value"), [INFO] [stdout] 61 | | t2.extract_f64().expect("Unexpected non-float value"), [INFO] [stdout] ... | [INFO] [stdout] 67 | | )?) [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn apply_literals(&self, t1: T, t2: T) -> Result [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | Operator::Add => t1 + t2, [INFO] [stdout] 80 | | Operator::Sub => t1 - t2, [INFO] [stdout] 81 | | Operator::Mul => t1 * t2, [INFO] [stdout] ... | [INFO] [stdout] 87 | | } [INFO] [stdout] 88 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:336:5 [INFO] [stdout] | [INFO] [stdout] 295 | fn infix_to_term(mut terms: Vec) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | let mut stack = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 304 | let mut second = None; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | stack.pop().ok_or(Error::default_parse_error()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `declaration` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "9afdb163edb2291be0d2502273117d85fe0fe990aa6fa5f4ac816f3b75188547", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9afdb163edb2291be0d2502273117d85fe0fe990aa6fa5f4ac816f3b75188547", kill_on_drop: false }` [INFO] [stdout] 9afdb163edb2291be0d2502273117d85fe0fe990aa6fa5f4ac816f3b75188547