[INFO] fetching crate debian-changelog 0.1.12... [INFO] checking debian-changelog-0.1.12 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate debian-changelog 0.1.12 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate debian-changelog 0.1.12 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate debian-changelog 0.1.12 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate debian-changelog 0.1.12 [INFO] tweaked toml for crates.io crate debian-changelog 0.1.12 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate debian-changelog 0.1.12 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aa8f2936255c352c3488bf7213f0db402c3a6e377ee56e7bfccc9785cdd52e15 [INFO] running `Command { std: "docker" "start" "-a" "aa8f2936255c352c3488bf7213f0db402c3a6e377ee56e7bfccc9785cdd52e15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aa8f2936255c352c3488bf7213f0db402c3a6e377ee56e7bfccc9785cdd52e15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa8f2936255c352c3488bf7213f0db402c3a6e377ee56e7bfccc9785cdd52e15", kill_on_drop: false }` [INFO] [stdout] aa8f2936255c352c3488bf7213f0db402c3a6e377ee56e7bfccc9785cdd52e15 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 49585a6e6cd0d37cfd87b9a5a4011453228f3fd818f21a9e958f3e7ca16a8564 [INFO] running `Command { std: "docker" "start" "-a" "49585a6e6cd0d37cfd87b9a5a4011453228f3fd818f21a9e958f3e7ca16a8564", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Compiling aho-corasick v1.1.2 [INFO] [stderr] Checking rowan v0.15.15 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.2.0 [INFO] [stderr] Checking lazy-regex v3.2.0 [INFO] [stderr] Checking debversion v0.4.1 [INFO] [stderr] Checking debian-changelog v0.1.12 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parse.rs:859:13 [INFO] [stdout] | [INFO] [stdout] 859 | let mut f = std::fs::File::create(p)?; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `distributions` [INFO] [stdout] --> src/parse.rs:928:41 [INFO] [stdout] | [INFO] [stdout] 928 | pub fn set_distributions(&mut self, distributions: Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_distributions` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version` [INFO] [stdout] --> src/parse.rs:932:35 [INFO] [stdout] | [INFO] [stdout] 932 | pub fn set_version(&mut self, version: Version) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `package` [INFO] [stdout] --> src/parse.rs:936:35 [INFO] [stdout] | [INFO] [stdout] 936 | pub fn set_package(&mut self, package: String) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_package` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/parse.rs:940:36 [INFO] [stdout] | [INFO] [stdout] 940 | pub fn set_metadata(&mut self, key: &str, value: &str) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/parse.rs:940:47 [INFO] [stdout] | [INFO] [stdout] 940 | pub fn set_metadata(&mut self, key: &str, value: &str) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `maintainer` [INFO] [stdout] --> src/parse.rs:995:38 [INFO] [stdout] | [INFO] [stdout] 995 | pub fn set_maintainer(&mut self, maintainer: (String, String)) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_maintainer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `email` [INFO] [stdout] --> src/parse.rs:999:33 [INFO] [stdout] | [INFO] [stdout] 999 | pub fn set_email(&mut self, email: String) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_email` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `timestamp` [INFO] [stdout] --> src/parse.rs:1010:37 [INFO] [stdout] | [INFO] [stdout] 1010 | pub fn set_timestamp(&mut self, timestamp: String) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_timestamp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parse.rs:859:13 [INFO] [stdout] | [INFO] [stdout] 859 | let mut f = std::fs::File::create(p)?; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_email` is never used [INFO] [stdout] --> src/parse.rs:999:12 [INFO] [stdout] | [INFO] [stdout] 974 | impl EntryFooter { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 999 | pub fn set_email(&mut self, email: String) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `distributions` [INFO] [stdout] --> src/parse.rs:928:41 [INFO] [stdout] | [INFO] [stdout] 928 | pub fn set_distributions(&mut self, distributions: Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_distributions` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version` [INFO] [stdout] --> src/parse.rs:932:35 [INFO] [stdout] | [INFO] [stdout] 932 | pub fn set_version(&mut self, version: Version) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `package` [INFO] [stdout] --> src/parse.rs:936:35 [INFO] [stdout] | [INFO] [stdout] 936 | pub fn set_package(&mut self, package: String) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_package` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/parse.rs:940:36 [INFO] [stdout] | [INFO] [stdout] 940 | pub fn set_metadata(&mut self, key: &str, value: &str) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:262:5 [INFO] [stdout] | [INFO] [stdout] 249 | let mut entries = cl.entries(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | entries.next().is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/parse.rs:940:47 [INFO] [stdout] | [INFO] [stdout] 940 | pub fn set_metadata(&mut self, key: &str, value: &str) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `maintainer` [INFO] [stdout] --> src/parse.rs:995:38 [INFO] [stdout] | [INFO] [stdout] 995 | pub fn set_maintainer(&mut self, maintainer: (String, String)) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_maintainer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:367:29 [INFO] [stdout] | [INFO] [stdout] 340 | fn parse(mut self) -> Parse { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 367 | green_node: self.builder.finish(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `email` [INFO] [stdout] --> src/parse.rs:999:33 [INFO] [stdout] | [INFO] [stdout] 999 | pub fn set_email(&mut self, email: String) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_email` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `timestamp` [INFO] [stdout] --> src/parse.rs:1010:37 [INFO] [stdout] | [INFO] [stdout] 1010 | pub fn set_timestamp(&mut self, timestamp: String) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_timestamp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:714:19 [INFO] [stdout] | [INFO] [stdout] 708 | let mut builder = GreenNodeBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 713 | let syntax = SyntaxNode::new_root(builder.finish()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 714 | ChangeLog(syntax.clone_for_update()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:754:19 [INFO] [stdout] | [INFO] [stdout] 743 | let base_entry = self.first_valid_entry(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 754 | root: self.0.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:841:12 [INFO] [stdout] | [INFO] [stdout] 838 | pub fn read(mut r: R) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 841 | Ok(buf.parse()?) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:849:12 [INFO] [stdout] | [INFO] [stdout] 844 | pub fn read_relaxed(mut r: R) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 848 | let parsed = parse(&buf); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 849 | Ok(parsed.root().clone_for_update()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:915:13 [INFO] [stdout] | [INFO] [stdout] 914 | node.map(|node| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 915 | / node.children_with_tokens() [INFO] [stdout] 916 | | .filter_map(|it| { [INFO] [stdout] 917 | | if let Some(token) = it.as_token() { [INFO] [stdout] 918 | | if token.kind() == IDENTIFIER { [INFO] [stdout] ... | [INFO] [stdout] 922 | | None [INFO] [stdout] 923 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:947:9 [INFO] [stdout] | [INFO] [stdout] 945 | let node = self.0.children().find(|it| it.kind() == METADATA); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 946 | [INFO] [stdout] 947 | node.into_iter().flat_map(|node| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:948:13 [INFO] [stdout] | [INFO] [stdout] 947 | node.into_iter().flat_map(|node| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 948 | node.children_with_tokens() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:949:54 [INFO] [stdout] | [INFO] [stdout] 949 | .filter_map(|it| MetadataEntry::cast(it.into_node()?)) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:1281:32 [INFO] [stdout] | [INFO] [stdout] 1281 | .unwrap_or_else(|| self.0.children().next().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/changes.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 96 | changes: impl Iterator, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | ) -> impl Iterator, Vec, Vec<&'a str>)> { [INFO] [stdout] 98 | changes_sections(changes).flat_map(|section| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parse.rs:1740:9 [INFO] [stdout] | [INFO] [stdout] 1740 | let mut cl = ChangeLog::read(text.as_bytes()).unwrap(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `debian-changelog` (lib) due to 13 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `set_email` is never used [INFO] [stdout] --> src/parse.rs:999:12 [INFO] [stdout] | [INFO] [stdout] 974 | impl EntryFooter { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 999 | pub fn set_email(&mut self, email: String) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:262:5 [INFO] [stdout] | [INFO] [stdout] 249 | let mut entries = cl.entries(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | entries.next().is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:367:29 [INFO] [stdout] | [INFO] [stdout] 340 | fn parse(mut self) -> Parse { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 367 | green_node: self.builder.finish(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:714:19 [INFO] [stdout] | [INFO] [stdout] 708 | let mut builder = GreenNodeBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 713 | let syntax = SyntaxNode::new_root(builder.finish()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 714 | ChangeLog(syntax.clone_for_update()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:754:19 [INFO] [stdout] | [INFO] [stdout] 743 | let base_entry = self.first_valid_entry(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 754 | root: self.0.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:841:12 [INFO] [stdout] | [INFO] [stdout] 838 | pub fn read(mut r: R) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 841 | Ok(buf.parse()?) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:849:12 [INFO] [stdout] | [INFO] [stdout] 844 | pub fn read_relaxed(mut r: R) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 848 | let parsed = parse(&buf); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 849 | Ok(parsed.root().clone_for_update()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:915:13 [INFO] [stdout] | [INFO] [stdout] 914 | node.map(|node| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 915 | / node.children_with_tokens() [INFO] [stdout] 916 | | .filter_map(|it| { [INFO] [stdout] 917 | | if let Some(token) = it.as_token() { [INFO] [stdout] 918 | | if token.kind() == IDENTIFIER { [INFO] [stdout] ... | [INFO] [stdout] 922 | | None [INFO] [stdout] 923 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:947:9 [INFO] [stdout] | [INFO] [stdout] 945 | let node = self.0.children().find(|it| it.kind() == METADATA); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 946 | [INFO] [stdout] 947 | node.into_iter().flat_map(|node| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:948:13 [INFO] [stdout] | [INFO] [stdout] 947 | node.into_iter().flat_map(|node| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 948 | node.children_with_tokens() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:949:54 [INFO] [stdout] | [INFO] [stdout] 949 | .filter_map(|it| MetadataEntry::cast(it.into_node()?)) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:1281:32 [INFO] [stdout] | [INFO] [stdout] 1281 | .unwrap_or_else(|| self.0.children().next().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/changes.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 96 | changes: impl Iterator, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | ) -> impl Iterator, Vec, Vec<&'a str>)> { [INFO] [stdout] 98 | changes_sections(changes).flat_map(|section| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `debian-changelog` (lib test) due to 13 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "49585a6e6cd0d37cfd87b9a5a4011453228f3fd818f21a9e958f3e7ca16a8564", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49585a6e6cd0d37cfd87b9a5a4011453228f3fd818f21a9e958f3e7ca16a8564", kill_on_drop: false }` [INFO] [stdout] 49585a6e6cd0d37cfd87b9a5a4011453228f3fd818f21a9e958f3e7ca16a8564