[INFO] fetching crate dds-rs 0.7.0... [INFO] checking dds-rs-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dds-rs 0.7.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate dds-rs 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dds-rs 0.7.0 [INFO] finished tweaking crates.io crate dds-rs 0.7.0 [INFO] tweaked toml for crates.io crate dds-rs 0.7.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 35 packages to latest compatible versions [INFO] [stderr] Adding bincode v0.8.0 (latest: v1.3.3) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding deflate v0.7.20 (latest: v1.0.0) [INFO] [stderr] Adding gif v0.9.2 (latest: v0.13.1) [INFO] [stderr] Adding image v0.18.0 (latest: v0.25.2) [INFO] [stderr] Adding inflate v0.3.4 (latest: v0.4.5) [INFO] [stderr] Adding jpeg-decoder v0.1.22 (latest: v0.3.1) [INFO] [stderr] Adding num-rational v0.1.42 (latest: v0.4.2) [INFO] [stderr] Adding num-traits v0.1.43 (latest: v0.2.19) [INFO] [stderr] Adding png v0.11.0 (latest: v0.17.13) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 45fa5fc3d7d43af7c5962939a31f79f5dcf689e4d513006f528a19556e945313 [INFO] running `Command { std: "docker" "start" "-a" "45fa5fc3d7d43af7c5962939a31f79f5dcf689e4d513006f528a19556e945313", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "45fa5fc3d7d43af7c5962939a31f79f5dcf689e4d513006f528a19556e945313", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45fa5fc3d7d43af7c5962939a31f79f5dcf689e4d513006f528a19556e945313", kill_on_drop: false }` [INFO] [stdout] 45fa5fc3d7d43af7c5962939a31f79f5dcf689e4d513006f528a19556e945313 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8146c524cf5584789e79d1925c78600997069f18dcd030338b9212f4aaf23e49 [INFO] running `Command { std: "docker" "start" "-a" "8146c524cf5584789e79d1925c78600997069f18dcd030338b9212f4aaf23e49", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking inflate v0.3.4 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking bincode v0.8.0 [INFO] [stderr] Checking gif v0.9.2 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking dds-rs v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:594:38 [INFO] [stdout] | [INFO] [stdout] 594 | let chunk_transform: Box Vec>> = match header.compression { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 594 | let chunk_transform: Box Vec>> = match header.compression { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:553:39 [INFO] [stdout] | [INFO] [stdout] 553 | t => unreachable!(format!("This value should not have occurred: `{:?}`", t)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `unreachable!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `unreachable!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 553 - t => unreachable!(format!("This value should not have occurred: `{:?}`", t)), [INFO] [stdout] 553 + t => unreachable!("This value should not have occurred: `{:?}`", t), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:607:13 [INFO] [stdout] | [INFO] [stdout] 594 | let chunk_transform: Box Vec>> = match header.compression { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 607 | / data_buf [INFO] [stdout] 608 | | // Remove the pixels we care about from the buffer [INFO] [stdout] 609 | | .drain(..layer_bytes) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:604:35 [INFO] [stdout] | [INFO] [stdout] 604 | _ => unreachable!(format!("This function cannot handle `{:?}` images", header.compression)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `unreachable!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `unreachable!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 604 - _ => unreachable!(format!("This function cannot handle `{:?}` images", header.compression)), [INFO] [stdout] 604 + _ => unreachable!("This function cannot handle `{:?}` images", header.compression), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dds-rs` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8146c524cf5584789e79d1925c78600997069f18dcd030338b9212f4aaf23e49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8146c524cf5584789e79d1925c78600997069f18dcd030338b9212f4aaf23e49", kill_on_drop: false }` [INFO] [stdout] 8146c524cf5584789e79d1925c78600997069f18dcd030338b9212f4aaf23e49