[INFO] fetching crate ddbug_parser 0.4.0... [INFO] checking ddbug_parser-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ddbug_parser 0.4.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ddbug_parser 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ddbug_parser 0.4.0 [INFO] finished tweaking crates.io crate ddbug_parser 0.4.0 [INFO] tweaked toml for crates.io crate ddbug_parser 0.4.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 24 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 98b777c0452ab8d4027e08596e6a66132360f1d13729158c3f5c5a60d6ed6535 [INFO] running `Command { std: "docker" "start" "-a" "98b777c0452ab8d4027e08596e6a66132360f1d13729158c3f5c5a60d6ed6535", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "98b777c0452ab8d4027e08596e6a66132360f1d13729158c3f5c5a60d6ed6535", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98b777c0452ab8d4027e08596e6a66132360f1d13729158c3f5c5a60d6ed6535", kill_on_drop: false }` [INFO] [stdout] 98b777c0452ab8d4027e08596e6a66132360f1d13729158c3f5c5a60d6ed6535 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b812660f5e764a4bbd8b79e7566180c047d791855c20faddd00cb82765d3f48 [INFO] running `Command { std: "docker" "start" "-a" "4b812660f5e764a4bbd8b79e7566180c047d791855c20faddd00cb82765d3f48", kill_on_drop: false }` [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking wasmparser v0.216.0 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking ruzstd v0.7.1 [INFO] [stderr] Checking gimli v0.31.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking ddbug_parser v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/mod.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 132 | fn new(map: memmap2::Mmap, f: F) -> Result [INFO] [stdout] | ------------------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let arena = Box::new(Arena::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let file = f(&map, &arena)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | Ok(FileContext { [INFO] [stdout] | ____________^ [INFO] [stdout] 139 | | // `file` only borrows from `map` and `arena`, which we are preserving [INFO] [stdout] 140 | | // without moving. [INFO] [stdout] 141 | | file: unsafe { mem::transmute::, File<'static>>(file) }, [INFO] [stdout] 142 | | _map: map, [INFO] [stdout] 143 | | _arena: arena, [INFO] [stdout] 144 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/dwarf.rs:440:8 [INFO] [stdout] | [INFO] [stdout] 410 | let read = gimli::Dwarf::load(get_section)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 426 | let mut dwarf = DwarfDebugInfo { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 434 | let mut units = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 440 | Ok((units, DebugInfo::Dwarf(dwarf))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/dwarf.rs:1006:8 [INFO] [stdout] | [INFO] [stdout] 935 | let mut ty = Type::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1006 | Ok(Some(ty)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/dwarf.rs:3163:8 [INFO] [stdout] | [INFO] [stdout] 3079 | namespace: Option>>, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3087 | let mut variable = Variable { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3163 | Ok(DwarfVariable { [INFO] [stdout] | ________^ [INFO] [stdout] 3164 | | offset, [INFO] [stdout] 3165 | | specification, [INFO] [stdout] 3166 | | variable, [INFO] [stdout] 3167 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/dwarf.rs:3984:26 [INFO] [stdout] | [INFO] [stdout] 3979 | debug_frame: gimli::DebugFrame, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 3980 | eh_frame: gimli::EhFrame, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3984 | debug_frame: DebugFrameTable::new(debug_frame), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/dwarf.rs:3985:23 [INFO] [stdout] | [INFO] [stdout] 3979 | debug_frame: gimli::DebugFrame, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 3980 | eh_frame: gimli::EhFrame, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3985 | eh_frame: EhFrameTable::new(eh_frame, bases), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:139:25 [INFO] [stdout] | [INFO] [stdout] 139 | .or_else(|| hash.file.get_type(offset).map(Cow::Owned)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ddbug_parser` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/mod.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 132 | fn new(map: memmap2::Mmap, f: F) -> Result [INFO] [stdout] | ------------------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let arena = Box::new(Arena::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let file = f(&map, &arena)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | Ok(FileContext { [INFO] [stdout] | ____________^ [INFO] [stdout] 139 | | // `file` only borrows from `map` and `arena`, which we are preserving [INFO] [stdout] 140 | | // without moving. [INFO] [stdout] 141 | | file: unsafe { mem::transmute::, File<'static>>(file) }, [INFO] [stdout] 142 | | _map: map, [INFO] [stdout] 143 | | _arena: arena, [INFO] [stdout] 144 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/dwarf.rs:440:8 [INFO] [stdout] | [INFO] [stdout] 410 | let read = gimli::Dwarf::load(get_section)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 426 | let mut dwarf = DwarfDebugInfo { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 434 | let mut units = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 440 | Ok((units, DebugInfo::Dwarf(dwarf))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/dwarf.rs:1006:8 [INFO] [stdout] | [INFO] [stdout] 935 | let mut ty = Type::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1006 | Ok(Some(ty)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/dwarf.rs:3163:8 [INFO] [stdout] | [INFO] [stdout] 3079 | namespace: Option>>, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3087 | let mut variable = Variable { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3163 | Ok(DwarfVariable { [INFO] [stdout] | ________^ [INFO] [stdout] 3164 | | offset, [INFO] [stdout] 3165 | | specification, [INFO] [stdout] 3166 | | variable, [INFO] [stdout] 3167 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/dwarf.rs:3984:26 [INFO] [stdout] | [INFO] [stdout] 3979 | debug_frame: gimli::DebugFrame, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 3980 | eh_frame: gimli::EhFrame, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3984 | debug_frame: DebugFrameTable::new(debug_frame), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/dwarf.rs:3985:23 [INFO] [stdout] | [INFO] [stdout] 3979 | debug_frame: gimli::DebugFrame, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 3980 | eh_frame: gimli::EhFrame, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3985 | eh_frame: EhFrameTable::new(eh_frame, bases), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:139:25 [INFO] [stdout] | [INFO] [stdout] 139 | .or_else(|| hash.file.get_type(offset).map(Cow::Owned)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ddbug_parser` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "4b812660f5e764a4bbd8b79e7566180c047d791855c20faddd00cb82765d3f48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b812660f5e764a4bbd8b79e7566180c047d791855c20faddd00cb82765d3f48", kill_on_drop: false }` [INFO] [stdout] 4b812660f5e764a4bbd8b79e7566180c047d791855c20faddd00cb82765d3f48