[INFO] fetching crate dd-lib 0.2.1... [INFO] checking dd-lib-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dd-lib 0.2.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate dd-lib 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dd-lib 0.2.1 [INFO] finished tweaking crates.io crate dd-lib 0.2.1 [INFO] tweaked toml for crates.io crate dd-lib 0.2.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 23 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 70910c00e2c5f34df7737c560bea2a839b7136c0ec5b4b12e23a2992c8a8ec4f [INFO] running `Command { std: "docker" "start" "-a" "70910c00e2c5f34df7737c560bea2a839b7136c0ec5b4b12e23a2992c8a8ec4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "70910c00e2c5f34df7737c560bea2a839b7136c0ec5b4b12e23a2992c8a8ec4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70910c00e2c5f34df7737c560bea2a839b7136c0ec5b4b12e23a2992c8a8ec4f", kill_on_drop: false }` [INFO] [stdout] 70910c00e2c5f34df7737c560bea2a839b7136c0ec5b4b12e23a2992c8a8ec4f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aeebbc818888efe03bb0b6f380e7ea3f4d9652e1335b7e9f0a080fc388ab855e [INFO] running `Command { std: "docker" "start" "-a" "aeebbc818888efe03bb0b6f380e7ea3f4d9652e1335b7e9f0a080fc388ab855e", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking encoding8 v0.3.2 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking dd-lib v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary braces around assigned value [INFO] [stdout] --> src/opts/flags/iflag.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 71 | flags |= { Self::from_str(flag)? }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 71 - flags |= { Self::from_str(flag)? }; [INFO] [stdout] 71 + flags |= Self::from_str(flag)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/io/tests.rs:17:56 [INFO] [stdout] | [INFO] [stdout] 17 | fn write(&mut self, buf: &[u8]) -> std::io::Result<(usize)> { Ok(buf.len()) } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 17 - fn write(&mut self, buf: &[u8]) -> std::io::Result<(usize)> { Ok(buf.len()) } [INFO] [stdout] 17 + fn write(&mut self, buf: &[u8]) -> std::io::Result { Ok(buf.len()) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around assigned value [INFO] [stdout] --> src/opts/flags/iflag.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 71 | flags |= { Self::from_str(flag)? }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 71 - flags |= { Self::from_str(flag)? }; [INFO] [stdout] 71 + flags |= Self::from_str(flag)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/errhandler.rs:46:15 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn handle(&mut self, res: Result) -> Result> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | match (res, self.continue_on_err) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/io/errhandler.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | writeln!(self.e, "io error: <{}>; continuing", err); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this warning originates in the macro `writeln` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/io/errhandler.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | / writeln!( [INFO] [stdout] 73 | | self, [INFO] [stdout] 74 | | "dd in progress: unblock: elapsed: {}, wrote {} lines", [INFO] [stdout] 75 | | elapsed(&start), [INFO] [stdout] 76 | | lines [INFO] [stdout] 77 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `writeln` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/io/errhandler.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | / writeln!( [INFO] [stdout] 84 | | self, [INFO] [stdout] 85 | | "dd in progress: unblock: elapsed: {}, wrote {} fixed-length blocks", [INFO] [stdout] 86 | | elapsed(&start), [INFO] [stdout] 87 | | blocks [INFO] [stdout] 88 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `writeln` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dd-lib` (lib) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/errhandler.rs:46:15 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn handle(&mut self, res: Result) -> Result> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | match (res, self.continue_on_err) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/io/errhandler.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | writeln!(self.e, "io error: <{}>; continuing", err); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this warning originates in the macro `writeln` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/io/errhandler.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | / writeln!( [INFO] [stdout] 73 | | self, [INFO] [stdout] 74 | | "dd in progress: unblock: elapsed: {}, wrote {} lines", [INFO] [stdout] 75 | | elapsed(&start), [INFO] [stdout] 76 | | lines [INFO] [stdout] 77 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `writeln` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/io/errhandler.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | / writeln!( [INFO] [stdout] 84 | | self, [INFO] [stdout] 85 | | "dd in progress: unblock: elapsed: {}, wrote {} fixed-length blocks", [INFO] [stdout] 86 | | elapsed(&start), [INFO] [stdout] 87 | | blocks [INFO] [stdout] 88 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `writeln` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/tests.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 42 | fn reader>(it: I, block_size: usize) -> Reader<'static, Cursor>> { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Reader::basic(InnerReader::R(Cursor::new(v)), block_size) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dd-lib` (lib test) due to 3 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "aeebbc818888efe03bb0b6f380e7ea3f4d9652e1335b7e9f0a080fc388ab855e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aeebbc818888efe03bb0b6f380e7ea3f4d9652e1335b7e9f0a080fc388ab855e", kill_on_drop: false }` [INFO] [stdout] aeebbc818888efe03bb0b6f380e7ea3f4d9652e1335b7e9f0a080fc388ab855e