[INFO] fetching crate dce-router 1.0.0... [INFO] checking dce-router-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dce-router 1.0.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate dce-router 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dce-router 1.0.0 [INFO] finished tweaking crates.io crate dce-router 1.0.0 [INFO] tweaked toml for crates.io crate dce-router 1.0.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a05f3ef10304bc29ca1ff3d513d4e4d7c4c7966e6fe650d49bca81a00d954523 [INFO] running `Command { std: "docker" "start" "-a" "a05f3ef10304bc29ca1ff3d513d4e4d7c4c7966e6fe650d49bca81a00d954523", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a05f3ef10304bc29ca1ff3d513d4e4d7c4c7966e6fe650d49bca81a00d954523", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a05f3ef10304bc29ca1ff3d513d4e4d7c4c7966e6fe650d49bca81a00d954523", kill_on_drop: false }` [INFO] [stdout] a05f3ef10304bc29ca1ff3d513d4e4d7c4c7966e6fe650d49bca81a00d954523 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 476544ce8e7321f96e2451228a4124f747b308d6428da3d1817843ec33ee89bc [INFO] running `Command { std: "docker" "start" "-a" "476544ce8e7321f96e2451228a4124f747b308d6428da3d1817843ec33ee89bc", kill_on_drop: false }` [INFO] [stderr] Checking dce-util v1.0.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking dce-router v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:26:42 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(router: Arc>, rp: Rp, data: HashMap>) -> Context { [INFO] [stdout] | ----------------------- ------ ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Context { router, api: None, rp: Some(rp), path_params: Default::default(), suffix: None, data, } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:165:69 [INFO] [stdout] | [INFO] [stdout] 163 | pub fn status>(self, status: bool, data: Option, message: Option, code: isize) -> DceResult(context, api.serializers(), Serializable::Status(ResponseStatus { [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 166 | | status, [INFO] [stdout] 167 | | code, [INFO] [stdout] 168 | | message: message.unwrap_or("".to_string()), [INFO] [stdout] 169 | | data: data.map(|resp| resp.into()), [INFO] [stdout] 170 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:183:58 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn resp>(self, resp: Resp) -> DceResult>> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let Self{context, api} = self; [INFO] [stdout] 183 | Rp::pack_responsible(context, api.serializers(), Serializable::Dto(resp.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:196:12 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn pack(self, serialized: Serialized) -> DceResult>> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | Ok(Some(Response::Serialized(serialized))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 199 | pub fn raw_resp(self, resp: Rp::Resp) -> DceResult>> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | Ok(Some(Response::Raw(resp))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:195:22 [INFO] [stdout] | [INFO] [stdout] 193 | pub fn ready(mut self) -> DceResult<&'static Arc>> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | self.closing()?; [INFO] [stdout] 195 | Ok(Box::leak(Box::new(Arc::new(self)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 231 | let mut loop_items = vec![(self.apis_tree.clone(), 0_usize)]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | let mut target_api_branch = None; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | target_api_branch?.read().map(|branch| (branch.path, path_args, suffix)).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:317:40 [INFO] [stdout] | [INFO] [stdout] 317 | .map(|suffix| (matches.clone(), &**suffix)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:323:36 [INFO] [stdout] | [INFO] [stdout] 323 | return matches.map(|tree| (tree.clone(), "")); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializer.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 70 | fn deserialize<'a>(&self, value: Serialized) -> DceResult { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok(Dto::from(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializer.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 76 | fn serialize(&self, value: Serializable) -> DceResult { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Ok(match value { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | Serializable::Dto(v) => v.into(), [INFO] [stdout] 79 | | Serializable::Status(s) => Serialized::String((if s.status { "succeeded" } else { "failed" }).to_string()) [INFO] [stdout] 80 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializer.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 97 | fn deserialize<'a>(&self, value: Serialized) -> DceResult { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | Ok((match value { [INFO] [stdout] | ____________^ [INFO] [stdout] 99 | | Serialized::String(v) => serde_json::from_str(v.as_str()), [INFO] [stdout] 100 | | Serialized::Bytes(v) => serde_json::from_slice(v.as_ref()), [INFO] [stdout] 101 | | }).or(DceErr::closed0_wrap("Serialized cannot deserialize to ReqDto"))?) [INFO] [stdout] | |_______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializer.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 106 | fn serialize(&self, value: Serializable) -> DceResult { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | Ok(Serialized::String(match value { [INFO] [stdout] | ____________^ [INFO] [stdout] 108 | | Serializable::Dto(v) => serde_json::to_string::(&v), [INFO] [stdout] 109 | | Serializable::Status(v) => serde_json::to_string::>(&v), [INFO] [stdout] 110 | | }.or(DceErr::closed0_wrap("RespDto not a jsonable"))?)) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(req: Req, heads: HashMap) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Self { req: Some(req), resp: None, heads, resp_heads: Default::default() } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:32:38 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(req: Req, heads: HashMap) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Self { req: Some(req), resp: None, heads, resp_heads: Default::default() } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:81:128 [INFO] [stdout] | [INFO] [stdout] 81 | async fn handle(self, router: Arc>, context_data: HashMap>) -> Option { [INFO] [stdout] | _____________________----__-------------------------__--------------------------------------------------________________________^ [INFO] [stdout] | | | | | [INFO] [stdout] | | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | | let mut context = Context::new(router, self, context_data); [INFO] [stdout] 83 | | let result = Router::route(&mut context).await; [INFO] [stdout] 84 | | context.take_rp()?.handle_result(result, &mut context) [INFO] [stdout] 85 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 118 | responsible: Serializable, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | ) -> DceResult>> { [INFO] [stdout] 120 | Self::serialize(serializers, responsible, &context).map(|sd| Some(Response::Serialized(sd))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:120:75 [INFO] [stdout] | [INFO] [stdout] 120 | Self::serialize(serializers, responsible, &context).map(|sd| Some(Response::Serialized(sd))) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:127:10 [INFO] [stdout] | [INFO] [stdout] 125 | fn parse_api_method_and_extras(prop_tuples: Vec<(&'static str, Box)>) -> (Option + Send +... [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let mut prop_mapping: HashMap<_, _> = prop_tuples.into_iter().collect(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | (Self::parse_api_method(&mut prop_mapping), prop_mapping) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dce-router` (lib test) due to 20 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:26:42 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(router: Arc>, rp: Rp, data: HashMap>) -> Context { [INFO] [stdout] | ----------------------- ------ ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Context { router, api: None, rp: Some(rp), path_params: Default::default(), suffix: None, data, } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:165:69 [INFO] [stdout] | [INFO] [stdout] 163 | pub fn status>(self, status: bool, data: Option, message: Option, code: isize) -> DceResult(context, api.serializers(), Serializable::Status(ResponseStatus { [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 166 | | status, [INFO] [stdout] 167 | | code, [INFO] [stdout] 168 | | message: message.unwrap_or("".to_string()), [INFO] [stdout] 169 | | data: data.map(|resp| resp.into()), [INFO] [stdout] 170 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:183:58 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn resp>(self, resp: Resp) -> DceResult>> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let Self{context, api} = self; [INFO] [stdout] 183 | Rp::pack_responsible(context, api.serializers(), Serializable::Dto(resp.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:196:12 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn pack(self, serialized: Serialized) -> DceResult>> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | Ok(Some(Response::Serialized(serialized))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 199 | pub fn raw_resp(self, resp: Rp::Resp) -> DceResult>> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | Ok(Some(Response::Raw(resp))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:195:22 [INFO] [stdout] | [INFO] [stdout] 193 | pub fn ready(mut self) -> DceResult<&'static Arc>> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | self.closing()?; [INFO] [stdout] 195 | Ok(Box::leak(Box::new(Arc::new(self)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 231 | let mut loop_items = vec![(self.apis_tree.clone(), 0_usize)]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | let mut target_api_branch = None; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | target_api_branch?.read().map(|branch| (branch.path, path_args, suffix)).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:317:40 [INFO] [stdout] | [INFO] [stdout] 317 | .map(|suffix| (matches.clone(), &**suffix)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:323:36 [INFO] [stdout] | [INFO] [stdout] 323 | return matches.map(|tree| (tree.clone(), "")); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializer.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 70 | fn deserialize<'a>(&self, value: Serialized) -> DceResult { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok(Dto::from(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializer.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 76 | fn serialize(&self, value: Serializable) -> DceResult { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Ok(match value { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | Serializable::Dto(v) => v.into(), [INFO] [stdout] 79 | | Serializable::Status(s) => Serialized::String((if s.status { "succeeded" } else { "failed" }).to_string()) [INFO] [stdout] 80 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializer.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 97 | fn deserialize<'a>(&self, value: Serialized) -> DceResult { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | Ok((match value { [INFO] [stdout] | ____________^ [INFO] [stdout] 99 | | Serialized::String(v) => serde_json::from_str(v.as_str()), [INFO] [stdout] 100 | | Serialized::Bytes(v) => serde_json::from_slice(v.as_ref()), [INFO] [stdout] 101 | | }).or(DceErr::closed0_wrap("Serialized cannot deserialize to ReqDto"))?) [INFO] [stdout] | |_______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializer.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 106 | fn serialize(&self, value: Serializable) -> DceResult { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | Ok(Serialized::String(match value { [INFO] [stdout] | ____________^ [INFO] [stdout] 108 | | Serializable::Dto(v) => serde_json::to_string::(&v), [INFO] [stdout] 109 | | Serializable::Status(v) => serde_json::to_string::>(&v), [INFO] [stdout] 110 | | }.or(DceErr::closed0_wrap("RespDto not a jsonable"))?)) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(req: Req, heads: HashMap) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Self { req: Some(req), resp: None, heads, resp_heads: Default::default() } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:32:38 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(req: Req, heads: HashMap) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Self { req: Some(req), resp: None, heads, resp_heads: Default::default() } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:81:128 [INFO] [stdout] | [INFO] [stdout] 81 | async fn handle(self, router: Arc>, context_data: HashMap>) -> Option { [INFO] [stdout] | _____________________----__-------------------------__--------------------------------------------------________________________^ [INFO] [stdout] | | | | | [INFO] [stdout] | | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | | let mut context = Context::new(router, self, context_data); [INFO] [stdout] 83 | | let result = Router::route(&mut context).await; [INFO] [stdout] 84 | | context.take_rp()?.handle_result(result, &mut context) [INFO] [stdout] 85 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 118 | responsible: Serializable, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | ) -> DceResult>> { [INFO] [stdout] 120 | Self::serialize(serializers, responsible, &context).map(|sd| Some(Response::Serialized(sd))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:120:75 [INFO] [stdout] | [INFO] [stdout] 120 | Self::serialize(serializers, responsible, &context).map(|sd| Some(Response::Serialized(sd))) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:127:10 [INFO] [stdout] | [INFO] [stdout] 125 | fn parse_api_method_and_extras(prop_tuples: Vec<(&'static str, Box)>) -> (Option + Send +... [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let mut prop_mapping: HashMap<_, _> = prop_tuples.into_iter().collect(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | (Self::parse_api_method(&mut prop_mapping), prop_mapping) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dce-router` (lib) due to 20 previous errors [INFO] running `Command { std: "docker" "inspect" "476544ce8e7321f96e2451228a4124f747b308d6428da3d1817843ec33ee89bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "476544ce8e7321f96e2451228a4124f747b308d6428da3d1817843ec33ee89bc", kill_on_drop: false }` [INFO] [stdout] 476544ce8e7321f96e2451228a4124f747b308d6428da3d1817843ec33ee89bc