[INFO] fetching crate dcc-tiler 0.1.2... [INFO] checking dcc-tiler-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dcc-tiler 0.1.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate dcc-tiler 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dcc-tiler 0.1.2 [INFO] finished tweaking crates.io crate dcc-tiler 0.1.2 [INFO] tweaked toml for crates.io crate dcc-tiler 0.1.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate dcc-tiler 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d3657d6642d5efd2e5c9cf1acc2b0bc44a572c0cbc3ca691fb91834ba0e81dd0 [INFO] running `Command { std: "docker" "start" "-a" "d3657d6642d5efd2e5c9cf1acc2b0bc44a572c0cbc3ca691fb91834ba0e81dd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d3657d6642d5efd2e5c9cf1acc2b0bc44a572c0cbc3ca691fb91834ba0e81dd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3657d6642d5efd2e5c9cf1acc2b0bc44a572c0cbc3ca691fb91834ba0e81dd0", kill_on_drop: false }` [INFO] [stdout] d3657d6642d5efd2e5c9cf1acc2b0bc44a572c0cbc3ca691fb91834ba0e81dd0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e6c0b774474e621400af481e06a3f8c1396d8c799d8d9c5e40f4d6783e04c71 [INFO] running `Command { std: "docker" "start" "-a" "5e6c0b774474e621400af481e06a3f8c1396d8c799d8d9c5e40f4d6783e04c71", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling cc v1.0.46 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Compiling rayon-core v1.6.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling syn v1.0.7 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Checking miniz_oxide v0.3.5 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling num-bigint v0.2.3 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Compiling num-rational v0.2.2 [INFO] [stderr] Compiling num-complex v0.2.3 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking podio v0.1.6 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking num_cpus v1.11.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking flate2 v1.0.12 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking simplesvg v0.4.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling memoffset v0.5.2 [INFO] [stderr] Compiling bzip2-sys v0.1.7 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking zip v0.5.3 [INFO] [stderr] Checking rayon v1.2.0 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Checking serde_json v1.0.41 [INFO] [stderr] Checking dcc-tiler v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/render.rs:77:14 [INFO] [stdout] | [INFO] [stdout] 77 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/render.rs:77:14 [INFO] [stdout] | [INFO] [stdout] 77 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `position`, `tile`, and `start_index` are never read [INFO] [stdout] --> src/board.rs:330:5 [INFO] [stdout] | [INFO] [stdout] 329 | struct TilePosition { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 330 | position: Position, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 331 | tile: Tile, [INFO] [stdout] | ^^^^ [INFO] [stdout] 332 | start_index: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TilePosition` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 157 | let mut fitting_tiles = Vec::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | / fitting_tiles [INFO] [stdout] 177 | | .into_iter() [INFO] [stdout] 178 | | .map(|tp| { [INFO] [stdout] 179 | | let mut child_board = self.clone(); [INFO] [stdout] 180 | | child_board.mark_tile_at_position(tp); [INFO] [stdout] 181 | | child_board [INFO] [stdout] 182 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `position`, `tile`, and `start_index` are never read [INFO] [stdout] --> src/board.rs:330:5 [INFO] [stdout] | [INFO] [stdout] 329 | struct TilePosition { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 330 | position: Position, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 331 | tile: Tile, [INFO] [stdout] | ^^^^ [INFO] [stdout] 332 | start_index: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TilePosition` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:274:14 [INFO] [stdout] | [INFO] [stdout] 247 | let mut covered = HashSet::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | Some(TilePosition::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 275 | | position, [INFO] [stdout] 276 | | tile.clone(), [INFO] [stdout] 277 | | start_index, [INFO] [stdout] 278 | | covered, [INFO] [stdout] 279 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 157 | let mut fitting_tiles = Vec::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | / fitting_tiles [INFO] [stdout] 177 | | .into_iter() [INFO] [stdout] 178 | | .map(|tp| { [INFO] [stdout] 179 | | let mut child_board = self.clone(); [INFO] [stdout] 180 | | child_board.mark_tile_at_position(tp); [INFO] [stdout] 181 | | child_board [INFO] [stdout] 182 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:148:5 [INFO] [stdout] | [INFO] [stdout] 36 | let mut boxes = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | / Svg( [INFO] [stdout] 149 | | vec![Fig::Multiple(boxes)], [INFO] [stdout] 150 | | (50 * board.width) as u32 + 2 * (padding as u32), [INFO] [stdout] 151 | | (50 * board.height) as u32 + 2 * (padding as u32), [INFO] [stdout] 152 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:274:14 [INFO] [stdout] | [INFO] [stdout] 247 | let mut covered = HashSet::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | Some(TilePosition::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 275 | | position, [INFO] [stdout] 276 | | tile.clone(), [INFO] [stdout] 277 | | start_index, [INFO] [stdout] 278 | | covered, [INFO] [stdout] 279 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tile.rs:224:33 [INFO] [stdout] | [INFO] [stdout] 197 | let mut orbit = HashSet::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | TileCollection::new(orbit.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:148:5 [INFO] [stdout] | [INFO] [stdout] 36 | let mut boxes = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | / Svg( [INFO] [stdout] 149 | | vec![Fig::Multiple(boxes)], [INFO] [stdout] 150 | | (50 * board.width) as u32 + 2 * (padding as u32), [INFO] [stdout] 151 | | (50 * board.height) as u32 + 2 * (padding as u32), [INFO] [stdout] 152 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tile.rs:224:33 [INFO] [stdout] | [INFO] [stdout] 197 | let mut orbit = HashSet::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | TileCollection::new(orbit.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dcc-tiler` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `dcc-tiler` (lib) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5e6c0b774474e621400af481e06a3f8c1396d8c799d8d9c5e40f4d6783e04c71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e6c0b774474e621400af481e06a3f8c1396d8c799d8d9c5e40f4d6783e04c71", kill_on_drop: false }` [INFO] [stdout] 5e6c0b774474e621400af481e06a3f8c1396d8c799d8d9c5e40f4d6783e04c71