[INFO] fetching crate dbz-lib 0.2.2... [INFO] checking dbz-lib-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dbz-lib 0.2.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate dbz-lib 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dbz-lib 0.2.2 [INFO] finished tweaking crates.io crate dbz-lib 0.2.2 [INFO] tweaked toml for crates.io crate dbz-lib 0.2.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 69 packages to latest compatible versions [INFO] [stderr] Adding databento-defs v0.3.1 (latest: v0.4.2) [INFO] [stderr] Adding indoc v1.0.9 (latest: v2.0.5) [INFO] [stderr] Adding memoffset v0.6.5 (latest: v0.9.1) [INFO] [stderr] Adding num_enum v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding num_enum_derive v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding pyo3 v0.17.3 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-build-config v0.17.3 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-ffi v0.17.3 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-macros v0.17.3 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-macros-backend v0.17.3 (latest: v0.22.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding unindent v0.1.11 (latest: v0.2.3) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] [stderr] Adding zstd v0.11.2+zstd.1.5.2 (latest: v0.13.2) [INFO] [stderr] Adding zstd-safe v5.0.2+zstd.1.5.2 (latest: v7.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: version requirement `= 0.11.2+zstd1.5.2` for dependency `zstd` includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9d629de4d669588dd36e71d77cf88dcdd79ece2d022538ac96f3211447adc5a6 [INFO] running `Command { std: "docker" "start" "-a" "9d629de4d669588dd36e71d77cf88dcdd79ece2d022538ac96f3211447adc5a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9d629de4d669588dd36e71d77cf88dcdd79ece2d022538ac96f3211447adc5a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d629de4d669588dd36e71d77cf88dcdd79ece2d022538ac96f3211447adc5a6", kill_on_drop: false }` [INFO] [stdout] 9d629de4d669588dd36e71d77cf88dcdd79ece2d022538ac96f3211447adc5a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 37bb9c1cf422b909516d797621b3190ce0f2abca739faa9847abfdda75d3441d [INFO] running `Command { std: "docker" "start" "-a" "37bb9c1cf422b909516d797621b3190ce0f2abca739faa9847abfdda75d3441d", kill_on_drop: false }` [INFO] [stderr] warning: version requirement `= 0.11.2+zstd1.5.2` for dependency `zstd` includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking streaming-iterator v0.1.9 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling num_enum_derive v0.5.11 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking num_enum v0.5.11 [INFO] [stderr] Checking databento-defs v0.3.1 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Checking dbz-lib v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn new(mut reader: R) -> anyhow::Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let metadata = Metadata::read(&mut reader)?; [INFO] [stdout] 124 | Ok(Self { reader, metadata }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 167 | pub(crate) fn new(reader: R, metadata: Metadata) -> anyhow::Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let decoder = Decoder::with_buffer(reader)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | Ok(DbzStreamIter { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | metadata, [INFO] [stdout] 171 | | decoder, [INFO] [stdout] 172 | | i: 0, [INFO] [stdout] 173 | | buffer: vec![0; mem::size_of::()], [INFO] [stdout] 174 | | _item: PhantomData {}, [INFO] [stdout] 175 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write/dbz.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 18 | fn new_encoder<'a, W: io::Write>(writer: W) -> anyhow::Result> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | let mut encoder = Encoder::new(writer, ZSTD_COMPRESSION_LEVEL)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | encoder.include_checksum(true)?; [INFO] [stdout] 23 | Ok(encoder.auto_finish()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dbz-lib` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn new(mut reader: R) -> anyhow::Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let metadata = Metadata::read(&mut reader)?; [INFO] [stdout] 124 | Ok(Self { reader, metadata }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 167 | pub(crate) fn new(reader: R, metadata: Metadata) -> anyhow::Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let decoder = Decoder::with_buffer(reader)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | Ok(DbzStreamIter { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | metadata, [INFO] [stdout] 171 | | decoder, [INFO] [stdout] 172 | | i: 0, [INFO] [stdout] 173 | | buffer: vec![0; mem::size_of::()], [INFO] [stdout] 174 | | _item: PhantomData {}, [INFO] [stdout] 175 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write/dbz.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 18 | fn new_encoder<'a, W: io::Write>(writer: W) -> anyhow::Result> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | let mut encoder = Encoder::new(writer, ZSTD_COMPRESSION_LEVEL)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | encoder.include_checksum(true)?; [INFO] [stdout] 23 | Ok(encoder.auto_finish()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dbz-lib` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "37bb9c1cf422b909516d797621b3190ce0f2abca739faa9847abfdda75d3441d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37bb9c1cf422b909516d797621b3190ce0f2abca739faa9847abfdda75d3441d", kill_on_drop: false }` [INFO] [stdout] 37bb9c1cf422b909516d797621b3190ce0f2abca739faa9847abfdda75d3441d