[INFO] fetching crate db-dump 0.7.4... [INFO] checking db-dump-0.7.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate db-dump 0.7.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate db-dump 0.7.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate db-dump 0.7.4 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate db-dump 0.7.4 [INFO] tweaked toml for crates.io crate db-dump 0.7.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate db-dump 0.7.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b19ae53caeb651979ce5a4847cd724be2a3e560c5ebc4cf901287e3d0835e5f [INFO] running `Command { std: "docker" "start" "-a" "0b19ae53caeb651979ce5a4847cd724be2a3e560c5ebc4cf901287e3d0835e5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b19ae53caeb651979ce5a4847cd724be2a3e560c5ebc4cf901287e3d0835e5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b19ae53caeb651979ce5a4847cd724be2a3e560c5ebc4cf901287e3d0835e5f", kill_on_drop: false }` [INFO] [stdout] 0b19ae53caeb651979ce5a4847cd724be2a3e560c5ebc4cf901287e3d0835e5f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ffabece7b7db868479a51837f459f62817f36a746fcb508f27e39f7f24b5ba4f [INFO] running `Command { std: "docker" "start" "-a" "ffabece7b7db868479a51837f459f62817f36a746fcb508f27e39f7f24b5ba4f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Checking semver v1.0.23 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Checking db-dump v0.7.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn err(variant: impl Into) -> Error { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Error { [INFO] [stdout] 59 | e: Box::new(ErrorImpl { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | path: None, [INFO] [stdout] 61 | | kind: variant.into(), [INFO] [stdout] 62 | | }), [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 79 | fn from(e: io::Error) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Error { [INFO] [stdout] 81 | e: Box::new(ErrorImpl { [INFO] [stdout] | ________________^ [INFO] [stdout] 82 | | path: None, [INFO] [stdout] 83 | | kind: ErrorKind::Io(e), [INFO] [stdout] 84 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/load.rs:174:16 [INFO] [stdout] | [INFO] [stdout] 172 | fn new(f: impl FnMut(T) + 'a) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | Callback { [INFO] [stdout] 174 | f: Box::new(f), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/load.rs:433:8 [INFO] [stdout] | [INFO] [stdout] 403 | let mut dependencies = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 410 | let mut versions = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 411 | [INFO] [stdout] 412 | let mut loader = Loader { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 433 | Ok(DbDump { [INFO] [stdout] | ________^ [INFO] [stdout] 434 | | categories, [INFO] [stdout] 435 | | crate_downloads, [INFO] [stdout] 436 | | crate_owners, [INFO] [stdout] ... | [INFO] [stdout] 448 | | versions, [INFO] [stdout] 449 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn err(variant: impl Into) -> Error { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Error { [INFO] [stdout] 59 | e: Box::new(ErrorImpl { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | path: None, [INFO] [stdout] 61 | | kind: variant.into(), [INFO] [stdout] 62 | | }), [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 79 | fn from(e: io::Error) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Error { [INFO] [stdout] 81 | e: Box::new(ErrorImpl { [INFO] [stdout] | ________________^ [INFO] [stdout] 82 | | path: None, [INFO] [stdout] 83 | | kind: ErrorKind::Io(e), [INFO] [stdout] 84 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/load.rs:174:16 [INFO] [stdout] | [INFO] [stdout] 172 | fn new(f: impl FnMut(T) + 'a) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | Callback { [INFO] [stdout] 174 | f: Box::new(f), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/load.rs:433:8 [INFO] [stdout] | [INFO] [stdout] 403 | let mut dependencies = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 410 | let mut versions = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 411 | [INFO] [stdout] 412 | let mut loader = Loader { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 433 | Ok(DbDump { [INFO] [stdout] | ________^ [INFO] [stdout] 434 | | categories, [INFO] [stdout] 435 | | crate_downloads, [INFO] [stdout] 436 | | crate_owners, [INFO] [stdout] ... | [INFO] [stdout] 448 | | versions, [INFO] [stdout] 449 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `db-dump` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `db-dump` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "ffabece7b7db868479a51837f459f62817f36a746fcb508f27e39f7f24b5ba4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ffabece7b7db868479a51837f459f62817f36a746fcb508f27e39f7f24b5ba4f", kill_on_drop: false }` [INFO] [stdout] ffabece7b7db868479a51837f459f62817f36a746fcb508f27e39f7f24b5ba4f