[INFO] fetching crate db-core 0.2.1... [INFO] checking db-core-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate db-core 0.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate db-core 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate db-core 0.2.1 [INFO] finished tweaking crates.io crate db-core 0.2.1 [INFO] tweaked toml for crates.io crate db-core 0.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 21 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 63dfd0864b6f0f142715668769296d3294bd1ba95af4bdb35b8768f24f7654e8 [INFO] running `Command { std: "docker" "start" "-a" "63dfd0864b6f0f142715668769296d3294bd1ba95af4bdb35b8768f24f7654e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "63dfd0864b6f0f142715668769296d3294bd1ba95af4bdb35b8768f24f7654e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63dfd0864b6f0f142715668769296d3294bd1ba95af4bdb35b8768f24f7654e8", kill_on_drop: false }` [INFO] [stdout] 63dfd0864b6f0f142715668769296d3294bd1ba95af4bdb35b8768f24f7654e8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 43d7e4263c44a5d9ed38ad37e0d999171623727d3cf74210d05c3b2b21f0d338 [INFO] running `Command { std: "docker" "start" "-a" "43d7e4263c44a5d9ed38ad37e0d999171623727d3cf74210d05c3b2b21f0d338", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking db-core v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::log_mgr::io::LogRecordHeader` [INFO] [stdout] --> src/log_mgr/log_mgr.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub use crate::log_mgr::io::LogRecordHeader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:248:7 [INFO] [stdout] | [INFO] [stdout] 248 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:259:11 [INFO] [stdout] | [INFO] [stdout] 259 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:417:11 [INFO] [stdout] | [INFO] [stdout] 417 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:425:11 [INFO] [stdout] | [INFO] [stdout] 425 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:276:15 [INFO] [stdout] | [INFO] [stdout] 276 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:284:19 [INFO] [stdout] | [INFO] [stdout] 284 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:346:27 [INFO] [stdout] | [INFO] [stdout] 346 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:356:27 [INFO] [stdout] | [INFO] [stdout] 356 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:404:19 [INFO] [stdout] | [INFO] [stdout] 404 | #[cfg(feature = "metrics")] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:410:23 [INFO] [stdout] | [INFO] [stdout] 410 | #[cfg(not(feature = "metrics"))] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `metrics` [INFO] [stdout] --> src/log_mgr/buf.rs:579:19 [INFO] [stdout] | [INFO] [stdout] 579 | #[cfg(feature = "metrics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `metrics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::alloc::LayoutErr`: Name does not follow std convention, use LayoutError [INFO] [stdout] --> src/common/errors.rs:219:17 [INFO] [stdout] | [INFO] [stdout] 219 | std::alloc::LayoutErr, IncorrectLayout, layout_err, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::alloc::LayoutErr`: Name does not follow std convention, use LayoutError [INFO] [stdout] --> src/common/errors.rs:209:79 [INFO] [stdout] | [INFO] [stdout] 209 | IncorrectLayout , incorrect_layout , std::alloc::LayoutErr, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/common/intercom.rs:202:33 [INFO] [stdout] | [INFO] [stdout] 202 | core::sync::atomic::spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/log_mgr/buf.rs:112:52 [INFO] [stdout] | [INFO] [stdout] 112 | let cur_acq_size = self.acquire_size.0.compare_and_swap( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/log_mgr/buf.rs:182:52 [INFO] [stdout] | [INFO] [stdout] 182 | let cur_acq_size = self.acquire_size.0.compare_and_swap( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/storage/datastore.rs:445:29 [INFO] [stdout] | [INFO] [stdout] 445 | fn add_fi_blocks(&self, mut block_id: &mut BlockId, fi_block_num: usize, stub_pin: &AtomicU64, f: &std::fs::File) -> Result<(), Error> { [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/storage/datastore.rs:863:13 [INFO] [stdout] | [INFO] [stdout] 863 | let mut desc = xlock.get_mut(&file_id).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/storage/datastore.rs:869:13 [INFO] [stdout] | [INFO] [stdout] 869 | let mut desc = xlock.get_mut(&file_id).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/storage/block_driver.rs:731:26 [INFO] [stdout] | [INFO] [stdout] 731 | pub fn replay(&self, mut rs: &mut ReplayState, data: &[u8]) -> Result<(), Error> { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `write_ready` is never read [INFO] [stdout] --> src/buf_mgr/buf_writer.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct BufWriter { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 32 | write_ready: SyncNotification, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BufWriter` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Metrics` is never constructed [INFO] [stdout] --> src/log_mgr/buf.rs:243:12 [INFO] [stdout] | [INFO] [stdout] 243 | pub struct Metrics { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Metrics` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_extent_bit` is never used [INFO] [stdout] --> src/block_mgr/free_info.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 36 | impl FreeInfo { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 121 | pub fn set_extent_bit(&self, file_id: u16, extent_id: u16, set: bool) -> Result<(), Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `used_iter` is never used [INFO] [stdout] --> src/block_mgr/free_info.rs:321:12 [INFO] [stdout] | [INFO] [stdout] 305 | impl FiData { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 321 | pub fn used_iter(&self) -> FiDataIter { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/block_mgr/block.rs:25:10 [INFO] [stdout] | [INFO] [stdout] 25 | Read(RwLockReadGuard<'a, ()>), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 25 | Read(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/block_mgr/block.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 26 | Write(RwLockWriteGuard<'a, ()>), [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 26 | Write(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_crc` is never used [INFO] [stdout] --> src/block_mgr/block.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 86 | pub trait BasicBlock { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 87 | [INFO] [stdout] 88 | fn get_crc(&self) -> u32; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `delete_entry` is never used [INFO] [stdout] --> src/block_mgr/block.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 131 | impl<'a> DataBlock<'a> { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 276 | pub fn delete_entry(&mut self, entry_id: u16) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `mark_extent_full` and `set_free_info_free` are never used [INFO] [stdout] --> src/block_mgr/allocator.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 37 | impl BlockAllocator { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 93 | pub fn mark_extent_full(&self, file_id: u16, extent_id: u16) -> Result<(), Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 127 | pub fn set_free_info_free(&self, block_id: &BlockId) -> Result<(), Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buf_mgr/buf_mgr.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 157 | let block_map = RwLock::new(HashMap::with_capacity(block_num * 2)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | [INFO] [stdout] 159 | let mut eviction_mech = E::new((0, BlockId::new())); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Ok(BufMgr:: { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | mem, [INFO] [stdout] 171 | | block_desc: Arc::new(block_desc), [INFO] [stdout] 172 | | block_map: Arc::new(block_map), [INFO] [stdout] ... | [INFO] [stdout] 176 | | block_num, [INFO] [stdout] 177 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buf_mgr/buf_mgr.rs:325:10 [INFO] [stdout] | [INFO] [stdout] 303 | fn put_on_map(&self, mut block_map: RwLockWriteGuard>, val: I, block_type: BlockType) -> (Pinned, u... [INFO] [stdout] | ---------------------------------------------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | let mut bdesc = self.block_desc[id].write_lock(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 325 | (Pinned::new(self.get_block_area(id), &self.pins[id]), id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buf_mgr/buf_writer.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 41 | let terminate = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let mut writer_threads = Vec::with_capacity(writer_num); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let write_ready = SyncNotification::new(0); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let chkpnt_allocators = CheckpointStoreBlockAllocators::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let writer_threads = Arc::new(writer_threads); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let wr = write_ready.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let wt = writer_threads.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let tm = terminate.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let waker = Arc::new(std::thread::spawn(move || { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(BufWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | writer_threads, [INFO] [stdout] 72 | | terminate, [INFO] [stdout] 73 | | write_ready, [INFO] [stdout] 74 | | chkpnt_allocators, [INFO] [stdout] 75 | | waker, [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buf_mgr/buf_writer.rs:304:13 [INFO] [stdout] | [INFO] [stdout] 255 | let sl = self.lock.read().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | Err(Error::checkpoint_store_size_limit_reached()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/errors.rs:77:60 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn $create_fun(e: $fun_arg) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Self::new(ErrorKind::$kind, ErrorRepr::$kind(e)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 206 | / gen_create_fun![ [INFO] [stdout] 207 | | IoError , io_error , std::io::Error, [INFO] [stdout] 208 | | Utf8ValidationError , utf8_validation_error , std::str::Utf8Error, [INFO] [stdout] 209 | | IncorrectLayout , incorrect_layout , std::alloc::LayoutErr, [INFO] [stdout] ... | [INFO] [stdout] 212 | | TimeOperationError , time_operation_error , std::time::SystemTimeError [INFO] [stdout] 213 | | ]; [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `gen_create_fun` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/errors.rs:99:67 [INFO] [stdout] | [INFO] [stdout] 98 | fn from(error: $from_type) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Error::new(ErrorKind::$error_kind, ErrorRepr::$error_kind(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 216 | / gen_error_repr![ [INFO] [stdout] 217 | | std::io::Error, IoError, io_err, [INFO] [stdout] 218 | | std::str::Utf8Error, Utf8ValidationError, utf8_err, [INFO] [stdout] 219 | | std::alloc::LayoutErr, IncorrectLayout, layout_err, [INFO] [stdout] ... | [INFO] [stdout] 222 | | std::time::SystemTimeError, TimeOperationError, time_operation_err [INFO] [stdout] 223 | | ]; [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `gen_error_repr` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/intercom.rs:177:18 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn new(val: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | val: UnsafeCell::new(val), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_mgr/log_mgr.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(conf: ConfigMt) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let conf = conf.get_conf(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let fs = FileStream::new(log_dir.clone(), max_log_file_size, file_id, 4, false, true)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let mut lr = LogReader::new(fs)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let bfs = BufferedFileStream::new(log_dir.clone(), max_log_file_size, buf_sz as usize, file_id, start_pos)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | let lsn = Sequence::new(lsn); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | let writer = LogWriter::new(bfs, lsn)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | [INFO] [stdout] 47 | Ok(LogMgr { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | writer, [INFO] [stdout] 49 | | log_dir, [INFO] [stdout] 50 | | starting_csn, [INFO] [stdout] 51 | | latest_commit_csn, [INFO] [stdout] 52 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_mgr/log_mgr.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 81 | let fs = FileStream::new(self.log_dir.clone(), 0, file_id, 4, false, true)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | Ok(LogReader::new(fs)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_mgr/buf.rs:282:12 [INFO] [stdout] | [INFO] [stdout] 272 | let bufs = Arc::new(vec![Buf::::new(sz)?, Buf::new(sz)?]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | [INFO] [stdout] 274 | let buf_state = Arc::new((Mutex::new([BufState::Appendable, BufState::Appendable]), Condvar::new(), Condvar::new())); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | Ok(DoubleBuf { [INFO] [stdout] | ____________^ [INFO] [stdout] 283 | | bufs, [INFO] [stdout] 284 | | #[cfg(feature = "metrics")] [INFO] [stdout] 285 | | metrics, [INFO] [stdout] 286 | | buf_state, [INFO] [stdout] 287 | | size: sz, [INFO] [stdout] 288 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_mgr/fs.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 43 | let mut f = OpenOptions::new() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let rotation = if enable_rotation { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | if !FileOps::build_file_name(&log_dir, file_id + 1).exists() { [INFO] [stdout] 55 | let _next_file = FileOps::create_log_file(&log_dir, file_id+1, max_file_size, false); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(FileStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | f, [INFO] [stdout] 66 | | max_file_size, [INFO] [stdout] 67 | | log_dir, [INFO] [stdout] ... | [INFO] [stdout] 70 | | offset, [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_mgr/fs.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 165 | let terminate = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | [INFO] [stdout] 167 | let terminate2 = terminate.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | [INFO] [stdout] 169 | let db = DoubleBuf::new(buf_sz)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | [INFO] [stdout] 171 | let db2 = db.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | [INFO] [stdout] 173 | let fs = FileStream::new(log_dir, max_file_size, file_id, start_pos, true, false)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let writer_thread = std::thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok(BufferedFileStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | writer_thread: Arc::new(writer_thread), [INFO] [stdout] 184 | | terminate, [INFO] [stdout] 185 | | buf: db, [INFO] [stdout] 186 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_mgr/io.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn new(out_stream: BufferedFileStream, lsn: Sequence) -> Result { [INFO] [stdout] | ------------------------------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Ok(LogWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 70 | | out_stream, [INFO] [stdout] 71 | | lsn, [INFO] [stdout] 72 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_mgr/io.rs:237:12 [INFO] [stdout] | [INFO] [stdout] 235 | pub fn new(fs: FileStream) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | [INFO] [stdout] 237 | Ok(LogReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 238 | | fs, [INFO] [stdout] 239 | | data_buf: Vec::new(), [INFO] [stdout] 240 | | vector: Vector::new(), [INFO] [stdout] ... | [INFO] [stdout] 246 | | checkpoint_csn: 1, [INFO] [stdout] 247 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/driver.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn new(conf: ConfigMt, csns: SharedSequences) -> Result { [INFO] [stdout] | -------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | let driver = BlockStorageDriver::new(conf.clone(), csns.clone())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Ok(StorageDriver{ [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | driver, [INFO] [stdout] 54 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/driver.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn from_shared_state(ss: StorageDriverSharedState) -> Result { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Ok(StorageDriver { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | driver: BlockStorageDriver::from_shared_state(ss.ss)?, [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/datastore.rs:279:12 [INFO] [stdout] | [INFO] [stdout] 255 | let desc_repo = self.desc_repo.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | let mut files = HashMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | let lock_file = self.lock_file.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | let seq_file_id = self.seq_file_id.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | [INFO] [stdout] 279 | Ok(DataStore { [INFO] [stdout] | ____________^ [INFO] [stdout] 280 | | desc_repo, [INFO] [stdout] 281 | | block_size, [INFO] [stdout] 282 | | block_fill_size, [INFO] [stdout] ... | [INFO] [stdout] 288 | | path_buf: RefCell::new(String::new()), [INFO] [stdout] 289 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/datastore.rs:493:12 [INFO] [stdout] | [INFO] [stdout] 469 | let f = std::fs::OpenOptions::new() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 476 | let (files, desc_set, block_size, paths) = Self::load_files(&path)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 479 | let desc_repo = FileDescRepo::new(desc_set, paths); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 490 | let lock_file = Arc::new(f); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 491 | let seq_file_id = Arc::new(AtomicU16::new(seq_file_id)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 492 | [INFO] [stdout] 493 | Ok(DataStore { [INFO] [stdout] | ____________^ [INFO] [stdout] 494 | | desc_repo, [INFO] [stdout] 495 | | block_size, [INFO] [stdout] 496 | | block_fill_size, [INFO] [stdout] ... | [INFO] [stdout] 502 | | path_buf: RefCell::new(String::new()), [INFO] [stdout] 503 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/datastore.rs:530:12 [INFO] [stdout] | [INFO] [stdout] 511 | let mut files = HashMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 530 | Ok((files, desc_set, block_size, paths)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/datastore.rs:592:12 [INFO] [stdout] | [INFO] [stdout] 537 | let mut f = std::fs::OpenOptions::new() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 592 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 593 | | f, [INFO] [stdout] 594 | | FileDesc { [INFO] [stdout] 595 | | state: FileState::InUse, [INFO] [stdout] ... | [INFO] [stdout] 602 | | block_size as usize [INFO] [stdout] 603 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/storage/datastore.rs:764:9 [INFO] [stdout] | [INFO] [stdout] 764 | drop(v); [INFO] [stdout] | ^^^^^-^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `()` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 764 - drop(v); [INFO] [stdout] 764 + let _ = v; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/block_driver.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn new(conf: ConfigMt, csns: SharedSequences) -> Result { [INFO] [stdout] | -------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let block_mgr = Rc::new(BlockMgr::new(conf.clone())?); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | [INFO] [stdout] 112 | let block_allocator = Rc::new(BlockAllocator::new(conf.clone(), block_mgr.clone())); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | [INFO] [stdout] 114 | let version_store = VersionStore::new(block_mgr.clone(), block_allocator.clone(), Duration::from_secs(version_retain_time as u64)... [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let checkpoint_store = CheckpointStore::new(block_mgr.clone(), block_allocator.clone())?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | [INFO] [stdout] 117 | let buf_writer = BufWriter::new(&block_mgr, writer_num as usize)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | [INFO] [stdout] 119 | Ok(BlockStorageDriver{ [INFO] [stdout] | ____________^ [INFO] [stdout] 120 | | block_mgr, [INFO] [stdout] 121 | | block_allocator, [INFO] [stdout] 122 | | version_store, [INFO] [stdout] ... | [INFO] [stdout] 125 | | csns, [INFO] [stdout] 126 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/block_driver.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn from_shared_state(ss: BlockStorageSharedState) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | [INFO] [stdout] 132 | let BlockStorageSharedState { buf_writer, block_mgr, csns, ba_ss, vs_ss } = ss; [INFO] [stdout] | ---------- --------- ---- ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | | [INFO] [stdout] | | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | [INFO] [stdout] 134 | let block_mgr = Rc::new(block_mgr); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | [INFO] [stdout] 136 | let block_allocator = Rc::new(BlockAllocator::from_shared_state(block_mgr.clone(), ba_ss)?); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | [INFO] [stdout] 138 | let version_store = VersionStore::from_shared_state(block_mgr.clone(), block_allocator.clone(), vs_ss)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let checkpoint_store = CheckpointStore::new(block_mgr.clone(), block_allocator.clone())?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | [INFO] [stdout] 141 | Ok(BlockStorageDriver{ [INFO] [stdout] | ____________^ [INFO] [stdout] 142 | | block_mgr, [INFO] [stdout] 143 | | block_allocator, [INFO] [stdout] 144 | | version_store, [INFO] [stdout] ... | [INFO] [stdout] 147 | | csns, [INFO] [stdout] 148 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/block_driver.rs:630:12 [INFO] [stdout] | [INFO] [stdout] 626 | let mut block = self.block_mgr.get_block_mut(block_id)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 630 | Ok((block, checkpoint_csn)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/block_driver.rs:652:12 [INFO] [stdout] | [INFO] [stdout] 644 | let mut block = if requested_size > self.block_mgr.block_fill_size() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 652 | Ok((block, checkpoint_csn)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/checkpoint_store.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn new(block_mgr: Rc, block_allocator: Rc) -> Result { [INFO] [stdout] | ----------------------- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let file_info = RefCell::new(vec![]); [INFO] [stdout] 43 | Ok(CheckpointStore { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | block_mgr, [INFO] [stdout] 45 | | block_allocator, [INFO] [stdout] 46 | | file_info, [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/version_store.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn new(block_mgr: Rc, block_allocator: Rc, _retain_timespan: Duration, trn_set_size: usize) -> Result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/version_store.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn from_shared_state(block_mgr: Rc, block_allocator: Rc, ss: VersionStoreSharedState) -> Result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/version_store.rs:93:33 [INFO] [stdout] | [INFO] [stdout] 88 | let (lock, used_space, total_free_space) = self.entry_allocator.borrow().get_shared_state(); [INFO] [stdout] | ---- ---------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | trn_repo: self.trn_repo.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/version_store.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 200 | pub fn new(block_mgr: Rc, block_allocator: Rc) -> Result { [INFO] [stdout] | ----------------------- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | let used_space = Arc::new(AtomicUsize::new(2 + DBLOCK_HEADER_LEN)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | let total_free_space = Arc::new(block_mgr.get_block_size()); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | let lock = Arc::new(Mutex::new(allocator_state)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | [INFO] [stdout] 216 | Ok(VersioningStoreEntryAllocator { [INFO] [stdout] | ____________^ [INFO] [stdout] 217 | | block_mgr, [INFO] [stdout] 218 | | block_allocator, [INFO] [stdout] 219 | | lock, [INFO] [stdout] ... | [INFO] [stdout] 222 | | cur_block_id, [INFO] [stdout] 223 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/version_store.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 229 | block_mgr: Rc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | block_allocator: Rc, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | lock: Arc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | used_space: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | total_free_space: Arc) -> Result [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | Ok(VersioningStoreEntryAllocator { [INFO] [stdout] | ____________^ [INFO] [stdout] 237 | | block_mgr, [INFO] [stdout] 238 | | block_allocator, [INFO] [stdout] 239 | | lock, [INFO] [stdout] ... | [INFO] [stdout] 242 | | cur_block_id, [INFO] [stdout] 243 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/version_store.rs:332:23 [INFO] [stdout] | [INFO] [stdout] 329 | let earliest_start_time = Arc::new(AtomicU64::new(epoch_as_secs())); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 332 | trn_info: Arc::new(Mutex::new(body)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/system/instance.rs:320:12 [INFO] [stdout] | [INFO] [stdout] 307 | pub fn from_shared_state(ss: InstanceSharedState) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | conf, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 311 | csns, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | tran_mgr, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | log_mgr, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | checkpointer, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 315 | storage_ss, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | let storage_driver = StorageDriver::from_shared_state(storage_ss)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | [INFO] [stdout] 320 | Ok(Instance { [INFO] [stdout] | ____________^ [INFO] [stdout] 321 | | conf, [INFO] [stdout] 322 | | csns, [INFO] [stdout] 323 | | tran_mgr, [INFO] [stdout] ... | [INFO] [stdout] 326 | | checkpointer, [INFO] [stdout] 327 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/system/checkpointer.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(log_mgr: LogMgr, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | csns: SharedSequences, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | conf: ConfigMt, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | tran_mgr: TranMgr [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let terminate = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | [INFO] [stdout] 55 | let checkpoint_ready = SyncNotification::new(false); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let checkpoint_req_count = Arc::new(AtomicU32::new(0)); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | [INFO] [stdout] 58 | let terminate2 = terminate.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let checkpoint_ready2 = checkpoint_ready.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let checkpoint_req_count2 = checkpoint_req_count.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | let checkpointer_thread = std::thread::spawn(move || { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok(Checkpointer { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | checkpointer_thread, [INFO] [stdout] 78 | | terminate, [INFO] [stdout] 79 | | checkpoint_ready, [INFO] [stdout] ... | [INFO] [stdout] 82 | | checkpoint_req_count, [INFO] [stdout] 83 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/system/checkpointer.rs:129:15 [INFO] [stdout] | [INFO] [stdout] 121 | fn checkpointer_thread(conf: ConfigMt, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | terminate: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | checkpoint_ready: SyncNotification, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | log_mgr: LogMgr, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | csns: SharedSequences, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | checkpoint_req_count: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | tran_mgr: TranMgr) [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | { [INFO] [stdout] 129 | match StorageDriver::new(conf, csns.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tran_mgr/tran_mgr.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(conf: ConfigMt) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | [INFO] [stdout] 30 | let conf = conf.get_conf(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let mut trn_set = Vec::with_capacity(nbkt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Ok(TranMgr { [INFO] [stdout] | ____________^ [INFO] [stdout] 47 | | tsn: Sequence::new(1), [INFO] [stdout] 48 | | nbkt, [INFO] [stdout] 49 | | nobj_bkt, [INFO] [stdout] 50 | | trn_set: Arc::new(trn_set), [INFO] [stdout] 51 | | obj_locks: Arc::new(obj_locks), [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_mgr/block_mgr.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(conf: ConfigMt) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let ds = DataStore::new(conf.clone())?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let buf_mgr = Arc::new(BufMgr::new(block_size, block_buf_size as usize / block_size)?); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | Ok(BlockMgr { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | locks: Arc::new(locks), [INFO] [stdout] 64 | | buf_mgr, [INFO] [stdout] 65 | | ds, [INFO] [stdout] 66 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_mgr/block_mgr.rs:254:12 [INFO] [stdout] | [INFO] [stdout] 252 | let (mut data, buf_idx) = self.allocate_on_cache(block_id, block_type); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | for b in data.deref_mut().deref_mut() {*b = 0;}; [INFO] [stdout] 254 | Ok(DataBlock::new(block_id, buf_idx, data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_mgr/free_info.rs:56:25 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(conf: ConfigMt, block_mgr: Rc) -> Self { [INFO] [stdout] | -------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | file_locks: Arc::new(file_locks), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_mgr/free_info.rs:57:27 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(conf: ConfigMt, block_mgr: Rc) -> Self { [INFO] [stdout] | -------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | extent_locks: Arc::new(extent_locks), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_mgr/free_info.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn from_shared_state(block_mgr: Rc, ss: FreeInfoSharedState) -> Result { [INFO] [stdout] | ----------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let FreeInfoSharedState { file_locks, extent_locks } = ss; [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(FreeInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | block_mgr, [INFO] [stdout] 70 | | file_locks, [INFO] [stdout] 71 | | extent_locks, [INFO] [stdout] 72 | | block_size, [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_mgr/allocator.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn from_shared_state(block_mgr: Rc, ss: BlockAllocatorSharedState) -> Result { [INFO] [stdout] | ----------------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let BlockAllocatorSharedState { fi_ss, checkpoint_store_seq } = ss; [INFO] [stdout] | ----- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | let free_info = FreeInfo::from_shared_state(block_mgr.clone(), fi_ss)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(BlockAllocator { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | block_mgr, [INFO] [stdout] 67 | | free_info, [INFO] [stdout] 68 | | file_desc_buf, [INFO] [stdout] ... | [INFO] [stdout] 71 | | checkpoint_store_seq, [INFO] [stdout] 72 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_mgr/allocator.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 203 | let file_fi_data = self.file_fi_data.borrow(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | Ok(None) [INFO] [stdout] | ^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_mgr/allocator.rs:245:12 [INFO] [stdout] | [INFO] [stdout] 221 | let extent_fi_data = self.extent_fi_data.borrow(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 43 previous errors; 32 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `db-core` (lib) due to 44 previous errors; 32 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "43d7e4263c44a5d9ed38ad37e0d999171623727d3cf74210d05c3b2b21f0d338", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43d7e4263c44a5d9ed38ad37e0d999171623727d3cf74210d05c3b2b21f0d338", kill_on_drop: false }` [INFO] [stdout] 43d7e4263c44a5d9ed38ad37e0d999171623727d3cf74210d05c3b2b21f0d338