[INFO] fetching crate datafusion-physical-optimizer 41.0.0... [INFO] checking datafusion-physical-optimizer-41.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate datafusion-physical-optimizer 41.0.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate datafusion-physical-optimizer 41.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate datafusion-physical-optimizer 41.0.0 [INFO] finished tweaking crates.io crate datafusion-physical-optimizer 41.0.0 [INFO] tweaked toml for crates.io crate datafusion-physical-optimizer 41.0.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 198 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding object_store v0.10.2 (latest: v0.11.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding snafu v0.7.5 (latest: v0.8.4) [INFO] [stderr] Adding snafu-derive v0.7.5 (latest: v0.8.4) [INFO] [stderr] Adding sqlparser v0.49.0 (latest: v0.50.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe4b5d6c385847823021f2ae490680e7dc1e8b7388de1cf5c21f1b01ef49d960 [INFO] running `Command { std: "docker" "start" "-a" "fe4b5d6c385847823021f2ae490680e7dc1e8b7388de1cf5c21f1b01ef49d960", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe4b5d6c385847823021f2ae490680e7dc1e8b7388de1cf5c21f1b01ef49d960", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe4b5d6c385847823021f2ae490680e7dc1e8b7388de1cf5c21f1b01ef49d960", kill_on_drop: false }` [INFO] [stdout] fe4b5d6c385847823021f2ae490680e7dc1e8b7388de1cf5c21f1b01ef49d960 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5234584d345a2d469556a9a65b797c8eca574a1ccad65db140123659d8e01368 [INFO] running `Command { std: "docker" "start" "-a" "5234584d345a2d469556a9a65b797c8eca574a1ccad65db140123659d8e01368", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking arrow-schema v52.2.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling flatbuffers v24.3.25 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling sqlparser_derive v0.2.2 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking sqlparser v0.49.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v52.2.0 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking dashmap v6.0.1 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Checking arrow-data v52.2.0 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking object_store v0.10.2 [INFO] [stderr] Checking datafusion-common-runtime v41.0.0 [INFO] [stderr] Checking arrow-array v52.2.0 [INFO] [stderr] Checking arrow-select v52.2.0 [INFO] [stderr] Checking arrow-row v52.2.0 [INFO] [stderr] Checking arrow-arith v52.2.0 [INFO] [stderr] Checking arrow-cast v52.2.0 [INFO] [stderr] Checking arrow-ord v52.2.0 [INFO] [stderr] Checking arrow-string v52.2.0 [INFO] [stderr] Checking arrow-json v52.2.0 [INFO] [stderr] Checking arrow-csv v52.2.0 [INFO] [stderr] Checking arrow-ipc v52.2.0 [INFO] [stderr] Checking arrow v52.2.0 [INFO] [stderr] Checking datafusion-common v41.0.0 [INFO] [stderr] Checking datafusion-expr v41.0.0 [INFO] [stderr] Checking datafusion-physical-expr-common v41.0.0 [INFO] [stderr] Checking datafusion-execution v41.0.0 [INFO] [stderr] Checking datafusion-functions-aggregate v41.0.0 [INFO] [stderr] Checking datafusion-physical-expr v41.0.0 [INFO] [stderr] Checking datafusion-physical-plan v41.0.0 [INFO] [stderr] Checking datafusion-physical-optimizer v41.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aggregate_statistics.rs:83:21 [INFO] [stdout] | [INFO] [stdout] 82 | plan.map_children(|child| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | self.optimize(child, _config).map(Transformed::yes) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aggregate_statistics.rs:88:39 [INFO] [stdout] | [INFO] [stdout] 88 | plan.map_children(|child| self.optimize(child, _config).map(Transformed::yes)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output_requirements.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 173 | self: Arc, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | mut children: Vec>, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | ) -> Result> { [INFO] [stdout] 176 | Ok(Arc::new(Self::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 177 | | children.remove(0), // has a single child [INFO] [stdout] 178 | | self.order_requirement.clone(), [INFO] [stdout] 179 | | self.dist_requirement.clone(), [INFO] [stdout] 180 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `datafusion-physical-optimizer` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aggregate_statistics.rs:83:21 [INFO] [stdout] | [INFO] [stdout] 82 | plan.map_children(|child| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | self.optimize(child, _config).map(Transformed::yes) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aggregate_statistics.rs:88:39 [INFO] [stdout] | [INFO] [stdout] 88 | plan.map_children(|child| self.optimize(child, _config).map(Transformed::yes)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output_requirements.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 173 | self: Arc, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | mut children: Vec>, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | ) -> Result> { [INFO] [stdout] 176 | Ok(Arc::new(Self::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 177 | | children.remove(0), // has a single child [INFO] [stdout] 178 | | self.order_requirement.clone(), [INFO] [stdout] 179 | | self.dist_requirement.clone(), [INFO] [stdout] 180 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `datafusion-physical-optimizer` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "5234584d345a2d469556a9a65b797c8eca574a1ccad65db140123659d8e01368", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5234584d345a2d469556a9a65b797c8eca574a1ccad65db140123659d8e01368", kill_on_drop: false }` [INFO] [stdout] 5234584d345a2d469556a9a65b797c8eca574a1ccad65db140123659d8e01368