[INFO] fetching crate daab 0.4.0... [INFO] checking daab-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate daab 0.4.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate daab 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate daab 0.4.0 [INFO] finished tweaking crates.io crate daab 0.4.0 [INFO] tweaked toml for crates.io crate daab 0.4.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate daab 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6721e264113d761313c9f629214a52cb5539fed73e6d888d5fe824430464b382 [INFO] running `Command { std: "docker" "start" "-a" "6721e264113d761313c9f629214a52cb5539fed73e6d888d5fe824430464b382", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6721e264113d761313c9f629214a52cb5539fed73e6d888d5fe824430464b382", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6721e264113d761313c9f629214a52cb5539fed73e6d888d5fe824430464b382", kill_on_drop: false }` [INFO] [stdout] 6721e264113d761313c9f629214a52cb5539fed73e6d888d5fe824430464b382 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f406cad2b0e205a07a3ccfc0996414fc377786ff4c3573f42e9cd3fb06d6368c [INFO] running `Command { std: "docker" "start" "-a" "f406cad2b0e205a07a3ccfc0996414fc377786ff4c3573f42e9cd3fb06d6368c", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking never v0.1.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking daab v0.4.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking pretty_assertions v0.6.1 [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:345:9 [INFO] [stdout] | [INFO] [stdout] 345 | Err(n) => match n {}, [INFO] [stdout] | ^^^^^^ matches no values because `Never` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `builder_ptr` is never used [INFO] [stdout] --> src/blueprint.rs:167:16 [INFO] [stdout] | [INFO] [stdout] 150 | impl> Blueprint { [INFO] [stdout] | ---------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 167 | pub(crate) fn builder_ptr(&self) -> *const () { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `BuilderDyn` is never used [INFO] [stdout] --> src/blueprint.rs:562:6 [INFO] [stdout] | [INFO] [stdout] 562 | type BuilderDyn = dyn Builder; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `builder_ptr` is never used [INFO] [stdout] --> src/blueprint.rs:674:16 [INFO] [stdout] | [INFO] [stdout] 654 | / impl BlueprintDyn [INFO] [stdout] 655 | | where [INFO] [stdout] 656 | | BCan: Can>, { [INFO] [stdout] | |____________________________________________________________________________________- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 674 | pub(crate) fn builder_ptr(&self) -> *const () { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `lookup_mut`, `get_mut`, and `invalidate_dependents` are never used [INFO] [stdout] --> src/cache/internal.rs:367:16 [INFO] [stdout] | [INFO] [stdout] 219 | / impl RawCache [INFO] [stdout] 220 | | where [INFO] [stdout] 221 | | ArtCan: Debug, [INFO] [stdout] 222 | | BCan: CanStrong { [INFO] [stdout] | |___________________________- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 367 | pub(crate) fn lookup_mut( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 555 | pub(crate) fn get_mut( [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 850 | fn invalidate_dependents(&mut self, builder: &BuilderId) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a type alias [INFO] [stdout] --> src/rc.rs:57:1 [INFO] [stdout] | [INFO] [stdout] 57 | pub type ConstBuilder = crate::utils::ConstBuilder, T>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | #![warn(missing_docs)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a type alias [INFO] [stdout] --> src/rc.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | pub type ConfigurableBuilder = crate::utils::ConfigurableBuilder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a type alias [INFO] [stdout] --> src/arc.rs:57:1 [INFO] [stdout] | [INFO] [stdout] 57 | pub type ConstBuilder = crate::utils::ConstBuilder, T>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a type alias [INFO] [stdout] --> src/arc.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | pub type ConfigurableBuilder = crate::utils::ConfigurableBuilder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a type alias [INFO] [stdout] --> src/boxed.rs:59:1 [INFO] [stdout] | [INFO] [stdout] 59 | pub type ConstBuilder = crate::utils::ConstBuilder, T>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a type alias [INFO] [stdout] --> src/boxed.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | pub type ConfigurableBuilder = crate::utils::ConfigurableBuilder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for an associated type [INFO] [stdout] --> src/blueprint.rs:80:2 [INFO] [stdout] | [INFO] [stdout] 80 | type Builder: ?Sized + 'static + Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for an associated type [INFO] [stdout] --> src/blueprint.rs:81:2 [INFO] [stdout] | [INFO] [stdout] 81 | type BCan: Can; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canning.rs:162:18 [INFO] [stdout] | [INFO] [stdout] 161 | fn from_inner(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | Self::from_bin(Self::into_bin(t)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canning.rs:451:3 [INFO] [stdout] | [INFO] [stdout] 450 | fn downcast_can(self) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 451 | self.downcast().ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canning.rs:535:3 [INFO] [stdout] | [INFO] [stdout] 534 | fn downcast_can(self) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 535 | self.downcast().ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canning.rs:604:3 [INFO] [stdout] | [INFO] [stdout] 603 | fn downcast_can(self) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 604 | self.downcast().ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/internal.rs:614:17 [INFO] [stdout] | [INFO] [stdout] 614 | || Box::new(promise.builder().builder.init_dyn_state()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/internal.rs:901:18 [INFO] [stdout] | [INFO] [stdout] 901 | .filter(|bid| BCan::upgrade_from_weak(&self.known_builders[bid]).is_none()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:385:4 [INFO] [stdout] | [INFO] [stdout] 383 | fn from(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | Blueprint::new( [INFO] [stdout] 385 | ConstBuilder::new(ArtCan::into_bin(t)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:482:4 [INFO] [stdout] | [INFO] [stdout] 480 | fn from(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 481 | Blueprint::new( [INFO] [stdout] 482 | ConfigurableBuilder::new(t) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `daab` (lib) due to 9 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f406cad2b0e205a07a3ccfc0996414fc377786ff4c3573f42e9cd3fb06d6368c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f406cad2b0e205a07a3ccfc0996414fc377786ff4c3573f42e9cd3fb06d6368c", kill_on_drop: false }` [INFO] [stdout] f406cad2b0e205a07a3ccfc0996414fc377786ff4c3573f42e9cd3fb06d6368c