[INFO] fetching crate cycler 0.3.0... [INFO] checking cycler-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cycler 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cycler 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cycler 0.3.0 [INFO] finished tweaking crates.io crate cycler 0.3.0 [INFO] tweaked toml for crates.io crate cycler 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 46144e345b17b48c7cebbd15755fc50b2bb6560283bb216ba7e4a49e5802a30e [INFO] running `Command { std: "docker" "start" "-a" "46144e345b17b48c7cebbd15755fc50b2bb6560283bb216ba7e4a49e5802a30e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "46144e345b17b48c7cebbd15755fc50b2bb6560283bb216ba7e4a49e5802a30e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46144e345b17b48c7cebbd15755fc50b2bb6560283bb216ba7e4a49e5802a30e", kill_on_drop: false }` [INFO] [stdout] 46144e345b17b48c7cebbd15755fc50b2bb6560283bb216ba7e4a49e5802a30e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 64255e28b8db8af5870041361efea212188b99b73b3ea277241b45413b4870ce [INFO] running `Command { std: "docker" "start" "-a" "64255e28b8db8af5870041361efea212188b99b73b3ea277241b45413b4870ce", kill_on_drop: false }` [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking cycler v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:64:25 [INFO] [stdout] | [INFO] [stdout] 59 | initial_value: T, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | build_single_reader([initial_value.clone(), initial_value.clone(), initial_value]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rw_lock_cycler/builder.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn build_single_reader(values: [T; 3]) -> (RwLockCyclerWriter, RwLockCyclerReader) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let [a, b, c] = values; [INFO] [stdout] | - - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let ref_holder = Arc::new(StaticRefHolder::new(cycler)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | ( [INFO] [stdout] 20 | / RwLockCyclerWriter { [INFO] [stdout] 21 | | #[cfg(feature = "unsafe_cleanup")] [INFO] [stdout] 22 | | ref_holder: ref_holder.clone(), [INFO] [stdout] 23 | | cycler, [INFO] [stdout] 24 | | writer: cycler.data_slots[1].write(), [INFO] [stdout] 25 | | currently_writing: 1, [INFO] [stdout] 26 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rw_lock_cycler/builder.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn build_single_reader(values: [T; 3]) -> (RwLockCyclerWriter, RwLockCyclerReader) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let [a, b, c] = values; [INFO] [stdout] | - - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let ref_holder = Arc::new(StaticRefHolder::new(cycler)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | / RwLockCyclerReader { [INFO] [stdout] 28 | | #[cfg(feature = "unsafe_cleanup")] [INFO] [stdout] 29 | | ref_holder, [INFO] [stdout] 30 | | cycler, [INFO] [stdout] 31 | | reader: Some(cycler.data_slots[0].read()), [INFO] [stdout] 32 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rw_lock_cycler/builder.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn build_multiple_reader(initial_values: Vec) -> (RwLockCyclerWriter, Vec>) { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let ref_holder = Arc::new(StaticRefHolder::new(cycler)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let mut readers = Vec::with_capacity(cycler.num_readers()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | / RwLockCyclerWriter { [INFO] [stdout] 57 | | #[cfg(feature = "unsafe_cleanup")] [INFO] [stdout] 58 | | ref_holder, [INFO] [stdout] 59 | | writer: cycler.data_slots[1].write(), [INFO] [stdout] 60 | | cycler, [INFO] [stdout] 61 | | currently_writing: 1, [INFO] [stdout] 62 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:64:25 [INFO] [stdout] | [INFO] [stdout] 59 | initial_value: T, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | build_single_reader([initial_value.clone(), initial_value.clone(), initial_value]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_cycler/builder.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn build_single_reader(values: [T; 3]) -> (AtomicCyclerWriter, AtomicCyclerReader) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let [a, b, c] = values; [INFO] [stdout] | - - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let cycler = Arc::new(AtomicCycler { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | / AtomicCyclerWriter { [INFO] [stdout] 16 | | cycler: cycler.clone(), [INFO] [stdout] 17 | | writer: cycler.data_slots[1].try_write_static().unwrap(), [INFO] [stdout] 18 | | currently_writing: 1, [INFO] [stdout] 19 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rw_lock_cycler/builder.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn build_single_reader(values: [T; 3]) -> (RwLockCyclerWriter, RwLockCyclerReader) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let [a, b, c] = values; [INFO] [stdout] | - - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let ref_holder = Arc::new(StaticRefHolder::new(cycler)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | ( [INFO] [stdout] 20 | / RwLockCyclerWriter { [INFO] [stdout] 21 | | #[cfg(feature = "unsafe_cleanup")] [INFO] [stdout] 22 | | ref_holder: ref_holder.clone(), [INFO] [stdout] 23 | | cycler, [INFO] [stdout] 24 | | writer: cycler.data_slots[1].write(), [INFO] [stdout] 25 | | currently_writing: 1, [INFO] [stdout] 26 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_cycler/builder.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn build_single_reader(values: [T; 3]) -> (AtomicCyclerWriter, AtomicCyclerReader) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let [a, b, c] = values; [INFO] [stdout] | - - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let cycler = Arc::new(AtomicCycler { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | / AtomicCyclerReader { [INFO] [stdout] 21 | | reader: Some(cycler.data_slots[0].try_read_static().unwrap()), [INFO] [stdout] 22 | | cycler, [INFO] [stdout] 23 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_cycler/builder.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn build_multiple_reader(initial_values: Vec) -> (AtomicCyclerWriter, Vec>) { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let cycler = Arc::new(AtomicCycler { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let mut readers = Vec::with_capacity(cycler.num_readers()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | / AtomicCyclerWriter { [INFO] [stdout] 44 | | writer: cycler.data_slots[1].try_write_static().unwrap(), [INFO] [stdout] 45 | | cycler, [INFO] [stdout] 46 | | currently_writing: 1, [INFO] [stdout] 47 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_cycler/builder.rs:32:66 [INFO] [stdout] | [INFO] [stdout] 32 | data_slots: initial_values.into_iter().map(|val|Arc::new(AtomicRwLock::new_u8(val))).collect(), [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_rw_lock.rs:51:23 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Self { count: A::new(A::ONE), data: UnsafeCell::new(value) } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_rw_lock.rs:51:45 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Self { count: A::new(A::ONE), data: UnsafeCell::new(value) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_rw_lock.rs:175:21 [INFO] [stdout] | [INFO] [stdout] 174 | fn new(lock: L) -> Self{ [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | Self{ lock: Some(lock) } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_rw_lock.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn into_inner(mut self) -> L{ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | self.lock.take().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_rw_lock.rs:183:35 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn downgrade(self) -> AtomicRwLockReader{ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | self.lock.as_ref().unwrap().count.fetch_add(A::ONE + A::ONE, Ordering::SeqCst); [INFO] [stdout] 183 | AtomicRwLockReader{ lock: self.into_inner() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rw_lock_cycler/builder.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn build_single_reader(values: [T; 3]) -> (RwLockCyclerWriter, RwLockCyclerReader) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let [a, b, c] = values; [INFO] [stdout] | - - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let ref_holder = Arc::new(StaticRefHolder::new(cycler)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | / RwLockCyclerReader { [INFO] [stdout] 28 | | #[cfg(feature = "unsafe_cleanup")] [INFO] [stdout] 29 | | ref_holder, [INFO] [stdout] 30 | | cycler, [INFO] [stdout] 31 | | reader: Some(cycler.data_slots[0].read()), [INFO] [stdout] 32 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rw_lock_cycler/builder.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn build_multiple_reader(initial_values: Vec) -> (RwLockCyclerWriter, Vec>) { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let ref_holder = Arc::new(StaticRefHolder::new(cycler)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let mut readers = Vec::with_capacity(cycler.num_readers()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | / RwLockCyclerWriter { [INFO] [stdout] 57 | | #[cfg(feature = "unsafe_cleanup")] [INFO] [stdout] 58 | | ref_holder, [INFO] [stdout] 59 | | writer: cycler.data_slots[1].write(), [INFO] [stdout] 60 | | cycler, [INFO] [stdout] 61 | | currently_writing: 1, [INFO] [stdout] 62 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_cycler/builder.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn build_single_reader(values: [T; 3]) -> (AtomicCyclerWriter, AtomicCyclerReader) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let [a, b, c] = values; [INFO] [stdout] | - - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let cycler = Arc::new(AtomicCycler { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | / AtomicCyclerWriter { [INFO] [stdout] 16 | | cycler: cycler.clone(), [INFO] [stdout] 17 | | writer: cycler.data_slots[1].try_write_static().unwrap(), [INFO] [stdout] 18 | | currently_writing: 1, [INFO] [stdout] 19 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_cycler/builder.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn build_single_reader(values: [T; 3]) -> (AtomicCyclerWriter, AtomicCyclerReader) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let [a, b, c] = values; [INFO] [stdout] | - - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let cycler = Arc::new(AtomicCycler { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | / AtomicCyclerReader { [INFO] [stdout] 21 | | reader: Some(cycler.data_slots[0].try_read_static().unwrap()), [INFO] [stdout] 22 | | cycler, [INFO] [stdout] 23 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_cycler/builder.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn build_multiple_reader(initial_values: Vec) -> (AtomicCyclerWriter, Vec>) { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let cycler = Arc::new(AtomicCycler { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let mut readers = Vec::with_capacity(cycler.num_readers()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | / AtomicCyclerWriter { [INFO] [stdout] 44 | | writer: cycler.data_slots[1].try_write_static().unwrap(), [INFO] [stdout] 45 | | cycler, [INFO] [stdout] 46 | | currently_writing: 1, [INFO] [stdout] 47 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_cycler/builder.rs:32:66 [INFO] [stdout] | [INFO] [stdout] 32 | data_slots: initial_values.into_iter().map(|val|Arc::new(AtomicRwLock::new_u8(val))).collect(), [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_rw_lock.rs:51:23 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Self { count: A::new(A::ONE), data: UnsafeCell::new(value) } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_rw_lock.rs:51:45 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Self { count: A::new(A::ONE), data: UnsafeCell::new(value) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_rw_lock.rs:175:21 [INFO] [stdout] | [INFO] [stdout] 174 | fn new(lock: L) -> Self{ [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | Self{ lock: Some(lock) } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_rw_lock.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn into_inner(mut self) -> L{ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | self.lock.take().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic_rw_lock.rs:183:35 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn downgrade(self) -> AtomicRwLockReader{ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | self.lock.as_ref().unwrap().count.fetch_add(A::ONE + A::ONE, Ordering::SeqCst); [INFO] [stdout] 183 | AtomicRwLockReader{ lock: self.into_inner() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/static_ref_holder.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | Box::from_raw(self.reference); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 18 | let _ = Box::from_raw(self.reference); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/static_ref_holder.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | Box::from_raw(self.reference); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 18 | let _ = Box::from_raw(self.reference); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cycler` (lib test) due to 14 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cycler` (lib) due to 14 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "64255e28b8db8af5870041361efea212188b99b73b3ea277241b45413b4870ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64255e28b8db8af5870041361efea212188b99b73b3ea277241b45413b4870ce", kill_on_drop: false }` [INFO] [stdout] 64255e28b8db8af5870041361efea212188b99b73b3ea277241b45413b4870ce