[INFO] fetching crate cycle-menu 0.4.2... [INFO] checking cycle-menu-0.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cycle-menu 0.4.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate cycle-menu 0.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cycle-menu 0.4.2 [INFO] finished tweaking crates.io crate cycle-menu 0.4.2 [INFO] tweaked toml for crates.io crate cycle-menu 0.4.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e358c51d37c77bc95aac346e7ea8212396183809f25e82e4c6e75d85893cf89e [INFO] running `Command { std: "docker" "start" "-a" "e358c51d37c77bc95aac346e7ea8212396183809f25e82e4c6e75d85893cf89e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e358c51d37c77bc95aac346e7ea8212396183809f25e82e4c6e75d85893cf89e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e358c51d37c77bc95aac346e7ea8212396183809f25e82e4c6e75d85893cf89e", kill_on_drop: false }` [INFO] [stdout] e358c51d37c77bc95aac346e7ea8212396183809f25e82e4c6e75d85893cf89e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc47c5f36d5b49089c2cff1c201d9e1193aaae5adc22002f007e35ec7967074f [INFO] running `Command { std: "docker" "start" "-a" "cc47c5f36d5b49089c2cff1c201d9e1193aaae5adc22002f007e35ec7967074f", kill_on_drop: false }` [INFO] [stderr] Checking cycle-menu v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn new_action(name: impl Into, f: impl Fn() + 'a + Send) -> Self { [INFO] [stdout] | ---------------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Self::Action(Action { [INFO] [stdout] | ______________________^ [INFO] [stdout] 74 | | name: name.into(), [INFO] [stdout] 75 | | f: Box::new(f), [INFO] [stdout] 76 | | show_active: None, [INFO] [stdout] 77 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new_submenu(name: impl Into, items: types::ItemList<'a>) -> Self { [INFO] [stdout] | ---------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Self::SubMenu(SubMenu { [INFO] [stdout] | _______________________^ [INFO] [stdout] 81 | | position: RefCell::new(0), [INFO] [stdout] 82 | | name: name.into(), [INFO] [stdout] 83 | | #[cfg(feature = "std")] [INFO] [stdout] 84 | | show_active: None, [INFO] [stdout] 85 | | items, [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:142:32 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn new(items: types::ItemList<'a>, disp: impl Fn(&str) + 'a + Send) -> Self { [INFO] [stdout] | -------------------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Self::inner_new(items, Box::new(disp)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cycle-menu` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn new_action(name: impl Into, f: impl Fn() + 'a + Send) -> Self { [INFO] [stdout] | ---------------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Self::Action(Action { [INFO] [stdout] | ______________________^ [INFO] [stdout] 74 | | name: name.into(), [INFO] [stdout] 75 | | f: Box::new(f), [INFO] [stdout] 76 | | show_active: None, [INFO] [stdout] 77 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new_submenu(name: impl Into, items: types::ItemList<'a>) -> Self { [INFO] [stdout] | ---------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Self::SubMenu(SubMenu { [INFO] [stdout] | _______________________^ [INFO] [stdout] 81 | | position: RefCell::new(0), [INFO] [stdout] 82 | | name: name.into(), [INFO] [stdout] 83 | | #[cfg(feature = "std")] [INFO] [stdout] 84 | | show_active: None, [INFO] [stdout] 85 | | items, [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:142:32 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn new(items: types::ItemList<'a>, disp: impl Fn(&str) + 'a + Send) -> Self { [INFO] [stdout] | -------------------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Self::inner_new(items, Box::new(disp)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cycle-menu` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "cc47c5f36d5b49089c2cff1c201d9e1193aaae5adc22002f007e35ec7967074f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc47c5f36d5b49089c2cff1c201d9e1193aaae5adc22002f007e35ec7967074f", kill_on_drop: false }` [INFO] [stdout] cc47c5f36d5b49089c2cff1c201d9e1193aaae5adc22002f007e35ec7967074f