[INFO] fetching crate custard 0.3.1... [INFO] checking custard-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate custard 0.3.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate custard 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate custard 0.3.1 [INFO] finished tweaking crates.io crate custard 0.3.1 [INFO] tweaked toml for crates.io crate custard 0.3.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate custard 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cc6e4ff1e8fa9a48e7743433d3022ba5e287924ed5427ffee0bcba3a5d72fbd6 [INFO] running `Command { std: "docker" "start" "-a" "cc6e4ff1e8fa9a48e7743433d3022ba5e287924ed5427ffee0bcba3a5d72fbd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cc6e4ff1e8fa9a48e7743433d3022ba5e287924ed5427ffee0bcba3a5d72fbd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc6e4ff1e8fa9a48e7743433d3022ba5e287924ed5427ffee0bcba3a5d72fbd6", kill_on_drop: false }` [INFO] [stdout] cc6e4ff1e8fa9a48e7743433d3022ba5e287924ed5427ffee0bcba3a5d72fbd6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cbb8ce4f5c043f7ee75a51bc32103235281afaab4727c7ab6ab5b34f30616ae9 [INFO] running `Command { std: "docker" "start" "-a" "cbb8ce4f5c043f7ee75a51bc32103235281afaab4727c7ab6ab5b34f30616ae9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling serde v1.0.189 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling async-trait v0.1.73 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Compiling camino v1.1.6 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking hashbrown v0.14.1 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking unsafe-libyaml v0.2.9 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Compiling axum-core v0.3.4 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking filetime v0.2.22 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking indexmap v2.0.2 [INFO] [stderr] Checking notify v5.2.0 [INFO] [stderr] Compiling serde_derive v1.0.189 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Checking tokio v1.33.0 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking serde_path_to_error v0.1.14 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_yaml v0.9.25 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking custard v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontmatter_file.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 131 | let md = FrontmatterFile { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | let frontmatter = serde_yaml::from_str(frontmatter) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(FrontmatterFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | name, [INFO] [stdout] 146 | | frontmatter: Some(frontmatter), [INFO] [stdout] 147 | | body: body.to_owned(), [INFO] [stdout] 148 | | modified, [INFO] [stdout] 149 | | created, [INFO] [stdout] 150 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontmatter_file/keeper.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 56 | let markdown_fps = fs::filepaths_with_extensions(path, &["md"])? [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(Keeper { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | inner: markdown_fps, [INFO] [stdout] 66 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontmatter_file/keeper.rs:61:20 [INFO] [stdout] | [INFO] [stdout] 59 | let md = FrontmatterFile::read_from_path(&path)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | [INFO] [stdout] 61 | Ok((path, md)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontmatter_file/keeper.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn new(keeper: Keeper) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Self(Arc::new(Mutex::new(keeper))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 13 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | / entry [INFO] [stdout] 15 | | .map(|entry| { [INFO] [stdout] 16 | | let path = entry.path().to_path_buf(); [INFO] [stdout] 17 | | if !path.is_file() { [INFO] [stdout] ... | [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/markup.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn yaml_to_json(yaml: T) -> U { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 4 | serde_json::from_value(serde_json::to_value(yaml).expect("valid yaml must map to valid json")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route/collate_strings.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 18 | files: impl Iterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | / files [INFO] [stdout] 22 | | .filter_map(|fmf| fmf.frontmatter()) [INFO] [stdout] 23 | | .filter_map(|fm| fm.get(key)) [INFO] [stdout] 24 | | .filter_map(|v| match v { [INFO] [stdout] ... | [INFO] [stdout] 34 | | }) [INFO] [stdout] 35 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route/frontmatter_file.rs:151:8 [INFO] [stdout] | [INFO] [stdout] 129 | let keeper = lock_keeper(files)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let headers = assign_headers(file, prev_file_name, next_file_name)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | [INFO] [stdout] 151 | Ok((headers, file.body().to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route/frontmatter_file.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 170 | let keeper = lock_keeper(files)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let headers = assign_headers(file, prev_file_name, next_file_name)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | [INFO] [stdout] 182 | Ok((headers, file.body().to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route/frontmatter_list.rs:91:8 [INFO] [stdout] | [INFO] [stdout] 81 | let keeper = lock_keeper(files)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | [INFO] [stdout] 83 | let mut files = keeper.files().cloned().map(Short::from).collect::>(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | let headers = assign_headers(files.len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | [INFO] [stdout] 89 | let files = paginate(params, files)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | [INFO] [stdout] 91 | Ok((headers, files)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route/frontmatter_list.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 108 | let keeper = lock_keeper(files)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let mut filtered_files = query_files(files, query, None, intersect) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | let headers = assign_headers(filtered_files.len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | [INFO] [stdout] 127 | let filtered_files = paginate(params, filtered_files)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | [INFO] [stdout] 129 | Ok((headers, filtered_files)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route/frontmatter_list.rs:120:21 [INFO] [stdout] | [INFO] [stdout] 120 | .map(|file| file.clone().into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `custard` (bin "custard") due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontmatter_file.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 131 | let md = FrontmatterFile { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | let frontmatter = serde_yaml::from_str(frontmatter) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(FrontmatterFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | name, [INFO] [stdout] 146 | | frontmatter: Some(frontmatter), [INFO] [stdout] 147 | | body: body.to_owned(), [INFO] [stdout] 148 | | modified, [INFO] [stdout] 149 | | created, [INFO] [stdout] 150 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontmatter_file/keeper.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 56 | let markdown_fps = fs::filepaths_with_extensions(path, &["md"])? [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(Keeper { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | inner: markdown_fps, [INFO] [stdout] 66 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontmatter_file/keeper.rs:61:20 [INFO] [stdout] | [INFO] [stdout] 59 | let md = FrontmatterFile::read_from_path(&path)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | [INFO] [stdout] 61 | Ok((path, md)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontmatter_file/keeper.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn new(keeper: Keeper) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Self(Arc::new(Mutex::new(keeper))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 13 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | / entry [INFO] [stdout] 15 | | .map(|entry| { [INFO] [stdout] 16 | | let path = entry.path().to_path_buf(); [INFO] [stdout] 17 | | if !path.is_file() { [INFO] [stdout] ... | [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/markup.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn yaml_to_json(yaml: T) -> U { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 4 | serde_json::from_value(serde_json::to_value(yaml).expect("valid yaml must map to valid json")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route/collate_strings.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 18 | files: impl Iterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | / files [INFO] [stdout] 22 | | .filter_map(|fmf| fmf.frontmatter()) [INFO] [stdout] 23 | | .filter_map(|fm| fm.get(key)) [INFO] [stdout] 24 | | .filter_map(|v| match v { [INFO] [stdout] ... | [INFO] [stdout] 34 | | }) [INFO] [stdout] 35 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route/frontmatter_file.rs:151:8 [INFO] [stdout] | [INFO] [stdout] 129 | let keeper = lock_keeper(files)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let headers = assign_headers(file, prev_file_name, next_file_name)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | [INFO] [stdout] 151 | Ok((headers, file.body().to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route/frontmatter_file.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 170 | let keeper = lock_keeper(files)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let headers = assign_headers(file, prev_file_name, next_file_name)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | [INFO] [stdout] 182 | Ok((headers, file.body().to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route/frontmatter_file.rs:279:23 [INFO] [stdout] | [INFO] [stdout] 243 | let mut hm = HashMap::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | let mut fm = Mapping::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | ArcMutex::new(Keeper { inner: hm }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route/frontmatter_list.rs:91:8 [INFO] [stdout] | [INFO] [stdout] 81 | let keeper = lock_keeper(files)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | [INFO] [stdout] 83 | let mut files = keeper.files().cloned().map(Short::from).collect::>(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | let headers = assign_headers(files.len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | [INFO] [stdout] 89 | let files = paginate(params, files)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | [INFO] [stdout] 91 | Ok((headers, files)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route/frontmatter_list.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 108 | let keeper = lock_keeper(files)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let mut filtered_files = query_files(files, query, None, intersect) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | let headers = assign_headers(filtered_files.len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | [INFO] [stdout] 127 | let filtered_files = paginate(params, filtered_files)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | [INFO] [stdout] 129 | Ok((headers, filtered_files)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route/frontmatter_list.rs:120:21 [INFO] [stdout] | [INFO] [stdout] 120 | .map(|file| file.clone().into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `custard` (bin "custard" test) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "cbb8ce4f5c043f7ee75a51bc32103235281afaab4727c7ab6ab5b34f30616ae9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbb8ce4f5c043f7ee75a51bc32103235281afaab4727c7ab6ab5b34f30616ae9", kill_on_drop: false }` [INFO] [stdout] cbb8ce4f5c043f7ee75a51bc32103235281afaab4727c7ab6ab5b34f30616ae9