[INFO] fetching crate curve25519-dalek-fiat 0.1.0... [INFO] checking curve25519-dalek-fiat-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate curve25519-dalek-fiat 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate curve25519-dalek-fiat 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate curve25519-dalek-fiat 0.1.0 [INFO] finished tweaking crates.io crate curve25519-dalek-fiat 0.1.0 [INFO] tweaked toml for crates.io crate curve25519-dalek-fiat 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 94 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding fiat-crypto v0.1.20 (latest: v0.2.9) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding libm v0.1.4 (latest: v0.2.8) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9c0bdb41f759e27d53235df671188e638b1c2146da71dd688e795c9edafb49e [INFO] running `Command { std: "docker" "start" "-a" "b9c0bdb41f759e27d53235df671188e638b1c2146da71dd688e795c9edafb49e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9c0bdb41f759e27d53235df671188e638b1c2146da71dd688e795c9edafb49e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9c0bdb41f759e27d53235df671188e638b1c2146da71dd688e795c9edafb49e", kill_on_drop: false }` [INFO] [stdout] b9c0bdb41f759e27d53235df671188e638b1c2146da71dd688e795c9edafb49e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2cf215fe02786b44b65150fafec6a527eadf38cf210166707e7c68b9eed16151 [INFO] running `Command { std: "docker" "start" "-a" "2cf215fe02786b44b65150fafec6a527eadf38cf210166707e7c68b9eed16151", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking curve25519-dalek-fiat v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stdout] warning: unused import: `backend::serial::u64::field::*` [INFO] [stdout] --> src/field.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | pub use backend::serial::u64::field::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `rustdoc` [INFO] [stdout] --> src/backend/mod.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | all(feature = "nightly", rustdoc) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(rustdoc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(rustdoc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ProjectivePoint` [INFO] [stdout] --> src/backend/serial/scalar_mul/variable_base.rs:6:59 [INFO] [stdout] | [INFO] [stdout] 6 | use backend::serial::curve_models::{ProjectiveNielsPoint, ProjectivePoint}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stdout] warning: trait `ValidityCheck` is never used [INFO] [stdout] --> src/traits.rs:375:18 [INFO] [stdout] | [INFO] [stdout] 375 | pub(crate) trait ValidityCheck { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/ristretto.rs:913:77 [INFO] [stdout] | [INFO] [stdout] 913 | let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.borrow().0)); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `RistrettoPoint` does not implement `Borrow`, so calling `borrow` on `&RistrettoPoint` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 913 - let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.borrow().0)); [INFO] [stdout] 913 + let extended_points = points.into_iter().map(|opt_P| opt_P.map(|P| P.0)); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `RistrettoPoint`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 438 + #[derive(Clone)] [INFO] [stdout] 439 | pub struct RistrettoPoint(pub(crate) EdwardsPoint); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ristretto.rs:937:17 [INFO] [stdout] | [INFO] [stdout] 930 | fn new(static_points: I) -> Self [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 937 | static_points.into_iter().map(|P| P.borrow().0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ristretto.rs:959:17 [INFO] [stdout] | [INFO] [stdout] 944 | static_scalars: I, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 945 | dynamic_scalars: J, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 946 | dynamic_points: K, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 959 | dynamic_points.into_iter().map(|P_opt| P_opt.map(|P| P.0)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 213 | fn vartime_multiscalar_mul(scalars: I, points: J) -> Self::Point [INFO] [stdout] | ---------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | / Self::optional_multiscalar_mul( [INFO] [stdout] 222 | | scalars, [INFO] [stdout] 223 | | points.into_iter().map(|P| Some(P.borrow().clone())), [INFO] [stdout] 224 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:223:45 [INFO] [stdout] | [INFO] [stdout] 223 | points.into_iter().map(|P| Some(P.borrow().clone())), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:325:9 [INFO] [stdout] | [INFO] [stdout] 313 | static_scalars: I, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | dynamic_scalars: J, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 315 | dynamic_points: K, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 325 | / Self::optional_mixed_multiscalar_mul( [INFO] [stdout] 326 | | self, [INFO] [stdout] 327 | | static_scalars, [INFO] [stdout] 328 | | dynamic_scalars, [INFO] [stdout] 329 | | dynamic_points.into_iter().map(|P| Some(P.borrow().clone())), [INFO] [stdout] 330 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:329:53 [INFO] [stdout] | [INFO] [stdout] 329 | dynamic_points.into_iter().map(|P| Some(P.borrow().clone())), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/serial/scalar_mul/precomputed_straus.rs:41:35 [INFO] [stdout] | [INFO] [stdout] 35 | fn new(static_points: I) -> Self [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | static_lookup_tables: static_points [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 42 | | .into_iter() [INFO] [stdout] 43 | | .map(|P| NafLookupTable8::::from(P.borrow())) [INFO] [stdout] | |_______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `curve25519-dalek-fiat` (lib) due to 8 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "2cf215fe02786b44b65150fafec6a527eadf38cf210166707e7c68b9eed16151", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cf215fe02786b44b65150fafec6a527eadf38cf210166707e7c68b9eed16151", kill_on_drop: false }` [INFO] [stdout] 2cf215fe02786b44b65150fafec6a527eadf38cf210166707e7c68b9eed16151