[INFO] fetching crate cursive 0.21.1... [INFO] checking cursive-0.21.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cursive 0.21.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate cursive 0.21.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cursive 0.21.1 [INFO] finished tweaking crates.io crate cursive 0.21.1 [INFO] tweaked toml for crates.io crate cursive 0.21.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate cursive 0.21.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b40a9f93fec6f909bd3a79d894ca0880eaf54d3132f5e4cba44227fb8b7c0cca [INFO] running `Command { std: "docker" "start" "-a" "b40a9f93fec6f909bd3a79d894ca0880eaf54d3132f5e4cba44227fb8b7c0cca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b40a9f93fec6f909bd3a79d894ca0880eaf54d3132f5e4cba44227fb8b7c0cca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b40a9f93fec6f909bd3a79d894ca0880eaf54d3132f5e4cba44227fb8b7c0cca", kill_on_drop: false }` [INFO] [stdout] b40a9f93fec6f909bd3a79d894ca0880eaf54d3132f5e4cba44227fb8b7c0cca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cf2c7fbda96ebc870c1dd9357eb0ab87be6c7e1e38dd4bfde8e612f733f8a1e9 [INFO] running `Command { std: "docker" "start" "-a" "cf2c7fbda96ebc870c1dd9357eb0ab87be6c7e1e38dd4bfde8e612f733f8a1e9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling serde_json v1.0.121 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling cursive-macros v0.1.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking pretty-bytes v0.2.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling zerocopy-derive v0.6.6 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking zerocopy v0.6.6 [INFO] [stderr] Checking ppv-lite86 v0.2.18 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling enumset_derive v0.10.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking enumset v1.1.5 [INFO] [stderr] Checking cursive_core v0.4.2 [INFO] [stderr] Checking cursive v0.21.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends/crossterm.rs:230:12 [INFO] [stdout] | [INFO] [stdout] 217 | fn init_with_stdout(mut stdout: Stdout) -> Result, std::io::Error> [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | Ok(Box::new(Backend { [INFO] [stdout] | ____________^ [INFO] [stdout] 231 | | current_style: Cell::new(theme::ColorPair::from_256colors(0, 0)), [INFO] [stdout] 232 | | stdout: RefCell::new(BufWriter::new(stdout)), [INFO] [stdout] 233 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends/crossterm.rs:352:35 [INFO] [stdout] | [INFO] [stdout] 352 | self.with_stdout(|stdout| stdout.flush().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends/puppet/mod.rs:135:23 [INFO] [stdout] | [INFO] [stdout] 133 | let mut screen = self.current_frame.borrow_mut(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | cloned_style.colors.back = clear_color; [INFO] [stdout] 135 | screen.clear(&Arc::new(cloned_style)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cursive_runnable.rs:79:32 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(mut backend_init: F) -> Self [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Self::with_initializer(Box::new(move || backend_init().map_err(boxed))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cursive_runnable.rs:79:49 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(mut backend_init: F) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Self::with_initializer(Box::new(move || backend_init().map_err(boxed))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cursive_runnable.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn try_into_runner(mut self) -> Result, Box> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let backend = (self.backend_init)()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | Ok(CursiveRunner::new(self, backend)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cursive_runnable.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn into_runner(self) -> CursiveRunner { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | self.try_into_runner().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cursive_runnable.rs:150:56 [INFO] [stdout] | [INFO] [stdout] 150 | Self::new::(|| Ok(cursive_core::backend::Dummy::init())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends/crossterm.rs:230:12 [INFO] [stdout] | [INFO] [stdout] 217 | fn init_with_stdout(mut stdout: Stdout) -> Result, std::io::Error> [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | Ok(Box::new(Backend { [INFO] [stdout] | ____________^ [INFO] [stdout] 231 | | current_style: Cell::new(theme::ColorPair::from_256colors(0, 0)), [INFO] [stdout] 232 | | stdout: RefCell::new(BufWriter::new(stdout)), [INFO] [stdout] 233 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends/crossterm.rs:352:35 [INFO] [stdout] | [INFO] [stdout] 352 | self.with_stdout(|stdout| stdout.flush().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends/puppet/mod.rs:135:23 [INFO] [stdout] | [INFO] [stdout] 133 | let mut screen = self.current_frame.borrow_mut(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | cloned_style.colors.back = clear_color; [INFO] [stdout] 135 | screen.clear(&Arc::new(cloned_style)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cursive_runnable.rs:79:32 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(mut backend_init: F) -> Self [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Self::with_initializer(Box::new(move || backend_init().map_err(boxed))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cursive_runnable.rs:79:49 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(mut backend_init: F) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Self::with_initializer(Box::new(move || backend_init().map_err(boxed))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cursive` (lib) due to 9 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cursive_runnable.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn try_into_runner(mut self) -> Result, Box> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let backend = (self.backend_init)()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | Ok(CursiveRunner::new(self, backend)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cursive_runnable.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn into_runner(self) -> CursiveRunner { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | self.try_into_runner().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cursive_runnable.rs:150:56 [INFO] [stdout] | [INFO] [stdout] 150 | Self::new::(|| Ok(cursive_core::backend::Dummy::init())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cursive` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "cf2c7fbda96ebc870c1dd9357eb0ab87be6c7e1e38dd4bfde8e612f733f8a1e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf2c7fbda96ebc870c1dd9357eb0ab87be6c7e1e38dd4bfde8e612f733f8a1e9", kill_on_drop: false }` [INFO] [stdout] cf2c7fbda96ebc870c1dd9357eb0ab87be6c7e1e38dd4bfde8e612f733f8a1e9