[INFO] fetching crate currant 0.2.8... [INFO] checking currant-0.2.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate currant 0.2.8 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate currant 0.2.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate currant 0.2.8 [INFO] finished tweaking crates.io crate currant 0.2.8 [INFO] tweaked toml for crates.io crate currant 0.2.8 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate currant 0.2.8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f188727238f8e83ea0d19b2bf54183a0a1141568974469dc8346ab7cb2c964e3 [INFO] running `Command { std: "docker" "start" "-a" "f188727238f8e83ea0d19b2bf54183a0a1141568974469dc8346ab7cb2c964e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f188727238f8e83ea0d19b2bf54183a0a1141568974469dc8346ab7cb2c964e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f188727238f8e83ea0d19b2bf54183a0a1141568974469dc8346ab7cb2c964e3", kill_on_drop: false }` [INFO] [stdout] f188727238f8e83ea0d19b2bf54183a0a1141568974469dc8346ab7cb2c964e3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 05228e1a0284e35e13b8574abc201bc78f524b0611275eeb07af74dfab5512b6 [INFO] running `Command { std: "docker" "start" "-a" "05228e1a0284e35e13b8574abc201bc78f524b0611275eeb07af74dfab5512b6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking nix v0.24.1 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking currant v0.2.8 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 128 | name: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | command: C, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | args: Cmds, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | cur_dir: Option, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | Ok(Self::insert_command(InnerCommand { [INFO] [stdout] | ____________^ [INFO] [stdout] 150 | | name, [INFO] [stdout] 151 | | command: cmd, [INFO] [stdout] 152 | | args: converted_args, [INFO] [stdout] 153 | | cur_dir: dir, [INFO] [stdout] 154 | | env: HashMap::new(), [INFO] [stdout] 155 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:12 [INFO] [stdout] | [INFO] [stdout] 176 | name: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | command_string: C, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | cur_dir: Option, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | Ok(Self::insert_command(InnerCommand { [INFO] [stdout] | ____________^ [INFO] [stdout] 190 | | name: name.into(), [INFO] [stdout] 191 | | command, [INFO] [stdout] 192 | | args, [INFO] [stdout] 193 | | cur_dir: dir, [INFO] [stdout] 194 | | env: HashMap::new(), [INFO] [stdout] 195 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:260:9 [INFO] [stdout] | [INFO] [stdout] 259 | pub fn join(self) -> Result, String> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | / self.handle [INFO] [stdout] 261 | | .join() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:318:9 [INFO] [stdout] | [INFO] [stdout] 314 | pub fn join(self) -> Result, String> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | / self.handle [INFO] [stdout] 319 | | .join() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 128 | name: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | command: C, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | args: Cmds, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | cur_dir: Option, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | Ok(Self::insert_command(InnerCommand { [INFO] [stdout] | ____________^ [INFO] [stdout] 150 | | name, [INFO] [stdout] 151 | | command: cmd, [INFO] [stdout] 152 | | args: converted_args, [INFO] [stdout] 153 | | cur_dir: dir, [INFO] [stdout] 154 | | env: HashMap::new(), [INFO] [stdout] 155 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:12 [INFO] [stdout] | [INFO] [stdout] 176 | name: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | command_string: C, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | cur_dir: Option, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | Ok(Self::insert_command(InnerCommand { [INFO] [stdout] | ____________^ [INFO] [stdout] 190 | | name: name.into(), [INFO] [stdout] 191 | | command, [INFO] [stdout] 192 | | args, [INFO] [stdout] 193 | | cur_dir: dir, [INFO] [stdout] 194 | | env: HashMap::new(), [INFO] [stdout] 195 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:260:9 [INFO] [stdout] | [INFO] [stdout] 259 | pub fn join(self) -> Result, String> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | / self.handle [INFO] [stdout] 261 | | .join() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:318:9 [INFO] [stdout] | [INFO] [stdout] 314 | pub fn join(self) -> Result, String> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | / self.handle [INFO] [stdout] 319 | | .join() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:74:19 [INFO] [stdout] | [INFO] [stdout] 65 | send_chan: mpsc::Sender, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | options: Options, [INFO] [stdout] 67 | kill_trigger: kill_barrier::KillBarrier, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let mut command_process: process::Command = command.into(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let pid_lock = pid_lock.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | [INFO] [stdout] 74 | thread::spawn(move || loop { [INFO] [stdout] | ___________________^ [INFO] [stdout] 75 | | let current_pid = pid_lock.1.lock(); [INFO] [stdout] 76 | | let _ = send_chan.send(OutputMessage { [INFO] [stdout] 77 | | name: command_name.clone(), [INFO] [stdout] ... | [INFO] [stdout] 172 | | } [INFO] [stdout] 173 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:74:19 [INFO] [stdout] | [INFO] [stdout] 65 | send_chan: mpsc::Sender, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | options: Options, [INFO] [stdout] 67 | kill_trigger: kill_barrier::KillBarrier, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let mut command_process: process::Command = command.into(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let pid_lock = pid_lock.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | [INFO] [stdout] 74 | thread::spawn(move || loop { [INFO] [stdout] | ___________________^ [INFO] [stdout] 75 | | let current_pid = pid_lock.1.lock(); [INFO] [stdout] 76 | | let _ = send_chan.send(OutputMessage { [INFO] [stdout] 77 | | name: command_name.clone(), [INFO] [stdout] ... | [INFO] [stdout] 172 | | } [INFO] [stdout] 173 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `currant` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `currant` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "05228e1a0284e35e13b8574abc201bc78f524b0611275eeb07af74dfab5512b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05228e1a0284e35e13b8574abc201bc78f524b0611275eeb07af74dfab5512b6", kill_on_drop: false }` [INFO] [stdout] 05228e1a0284e35e13b8574abc201bc78f524b0611275eeb07af74dfab5512b6