[INFO] fetching crate cura 0.8.0... [INFO] checking cura-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cura 0.8.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate cura 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cura 0.8.0 [INFO] finished tweaking crates.io crate cura 0.8.0 [INFO] tweaked toml for crates.io crate cura 0.8.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b1289b01bcf3a99b9f60be46d0d9677004dbf753984ccf315dd07f2b82127cc5 [INFO] running `Command { std: "docker" "start" "-a" "b1289b01bcf3a99b9f60be46d0d9677004dbf753984ccf315dd07f2b82127cc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b1289b01bcf3a99b9f60be46d0d9677004dbf753984ccf315dd07f2b82127cc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b1289b01bcf3a99b9f60be46d0d9677004dbf753984ccf315dd07f2b82127cc5", kill_on_drop: false }` [INFO] [stdout] b1289b01bcf3a99b9f60be46d0d9677004dbf753984ccf315dd07f2b82127cc5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] edc32beed6fc7e9710a1e65311ed897336da97415b84fbae77f5fd52e8f3e70e [INFO] running `Command { std: "docker" "start" "-a" "edc32beed6fc7e9710a1e65311ed897336da97415b84fbae77f5fd52e8f3e70e", kill_on_drop: false }` [INFO] [stderr] Checking cura v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/lib.rs:849:26 [INFO] [stdout] | [INFO] [stdout] 849 | impl Foo for FF{}; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `current_time` is never used [INFO] [stdout] --> src/lib.rs:626:4 [INFO] [stdout] | [INFO] [stdout] 626 | fn current_time()->u128{ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `sleep` is never used [INFO] [stdout] --> src/lib.rs:635:4 [INFO] [stdout] | [INFO] [stdout] 635 | fn sleep(millis:u32){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:177:24 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn new(t: T) -> Cura { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | Self::from_box(Box::new(t)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:193:42 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn from_box(v: Box) -> Cura { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | ptr: NonNull::from(Box::leak(Box::new(CuraData { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 194 | | count: AtomicUsize::new(1), [INFO] [stdout] 195 | | data: UnsafeCell::new(v), [INFO] [stdout] 196 | | lockcount:AtomicI32::new(0), [INFO] [stdout] 197 | | queuecount:AtomicU32::new(0), // [INFO] [stdout] 198 | | queuedata:queuedata, [INFO] [stdout] 199 | | }))), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cura` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/lib.rs:781:13 [INFO] [stdout] | [INFO] [stdout] 781 | let f=Bar{tt:tt}; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/lib.rs:754:20 [INFO] [stdout] | [INFO] [stdout] 754 | fn test(t:T) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `current_time` is never used [INFO] [stdout] --> src/lib.rs:626:4 [INFO] [stdout] | [INFO] [stdout] 626 | fn current_time()->u128{ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/lib.rs:684:13 [INFO] [stdout] | [INFO] [stdout] 683 | struct Foo{ [INFO] [stdout] | --- field in this struct [INFO] [stdout] 684 | id:u16, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `testing` and `id` are never used [INFO] [stdout] --> src/lib.rs:690:20 [INFO] [stdout] | [INFO] [stdout] 686 | impl Foo { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 690 | pub fn testing(&mut self,id:u16) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 693 | pub fn id(&self)->u16 [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `EE` is never used [INFO] [stdout] --> src/lib.rs:759:14 [INFO] [stdout] | [INFO] [stdout] 759 | enum EE [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get` is never used [INFO] [stdout] --> src/lib.rs:766:16 [INFO] [stdout] | [INFO] [stdout] 764 | trait Foo:Send+Sync [INFO] [stdout] | --- method in this trait [INFO] [stdout] 765 | { [INFO] [stdout] 766 | fn get(&self)->EE [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `tt` is never read [INFO] [stdout] --> src/lib.rs:779:13 [INFO] [stdout] | [INFO] [stdout] 777 | struct Bar [INFO] [stdout] | --- field in this struct [INFO] [stdout] 778 | { [INFO] [stdout] 779 | tt:Cura, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Bong` is never constructed [INFO] [stdout] --> src/lib.rs:817:13 [INFO] [stdout] | [INFO] [stdout] 814 | enum Foo [INFO] [stdout] | --- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 817 | Bong, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Foo` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Bong` is never constructed [INFO] [stdout] --> src/lib.rs:839:13 [INFO] [stdout] | [INFO] [stdout] 836 | enum EE [INFO] [stdout] | -- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 839 | Bong, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EE` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:177:24 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn new(t: T) -> Cura { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | Self::from_box(Box::new(t)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:193:42 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn from_box(v: Box) -> Cura { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | ptr: NonNull::from(Box::leak(Box::new(CuraData { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 194 | | count: AtomicUsize::new(1), [INFO] [stdout] 195 | | data: UnsafeCell::new(v), [INFO] [stdout] 196 | | lockcount:AtomicI32::new(0), [INFO] [stdout] 197 | | queuecount:AtomicU32::new(0), // [INFO] [stdout] 198 | | queuedata:queuedata, [INFO] [stdout] 199 | | }))), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cura` (lib test) due to 3 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "edc32beed6fc7e9710a1e65311ed897336da97415b84fbae77f5fd52e8f3e70e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "edc32beed6fc7e9710a1e65311ed897336da97415b84fbae77f5fd52e8f3e70e", kill_on_drop: false }` [INFO] [stdout] edc32beed6fc7e9710a1e65311ed897336da97415b84fbae77f5fd52e8f3e70e