[INFO] fetching crate cubik 0.1.0... [INFO] checking cubik-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cubik 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cubik 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cubik 0.1.0 [INFO] finished tweaking crates.io crate cubik 0.1.0 [INFO] tweaked toml for crates.io crate cubik 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate cubik 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7640fae6d7e7ba982b26c01e0e90b5b6fe96dd59eb601f91627a8be79f7e8630 [INFO] running `Command { std: "docker" "start" "-a" "7640fae6d7e7ba982b26c01e0e90b5b6fe96dd59eb601f91627a8be79f7e8630", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7640fae6d7e7ba982b26c01e0e90b5b6fe96dd59eb601f91627a8be79f7e8630", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7640fae6d7e7ba982b26c01e0e90b5b6fe96dd59eb601f91627a8be79f7e8630", kill_on_drop: false }` [INFO] [stdout] 7640fae6d7e7ba982b26c01e0e90b5b6fe96dd59eb601f91627a8be79f7e8630 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad87a9f0b5ab9db8989acf563646d79f9f79e844dfd090c4b68da929fb4da835 [INFO] running `Command { std: "docker" "start" "-a" "ad87a9f0b5ab9db8989acf563646d79f9f79e844dfd090c4b68da929fb4da835", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling xml-rs v0.8.3 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Checking libloading v0.6.6 [INFO] [stderr] Compiling syn v1.0.56 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking smallvec v1.5.1 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.2 [INFO] [stderr] Checking ttf-parser v0.6.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.4 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Compiling memoffset v0.6.1 [INFO] [stderr] Compiling miniz_oxide v0.4.3 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling nom v6.0.1 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Compiling wayland-sys v0.28.2 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.118 [INFO] [stderr] Compiling nix v0.15.0 [INFO] [stderr] Compiling cc v1.0.66 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Compiling winit v0.25.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking owned_ttf_parser v0.6.0 [INFO] [stderr] Compiling serde v1.0.118 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Compiling wayland-scanner v0.28.2 [INFO] [stderr] Checking rusttype v0.9.2 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Checking gimli v0.23.0 [INFO] [stderr] Compiling cpal v0.13.1 [INFO] [stderr] Compiling glutin_egl_sys v0.1.5 [INFO] [stderr] Compiling glutin_glx_sys v0.1.7 [INFO] [stderr] Checking crossbeam v0.8.1 [INFO] [stderr] Checking andrew v0.3.1 [INFO] [stderr] Checking weezl v0.1.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking memmap2 v0.1.0 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking parking_lot_core v0.8.2 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking xcursor v0.3.3 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking mio-misc v1.2.1 [INFO] [stderr] Checking slice-deque v0.3.0 [INFO] [stderr] Compiling glium v0.30.2 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Compiling minimp3-sys v0.3.2 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking ogg v0.7.1 [INFO] [stderr] Checking libloading v0.7.1 [INFO] [stderr] Checking rustc-demangle v0.1.18 [INFO] [stderr] Checking object v0.22.0 [INFO] [stderr] Checking tinyvec v0.3.4 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Compiling wayland-client v0.28.2 [INFO] [stderr] Compiling wayland-protocols v0.28.2 [INFO] [stderr] Checking gif v0.11.1 [INFO] [stderr] Checking lewton v0.10.1 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking takeable-option v0.5.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking minimp3 v0.5.0 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking bytemuck v1.4.1 [INFO] [stderr] Checking addr2line v0.14.0 [INFO] [stderr] Checking alsa v0.4.3 [INFO] [stderr] Checking jpeg-decoder v0.1.20 [INFO] [stderr] Checking backtrace v0.3.55 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking wayland-commons v0.28.2 [INFO] [stderr] Checking calloop v0.6.5 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling derive_more v0.99.11 [INFO] [stderr] Checking image v0.23.12 [INFO] [stderr] Checking wayland-cursor v0.28.2 [INFO] [stderr] Checking wayland-egl v0.28.2 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking rodio v0.14.0 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking bincode v1.3.1 [INFO] [stderr] Checking smithay-client-toolkit v0.12.3 [INFO] [stderr] Checking glutin v0.27.0 [INFO] [stderr] Checking cubik v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/textures.rs:19:25 [INFO] [stdout] | [INFO] [stdout] 19 | let f = File::open(path.clone())?; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 19 - let f = File::open(path.clone())?; [INFO] [stdout] 19 + let f = File::open(path)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/textures.rs:22:63 [INFO] [stdout] | [INFO] [stdout] 22 | let image = image::load(f, image::ImageFormat::from_path(path.clone())?)?.to_rgba8(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 22 - let image = image::load(f, image::ImageFormat::from_path(path.clone())?)?.to_rgba8(); [INFO] [stdout] 22 + let image = image::load(f, image::ImageFormat::from_path(path)?)?.to_rgba8(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/textures.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | Ok(Texture2d::new(display, raw_image)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/textures.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | Ok(SrgbTexture2d::new(display, raw_image)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/player.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | #[derive(Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 36 | let file = File::open(find_asset(filename, app_id))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | [INFO] [stdout] 39 | Ok(Decoder::new(reader)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 48 | let file = File::open(find_asset(filename, app_id))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Ok(Decoder::new_looped(reader)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 59 | let decoded = bincode::deserialize::>(&buffer[4..(msg_size + 4)])?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Some(decoded)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:35:6 [INFO] [stdout] | [INFO] [stdout] 33 | let listener = TcpListener::bind(SocketAddr::from(([0, 0, 0, 0], port)))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | listener.set_nonblocking(true)?; [INFO] [stdout] 35 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | listener: listener, [INFO] [stdout] 37 | | connections: HashMap::new(), [INFO] [stdout] 38 | | next_player_id: 1, [INFO] [stdout] 39 | | max_players: max_players [INFO] [stdout] 40 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:157:37 [INFO] [stdout] | [INFO] [stdout] 156 | pub fn send_to(&mut self, player_id: u8, message: M) -> Result<(), ServerError> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | self.send_to_internal(player_id, &CommMessage::App(message)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:39:6 [INFO] [stdout] | [INFO] [stdout] 35 | let stream = TcpStream::connect_timeout(&addr, Duration::new(5, 0))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 40 | | stream: stream, [INFO] [stdout] 41 | | peers: HashMap::new(), [INFO] [stdout] 42 | | incoming_msgs: Vec::new(), [INFO] [stdout] 43 | | buffer: Vec::new(), [INFO] [stdout] 44 | | player_id: None [INFO] [stdout] 45 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/textures.rs:19:25 [INFO] [stdout] | [INFO] [stdout] 19 | let f = File::open(path.clone())?; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 19 - let f = File::open(path.clone())?; [INFO] [stdout] 19 + let f = File::open(path)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/textures.rs:22:63 [INFO] [stdout] | [INFO] [stdout] 22 | let image = image::load(f, image::ImageFormat::from_path(path.clone())?)?.to_rgba8(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 22 - let image = image::load(f, image::ImageFormat::from_path(path.clone())?)?.to_rgba8(); [INFO] [stdout] 22 + let image = image::load(f, image::ImageFormat::from_path(path)?)?.to_rgba8(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/textures.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | Ok(Texture2d::new(display, raw_image)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/textures.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | Ok(SrgbTexture2d::new(display, raw_image)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/player.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | #[derive(Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 36 | let file = File::open(find_asset(filename, app_id))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | [INFO] [stdout] 39 | Ok(Decoder::new(reader)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 48 | let file = File::open(find_asset(filename, app_id))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Ok(Decoder::new_looped(reader)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 59 | let decoded = bincode::deserialize::>(&buffer[4..(msg_size + 4)])?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Some(decoded)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:35:6 [INFO] [stdout] | [INFO] [stdout] 33 | let listener = TcpListener::bind(SocketAddr::from(([0, 0, 0, 0], port)))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | listener.set_nonblocking(true)?; [INFO] [stdout] 35 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | listener: listener, [INFO] [stdout] 37 | | connections: HashMap::new(), [INFO] [stdout] 38 | | next_player_id: 1, [INFO] [stdout] 39 | | max_players: max_players [INFO] [stdout] 40 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:157:37 [INFO] [stdout] | [INFO] [stdout] 156 | pub fn send_to(&mut self, player_id: u8, message: M) -> Result<(), ServerError> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | self.send_to_internal(player_id, &CommMessage::App(message)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:39:6 [INFO] [stdout] | [INFO] [stdout] 35 | let stream = TcpStream::connect_timeout(&addr, Duration::new(5, 0))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 40 | | stream: stream, [INFO] [stdout] 41 | | peers: HashMap::new(), [INFO] [stdout] 42 | | incoming_msgs: Vec::new(), [INFO] [stdout] 43 | | buffer: Vec::new(), [INFO] [stdout] 44 | | player_id: None [INFO] [stdout] 45 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cubik` (lib) due to 11 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 10 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cubik` (lib test) due to 11 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ad87a9f0b5ab9db8989acf563646d79f9f79e844dfd090c4b68da929fb4da835", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad87a9f0b5ab9db8989acf563646d79f9f79e844dfd090c4b68da929fb4da835", kill_on_drop: false }` [INFO] [stdout] ad87a9f0b5ab9db8989acf563646d79f9f79e844dfd090c4b68da929fb4da835