[INFO] fetching crate ctrader-fix 0.5.3... [INFO] checking ctrader-fix-0.5.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ctrader-fix 0.5.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate ctrader-fix 0.5.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ctrader-fix 0.5.3 [INFO] finished tweaking crates.io crate ctrader-fix 0.5.3 [INFO] tweaked toml for crates.io crate ctrader-fix 0.5.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate ctrader-fix 0.5.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 221c4cf3904f31d7921f66f54523011bfaca10fe3f42f08f920924ddb2a8b554 [INFO] running `Command { std: "docker" "start" "-a" "221c4cf3904f31d7921f66f54523011bfaca10fe3f42f08f920924ddb2a8b554", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "221c4cf3904f31d7921f66f54523011bfaca10fe3f42f08f920924ddb2a8b554", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "221c4cf3904f31d7921f66f54523011bfaca10fe3f42f08f920924ddb2a8b554", kill_on_drop: false }` [INFO] [stdout] 221c4cf3904f31d7921f66f54523011bfaca10fe3f42f08f920924ddb2a8b554 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4ea75ee2eb642d8dedd9be0d0d6ec6945cb35e2bc0f31924b76253393721337e [INFO] running `Command { std: "docker" "start" "-a" "4ea75ee2eb642d8dedd9be0d0d6ec6945cb35e2bc0f31924b76253393721337e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.144 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling unicode-ident v1.0.8 [INFO] [stderr] Compiling quote v1.0.27 [INFO] [stderr] Checking value-bag v1.8.1 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Checking parking v2.1.0 [INFO] [stderr] Checking waker-fn v1.1.0 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling io-lifetimes v1.0.10 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking async-lock v2.7.0 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking concurrent-queue v2.2.0 [INFO] [stderr] Compiling rustix v0.37.19 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking linux-raw-sys v0.3.7 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Compiling signal-hook v0.3.15 [INFO] [stderr] Compiling serde v1.0.163 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Compiling winnow v0.4.6 [INFO] [stderr] Checking async-task v4.4.0 [INFO] [stderr] Compiling toml_datetime v0.6.1 [INFO] [stderr] Checking async-channel v1.8.0 [INFO] [stderr] Compiling async-process v1.7.0 [INFO] [stderr] Checking atomic-waker v1.1.1 [INFO] [stderr] Compiling once_cell v1.17.1 [INFO] [stderr] Checking aho-corasick v1.0.1 [INFO] [stderr] Compiling thiserror v1.0.40 [INFO] [stderr] Compiling serde_json v1.0.96 [INFO] [stderr] Compiling async-trait v0.1.68 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking regex-syntax v0.7.1 [INFO] [stderr] Checking num-integer v0.1.45 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Checking iana-time-zone v0.1.56 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking async-macros v2.0.0 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking getrandom v0.2.9 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking async-executor v1.5.1 [INFO] [stderr] Checking blocking v1.3.1 [INFO] [stderr] Compiling syn v2.0.16 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking regex v1.8.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling toml_edit v0.19.8 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking uuid v1.3.3 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking async-global-executor v2.3.1 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Compiling serde_derive v1.0.163 [INFO] [stderr] Compiling num_enum_derive v0.7.2 [INFO] [stderr] Compiling thiserror-impl v1.0.40 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking num_enum v0.7.2 [INFO] [stderr] Checking chrono v0.4.24 [INFO] [stderr] Checking ctrader-fix v0.5.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fixapi.rs:244:39 [INFO] [stdout] | [INFO] [stdout] 217 | let send_request = move |req: Box| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | let stream = stream.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | let seq = seq.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | let msg_buffer = msg_buffer.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let is_connected = is_connected.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let handler = handler.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | let handler = handler.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | match writer.flush().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_func.rs:180:20 [INFO] [stdout] | [INFO] [stdout] 180 | .map(|res| parse_execution_report(res).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trade_client.rs:72:23 [INFO] [stdout] | [INFO] [stdout] 70 | let (tx, rx) = bounded(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Self { [INFO] [stdout] 72 | internal: FixApi::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 73 | | crate::types::SubID::TRADE, [INFO] [stdout] 74 | | host, [INFO] [stdout] 75 | | login, [INFO] [stdout] ... | [INFO] [stdout] 78 | | heartbeat_interval, [INFO] [stdout] 79 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trade_client.rs:80:33 [INFO] [stdout] | [INFO] [stdout] 70 | let (tx, rx) = bounded(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | trade_data_handler: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trade_client.rs:81:20 [INFO] [stdout] | [INFO] [stdout] 70 | let (tx, rx) = bounded(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | queue: Arc::new(RwLock::new(VecDeque::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ctrader-fix` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fixapi.rs:244:39 [INFO] [stdout] | [INFO] [stdout] 217 | let send_request = move |req: Box| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | let stream = stream.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | let seq = seq.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | let msg_buffer = msg_buffer.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let is_connected = is_connected.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let handler = handler.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | let handler = handler.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | match writer.flush().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_func.rs:180:20 [INFO] [stdout] | [INFO] [stdout] 180 | .map(|res| parse_execution_report(res).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trade_client.rs:72:23 [INFO] [stdout] | [INFO] [stdout] 70 | let (tx, rx) = bounded(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Self { [INFO] [stdout] 72 | internal: FixApi::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 73 | | crate::types::SubID::TRADE, [INFO] [stdout] 74 | | host, [INFO] [stdout] 75 | | login, [INFO] [stdout] ... | [INFO] [stdout] 78 | | heartbeat_interval, [INFO] [stdout] 79 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trade_client.rs:80:33 [INFO] [stdout] | [INFO] [stdout] 70 | let (tx, rx) = bounded(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | trade_data_handler: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trade_client.rs:81:20 [INFO] [stdout] | [INFO] [stdout] 70 | let (tx, rx) = bounded(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | queue: Arc::new(RwLock::new(VecDeque::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ctrader-fix` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "4ea75ee2eb642d8dedd9be0d0d6ec6945cb35e2bc0f31924b76253393721337e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ea75ee2eb642d8dedd9be0d0d6ec6945cb35e2bc0f31924b76253393721337e", kill_on_drop: false }` [INFO] [stdout] 4ea75ee2eb642d8dedd9be0d0d6ec6945cb35e2bc0f31924b76253393721337e