[INFO] fetching crate ctaphid 0.3.1... [INFO] checking ctaphid-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ctaphid 0.3.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ctaphid 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ctaphid 0.3.1 [INFO] finished tweaking crates.io crate ctaphid 0.3.1 [INFO] tweaked toml for crates.io crate ctaphid 0.3.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate ctaphid 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e5e5c949f14e37179b2507e4c5c4a959830208fc2c920ec3aa5dd547dcb6f0a7 [INFO] running `Command { std: "docker" "start" "-a" "e5e5c949f14e37179b2507e4c5c4a959830208fc2c920ec3aa5dd547dcb6f0a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e5e5c949f14e37179b2507e4c5c4a959830208fc2c920ec3aa5dd547dcb6f0a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5e5c949f14e37179b2507e4c5c4a959830208fc2c920ec3aa5dd547dcb6f0a7", kill_on_drop: false }` [INFO] [stdout] e5e5c949f14e37179b2507e4c5c4a959830208fc2c920ec3aa5dd547dcb6f0a7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 293f386d8df87998a9bc78e9caee2e8a8b2b95d595afcbc2a2eea04565ca67a6 [INFO] running `Command { std: "docker" "start" "-a" "293f386d8df87998a9bc78e9caee2e8a8b2b95d595afcbc2a2eea04565ca67a6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling serde v1.0.140 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking ctaphid-types v0.2.0 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling hidapi v1.4.1 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking ctaphid v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/error.rs:22:38 [INFO] [stdout] | [INFO] [stdout] 22 | fn source(&self) -> Option<&(dyn std::error::Error + 'static)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | unused_qualifications [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 22 - fn source(&self) -> Option<&(dyn std::error::Error + 'static)> { [INFO] [stdout] 22 + fn source(&self) -> Option<&(dyn error::Error + 'static)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/error.rs:95:33 [INFO] [stdout] | [INFO] [stdout] 95 | PacketSendingFailed(Box), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 95 - PacketSendingFailed(Box), [INFO] [stdout] 95 + PacketSendingFailed(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/error.rs:101:38 [INFO] [stdout] | [INFO] [stdout] 101 | fn source(&self) -> Option<&(dyn std::error::Error + 'static)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 101 - fn source(&self) -> Option<&(dyn std::error::Error + 'static)> { [INFO] [stdout] 101 + fn source(&self) -> Option<&(dyn error::Error + 'static)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/error.rs:135:35 [INFO] [stdout] | [INFO] [stdout] 135 | PacketReceivingFailed(Box), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 135 - PacketReceivingFailed(Box), [INFO] [stdout] 135 + PacketReceivingFailed(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/error.rs:155:38 [INFO] [stdout] | [INFO] [stdout] 155 | fn source(&self) -> Option<&(dyn std::error::Error + 'static)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 155 - fn source(&self) -> Option<&(dyn std::error::Error + 'static)> { [INFO] [stdout] 155 + fn source(&self) -> Option<&(dyn error::Error + 'static)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hid.rs:38:62 [INFO] [stdout] | [INFO] [stdout] 38 | .map_err(|err| RequestError::PacketSendingFailed(err.into()))?; [INFO] [stdout] | --- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hid.rs:53:69 [INFO] [stdout] | [INFO] [stdout] 53 | .map_err(|err| ResponseError::PacketReceivingFailed(err.into()))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hid.rs:59:65 [INFO] [stdout] | [INFO] [stdout] 59 | .map_err(|err| ResponseError::PacketReceivingFailed(err.into()))?; [INFO] [stdout] | --- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ctaphid` (lib) due to 4 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "293f386d8df87998a9bc78e9caee2e8a8b2b95d595afcbc2a2eea04565ca67a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "293f386d8df87998a9bc78e9caee2e8a8b2b95d595afcbc2a2eea04565ca67a6", kill_on_drop: false }` [INFO] [stdout] 293f386d8df87998a9bc78e9caee2e8a8b2b95d595afcbc2a2eea04565ca67a6