[INFO] fetching crate csview 1.3.3... [INFO] checking csview-1.3.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate csview 1.3.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate csview 1.3.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate csview 1.3.3 [INFO] finished tweaking crates.io crate csview 1.3.3 [INFO] tweaked toml for crates.io crate csview 1.3.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate csview 1.3.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 874e22ab3e074eba295ff9ee79dc571f4e1d306ca412640d4746b74c7bf20c64 [INFO] running `Command { std: "docker" "start" "-a" "874e22ab3e074eba295ff9ee79dc571f4e1d306ca412640d4746b74c7bf20c64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "874e22ab3e074eba295ff9ee79dc571f4e1d306ca412640d4746b74c7bf20c64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "874e22ab3e074eba295ff9ee79dc571f4e1d306ca412640d4746b74c7bf20c64", kill_on_drop: false }` [INFO] [stdout] 874e22ab3e074eba295ff9ee79dc571f4e1d306ca412640d4746b74c7bf20c64 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 017f5f09a7c99b228669b3765f84b8aa2c40a5397d4763822a656816c9ad7b52 [INFO] running `Command { std: "docker" "start" "-a" "017f5f09a7c99b228669b3765f84b8aa2c40a5397d4763822a656816c9ad7b52", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Compiling proc-macro2 v1.0.80 [INFO] [stderr] Compiling utf8parse v0.2.1 [INFO] [stderr] Compiling linux-raw-sys v0.4.13 [INFO] [stderr] Compiling bitflags v2.5.0 [INFO] [stderr] Compiling anstyle-query v1.0.2 [INFO] [stderr] Compiling colorchoice v1.0.0 [INFO] [stderr] Compiling anstyle v1.0.6 [INFO] [stderr] Compiling clap_lex v0.7.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking exitcode v1.1.2 [INFO] [stderr] Compiling anstream v0.6.13 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Compiling syn v2.0.59 [INFO] [stderr] Compiling clap_builder v4.5.8 [INFO] [stderr] Checking unicode-truncate v1.0.0 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking pager v0.16.1 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Compiling clap v4.5.8 [INFO] [stderr] Compiling clap_complete v4.5.7 [INFO] [stderr] Compiling csview v1.3.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/printer.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) fn new(mut rdr: Reader, sniff_rows: usize, with_seq: bool) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let header = rdr.has_headers().then(|| rdr.headers()).transpose()?.cloned(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let (widths, buf) = sniff_widths(&mut rdr, header.as_ref(), sniff_rows, with_seq)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let records = Box::new(buf.into_iter().map(Ok).chain(rdr.into_records())); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Ok(Self { header, widths, records, with_seq }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/printer.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 70 | let mut buf = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let mut record = header.cloned().unwrap_or_default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok((widths, buf)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/row.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 15 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Self { cells: iter.into_iter().collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/style.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 222 | pub fn clear_seps(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | self.col_seps(None, None, None).row_seps(None, None, None, None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 15 | let builder = match style { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / builder [INFO] [stdout] 59 | | .padding(padding) [INFO] [stdout] 60 | | .indent(indent) [INFO] [stdout] 61 | | .header_align(header_align.into()) [INFO] [stdout] 62 | | .body_align(body_align.into()) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `csview` (bin "csview") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/printer.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) fn new(mut rdr: Reader, sniff_rows: usize, with_seq: bool) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let header = rdr.has_headers().then(|| rdr.headers()).transpose()?.cloned(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let (widths, buf) = sniff_widths(&mut rdr, header.as_ref(), sniff_rows, with_seq)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let records = Box::new(buf.into_iter().map(Ok).chain(rdr.into_records())); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Ok(Self { header, widths, records, with_seq }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/printer.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 70 | let mut buf = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let mut record = header.cloned().unwrap_or_default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok((widths, buf)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/row.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 15 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Self { cells: iter.into_iter().collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/style.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 222 | pub fn clear_seps(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | self.col_seps(None, None, None).row_seps(None, None, None, None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 15 | let builder = match style { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / builder [INFO] [stdout] 59 | | .padding(padding) [INFO] [stdout] 60 | | .indent(indent) [INFO] [stdout] 61 | | .header_align(header_align.into()) [INFO] [stdout] 62 | | .body_align(body_align.into()) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `csview` (bin "csview" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "017f5f09a7c99b228669b3765f84b8aa2c40a5397d4763822a656816c9ad7b52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "017f5f09a7c99b228669b3765f84b8aa2c40a5397d4763822a656816c9ad7b52", kill_on_drop: false }` [INFO] [stdout] 017f5f09a7c99b228669b3765f84b8aa2c40a5397d4763822a656816c9ad7b52