[INFO] fetching crate csv-groupby 0.10.0... [INFO] checking csv-groupby-0.10.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate csv-groupby 0.10.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate csv-groupby 0.10.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate csv-groupby 0.10.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate csv-groupby 0.10.0 [INFO] tweaked toml for crates.io crate csv-groupby 0.10.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate csv-groupby 0.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: version requirement `0.9.0+zstd.1.5.0` for dependency `zstd` includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf8f0cb62b7d0ea43373eab5c119a6437762df94c44acf614d7f7633d72c9e3c [INFO] running `Command { std: "docker" "start" "-a" "bf8f0cb62b7d0ea43373eab5c119a6437762df94c44acf614d7f7633d72c9e3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf8f0cb62b7d0ea43373eab5c119a6437762df94c44acf614d7f7633d72c9e3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf8f0cb62b7d0ea43373eab5c119a6437762df94c44acf614d7f7633d72c9e3c", kill_on_drop: false }` [INFO] [stdout] bf8f0cb62b7d0ea43373eab5c119a6437762df94c44acf614d7f7633d72c9e3c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ff94af3b19ffb416e4ba31ff639c85c310a0cfe179b4b36c26666acf4811728 [INFO] running `Command { std: "docker" "start" "-a" "5ff94af3b19ffb416e4ba31ff639c85c310a0cfe179b4b36c26666acf4811728", kill_on_drop: false }` [INFO] [stderr] warning: version requirement `0.9.0+zstd.1.5.0` for dependency `zstd` includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling fs_extra v1.2.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling escargot v0.3.1 [INFO] [stderr] Compiling zstd-safe v4.1.1+zstd.1.5.0 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling jobserver v0.1.22 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling csv-groupby v0.10.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stdout] warning: unused import: `std::thread::LocalKey` [INFO] [stdout] --> build.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::thread::LocalKey; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Compiling cc v1.0.68 [INFO] [stderr] Compiling paste-impl v0.1.18 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking predicates-core v1.0.2 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking gimli v0.24.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking predicates-tree v1.0.2 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking paste v0.1.18 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking float-cmp v0.8.0 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking object v0.25.3 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking rustc-demangle v0.1.20 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Compiling zstd-sys v1.6.1+zstd.1.5.0 [INFO] [stderr] Compiling jemalloc-sys v0.3.2 [INFO] [stderr] Compiling pcre2-sys v0.2.5 [INFO] [stderr] Compiling backtrace v0.3.60 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Checking flate2 v1.0.20 [INFO] [stderr] Checking chan v0.1.23 [INFO] [stderr] Checking pcre2 v0.2.3 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking cpu-time v1.0.0 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking predicates v1.0.8 [INFO] [stderr] Checking addr2line v0.15.2 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Checking globset v0.4.8 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking ignore v0.4.18 [INFO] [stderr] Checking grep-cli v0.1.6 [INFO] [stderr] Checking assert_cmd v0.10.2 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking zstd v0.9.0+zstd.1.5.0 [INFO] [stderr] Checking jemallocator v0.3.2 [INFO] [stderr] Checking jemalloc-ctl v0.3.3 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/quick.rs:274:34 [INFO] [stdout] | [INFO] [stdout] 274 | h_1.into_iter().for_each(|x| x.join().expect("error joining h_1")); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/quick.rs:275:34 [INFO] [stdout] | [INFO] [stdout] 275 | h_2.into_iter().for_each(|x| x.join().expect("error joining h_2")); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `csv-groupby` (bin "quick" test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `gettid` is never used [INFO] [stdout] --> src/gen.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn gettid() -> usize { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `greek` is never used [INFO] [stdout] --> src/gen.rs:163:8 [INFO] [stdout] | [INFO] [stdout] 163 | pub fn greek(v: f64) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `user_pause` is never used [INFO] [stdout] --> src/gen.rs:207:8 [INFO] [stdout] | [INFO] [stdout] 207 | pub fn user_pause() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `bytes`, `files`, and `curr_file` are never read [INFO] [stdout] --> src/gen.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 216 | pub struct IoSlicerStatus { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 217 | pub bytes: AtomicUsize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 218 | pub files: AtomicUsize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 219 | pub curr_file: Mutex, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `IoSlicerStatus` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/gen.rs:223:12 [INFO] [stdout] | [INFO] [stdout] 222 | impl IoSlicerStatus { [INFO] [stdout] | ------------------- associated function in this implementation [INFO] [stdout] 223 | pub fn new() -> IoSlicerStatus { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FileSlice` is never constructed [INFO] [stdout] --> src/gen.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 233 | pub struct FileSlice { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileSlice` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `fill_buff` is never used [INFO] [stdout] --> src/gen.rs:241:4 [INFO] [stdout] | [INFO] [stdout] 241 | fn fill_buff(handle: &mut dyn Read, buff: &mut [u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `io_thread_slicer` is never used [INFO] [stdout] --> src/gen.rs:263:8 [INFO] [stdout] | [INFO] [stdout] 263 | pub fn io_thread_slicer( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `caps_to_vec_strings` is never used [INFO] [stdout] --> src/gen.rs:379:8 [INFO] [stdout] | [INFO] [stdout] 379 | pub fn caps_to_vec_strings(caps: &Captures_pcre2) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `subs_from_path_buff` is never used [INFO] [stdout] --> src/gen.rs:389:8 [INFO] [stdout] | [INFO] [stdout] 389 | pub fn subs_from_path_buff(path: &PathBuf, regex: &Option) -> (bool, Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `per_file_thread` is never used [INFO] [stdout] --> src/gen.rs:402:8 [INFO] [stdout] | [INFO] [stdout] 402 | pub fn per_file_thread( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `gettid` is never used [INFO] [stdout] --> src/gen.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn gettid() -> usize { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mem_metric` is never used [INFO] [stdout] --> src/gen.rs:98:4 [INFO] [stdout] | [INFO] [stdout] 98 | fn mem_metric<'a>(v: usize) -> (f64, &'a str) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `sig_dig` is never used [INFO] [stdout] --> src/gen.rs:112:4 [INFO] [stdout] | [INFO] [stdout] 112 | fn sig_dig(v: f64, digits: usize) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mem_metric_digit` is never used [INFO] [stdout] --> src/gen.rs:136:8 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn mem_metric_digit(v: usize, sig: usize) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `greek` is never used [INFO] [stdout] --> src/gen.rs:163:8 [INFO] [stdout] | [INFO] [stdout] 163 | pub fn greek(v: f64) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `user_pause` is never used [INFO] [stdout] --> src/gen.rs:207:8 [INFO] [stdout] | [INFO] [stdout] 207 | pub fn user_pause() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `bytes`, `files`, and `curr_file` are never read [INFO] [stdout] --> src/gen.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 216 | pub struct IoSlicerStatus { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 217 | pub bytes: AtomicUsize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 218 | pub files: AtomicUsize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 219 | pub curr_file: Mutex, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `IoSlicerStatus` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/gen.rs:223:12 [INFO] [stdout] | [INFO] [stdout] 222 | impl IoSlicerStatus { [INFO] [stdout] | ------------------- associated function in this implementation [INFO] [stdout] 223 | pub fn new() -> IoSlicerStatus { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FileSlice` is never constructed [INFO] [stdout] --> src/gen.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 233 | pub struct FileSlice { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileSlice` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `fill_buff` is never used [INFO] [stdout] --> src/gen.rs:241:4 [INFO] [stdout] | [INFO] [stdout] 241 | fn fill_buff(handle: &mut dyn Read, buff: &mut [u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `io_thread_slicer` is never used [INFO] [stdout] --> src/gen.rs:263:8 [INFO] [stdout] | [INFO] [stdout] 263 | pub fn io_thread_slicer( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `caps_to_vec_strings` is never used [INFO] [stdout] --> src/gen.rs:379:8 [INFO] [stdout] | [INFO] [stdout] 379 | pub fn caps_to_vec_strings(caps: &Captures_pcre2) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `subs_from_path_buff` is never used [INFO] [stdout] --> src/gen.rs:389:8 [INFO] [stdout] | [INFO] [stdout] 389 | pub fn subs_from_path_buff(path: &PathBuf, regex: &Option) -> (bool, Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `per_file_thread` is never used [INFO] [stdout] --> src/gen.rs:402:8 [INFO] [stdout] | [INFO] [stdout] 402 | pub fn per_file_thread( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cli.rs:315:22 [INFO] [stdout] | [INFO] [stdout] 315 | pub head: Option<(u64)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 315 - pub head: Option<(u64)>, [INFO] [stdout] 315 + pub head: Option, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cli.rs:319:22 [INFO] [stdout] | [INFO] [stdout] 319 | pub tail: Option<(u64)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 319 - pub tail: Option<(u64)>, [INFO] [stdout] 319 + pub tail: Option, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cli.rs:331:26 [INFO] [stdout] | [INFO] [stdout] 331 | pub count_le: Option<(u64)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 331 - pub count_le: Option<(u64)>, [INFO] [stdout] 331 + pub count_le: Option, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cli.rs:335:26 [INFO] [stdout] | [INFO] [stdout] 335 | pub count_ge: Option<(u64)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 335 - pub count_ge: Option<(u64)>, [INFO] [stdout] 335 + pub count_ge: Option, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/keysum.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | if ( v.is_none()) { [INFO] [stdout] | ^^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 104 - if ( v.is_none()) { [INFO] [stdout] 104 + if v.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cli.rs:315:22 [INFO] [stdout] | [INFO] [stdout] 315 | pub head: Option<(u64)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 315 - pub head: Option<(u64)>, [INFO] [stdout] 315 + pub head: Option, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cli.rs:319:22 [INFO] [stdout] | [INFO] [stdout] 319 | pub tail: Option<(u64)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 319 - pub tail: Option<(u64)>, [INFO] [stdout] 319 + pub tail: Option, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cli.rs:331:26 [INFO] [stdout] | [INFO] [stdout] 331 | pub count_le: Option<(u64)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 331 - pub count_le: Option<(u64)>, [INFO] [stdout] 331 + pub count_le: Option, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cli.rs:335:26 [INFO] [stdout] | [INFO] [stdout] 335 | pub count_ge: Option<(u64)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 335 - pub count_ge: Option<(u64)>, [INFO] [stdout] 335 + pub count_ge: Option, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/keysum.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | if ( v.is_none()) { [INFO] [stdout] | ^^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 104 - if ( v.is_none()) { [INFO] [stdout] 104 + if v.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/quick.rs:274:34 [INFO] [stdout] | [INFO] [stdout] 274 | h_1.into_iter().for_each(|x| x.join().expect("error joining h_1")); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/quick.rs:275:34 [INFO] [stdout] | [INFO] [stdout] 275 | h_2.into_iter().for_each(|x| x.join().expect("error joining h_2")); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `csv-groupby` (bin "quick") due to 3 previous errors [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/keysum.rs:103:17 [INFO] [stdout] | [INFO] [stdout] 103 | let mut v = self.matrix.get_mut(i); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `null_str` [INFO] [stdout] --> src/keysum.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | let null_str = String::from("NULL"); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_null_str` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ss` [INFO] [stdout] --> src/keysum.rs:167:53 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn schema_rec(matrix: &mut Vec>, ss: &mut String, line: &str, record: &T, rec_len: usize, map: &mut MyMap, cfg: &CliCf... [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_ss` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `line` [INFO] [stdout] --> src/keysum.rs:167:70 [INFO] [stdout] | [INFO] [stdout] 167 | ...Vec>, ss: &mut String, line: &str, record: &T, rec_len: usize, map: &mut MyMap, cfg: &CliCfg, rowcount: &mut usize) -> (usize,... [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_line` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `map` [INFO] [stdout] --> src/keysum.rs:167:110 [INFO] [stdout] | [INFO] [stdout] 167 | ...tr, record: &T, rec_len: usize, map: &mut MyMap, cfg: &CliCfg, rowcount: &mut usize) -> (usize,usize) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cfg` [INFO] [stdout] --> src/keysum.rs:167:127 [INFO] [stdout] | [INFO] [stdout] 167 | ...ec_len: usize, map: &mut MyMap, cfg: &CliCfg, rowcount: &mut usize) -> (usize,usize) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cfg` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rowcount` [INFO] [stdout] --> src/keysum.rs:167:141 [INFO] [stdout] | [INFO] [stdout] 167 | ... &mut MyMap, cfg: &CliCfg, rowcount: &mut usize) -> (usize,usize) [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_rowcount` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/keysum.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | let mut lines_filtered = 0usize; [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/keysum.rs:251:9 [INFO] [stdout] | [INFO] [stdout] 251 | let mut brec: &mut KeySum = { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/keysum.rs:103:17 [INFO] [stdout] | [INFO] [stdout] 103 | let mut v = self.matrix.get_mut(i); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `null_str` [INFO] [stdout] --> src/keysum.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | let null_str = String::from("NULL"); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_null_str` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ss` [INFO] [stdout] --> src/keysum.rs:167:53 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn schema_rec(matrix: &mut Vec>, ss: &mut String, line: &str, record: &T, rec_len: usize, map: &mut MyMap, cfg: &CliCf... [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_ss` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `line` [INFO] [stdout] --> src/keysum.rs:167:70 [INFO] [stdout] | [INFO] [stdout] 167 | ...Vec>, ss: &mut String, line: &str, record: &T, rec_len: usize, map: &mut MyMap, cfg: &CliCfg, rowcount: &mut usize) -> (usize,... [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_line` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `map` [INFO] [stdout] --> src/keysum.rs:167:110 [INFO] [stdout] | [INFO] [stdout] 167 | ...tr, record: &T, rec_len: usize, map: &mut MyMap, cfg: &CliCfg, rowcount: &mut usize) -> (usize,usize) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cfg` [INFO] [stdout] --> src/keysum.rs:167:127 [INFO] [stdout] | [INFO] [stdout] 167 | ...ec_len: usize, map: &mut MyMap, cfg: &CliCfg, rowcount: &mut usize) -> (usize,usize) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cfg` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rowcount` [INFO] [stdout] --> src/keysum.rs:167:141 [INFO] [stdout] | [INFO] [stdout] 167 | ... &mut MyMap, cfg: &CliCfg, rowcount: &mut usize) -> (usize,usize) [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_rowcount` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `print_skipped` [INFO] [stdout] --> src/main.rs:496:21 [INFO] [stdout] | [INFO] [stdout] 496 | let mut print_skipped = false; // for the stuff after head and before tail [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_print_skipped` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/keysum.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | let mut lines_filtered = 0usize; [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/keysum.rs:251:9 [INFO] [stdout] | [INFO] [stdout] 251 | let mut brec: &mut KeySum = { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `print_skipped` [INFO] [stdout] --> src/main.rs:496:21 [INFO] [stdout] | [INFO] [stdout] 496 | let mut print_skipped = false; // for the stuff after head and before tail [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_print_skipped` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:496:17 [INFO] [stdout] | [INFO] [stdout] 496 | let mut print_skipped = false; // for the stuff after head and before tail [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `inner_count` [INFO] [stdout] --> src/main.rs:843:30 [INFO] [stdout] | [INFO] [stdout] 843 | 'LINE_LOOP: for (inner_count, line) in slice.split(|c| *c == b'\n').enumerate() { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_inner_count` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/main.rs:987:56 [INFO] [stdout] | [INFO] [stdout] 987 | ... csv::ErrorKind::Utf8 { ref err, pos } => { [INFO] [stdout] | ^^^^^^^ help: try ignoring the field: `err: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `cnt_rec` is assigned to, but never used [INFO] [stdout] --> src/main.rs:999:25 [INFO] [stdout] | [INFO] [stdout] 999 | let mut cnt_rec = 0usize; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_cnt_rec` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/main.rs:1021:56 [INFO] [stdout] | [INFO] [stdout] 1021 | ... csv::ErrorKind::Utf8 { ref err, pos } => { [INFO] [stdout] | ^^^^^^^ help: try ignoring the field: `err: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:922:9 [INFO] [stdout] | [INFO] [stdout] 922 | let mut csv_builder = create_csv_builder(&cfg); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/main.rs:1148:28 [INFO] [stdout] | [INFO] [stdout] 1148 | if let Err(e) = line { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:496:17 [INFO] [stdout] | [INFO] [stdout] 496 | let mut print_skipped = false; // for the stuff after head and before tail [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:1215:13 [INFO] [stdout] | [INFO] [stdout] 1215 | let mut b = slice[pos]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `inner_count` [INFO] [stdout] --> src/main.rs:843:30 [INFO] [stdout] | [INFO] [stdout] 843 | 'LINE_LOOP: for (inner_count, line) in slice.split(|c| *c == b'\n').enumerate() { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_inner_count` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:226:88 [INFO] [stdout] | [INFO] [stdout] 226 | let path_re: Option = clone_cfg.re_path.as_ref().and_then(|x| Some(Regex_pre2::new(&x).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:383:13 [INFO] [stdout] | [INFO] [stdout] 379 | fn re_mod_idx(_cfg: &CliCfg, v: T) -> T [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | v + 1.into() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:761:20 [INFO] [stdout] | [INFO] [stdout] 761 | panic!(err_msg); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 761 | panic!("{}", err_msg); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:908:20 [INFO] [stdout] | [INFO] [stdout] 908 | panic!(err_msg); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 908 | panic!("{}", err_msg); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:1049:20 [INFO] [stdout] | [INFO] [stdout] 1049 | panic!(err_msg); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 1049 | panic!("{}", err_msg); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `ISO_8859` should have a snake case name [INFO] [stdout] --> src/cli.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 296 | pub ISO_8859: bool, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `iso_8859` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:110:102 [INFO] [stdout] | [INFO] [stdout] 110 | #[structopt(short = "A", long, name = "field_aliases", use_delimiter(true), parse(try_from_str = alias_parser))] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:146:97 [INFO] [stdout] | [INFO] [stdout] 146 | #[structopt(short = "d", long = "input_delimiter", name = "delimiter", parse(try_from_str = escape_parser), default_value = ",", conf... [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:158:83 [INFO] [stdout] | [INFO] [stdout] 158 | #[structopt(short = "q", long = "quote", name = "quote", parse(try_from_str = escape_parser), conflicts_with_all = & ["regex"])] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:164:105 [INFO] [stdout] | [INFO] [stdout] 164 | #[structopt(short = "e", long = "escape", name = "escape", requires = "quote", parse(try_from_str = escape_parser), conflicts_with_al... [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:170:87 [INFO] [stdout] | [INFO] [stdout] 170 | #[structopt(short = "C", long = "comment", name = "comment", parse(try_from_str = escape_parser), conflicts_with_all = & ["regex"])] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:233:62 [INFO] [stdout] | [INFO] [stdout] 233 | #[structopt(long = "io_block_size", parse(try_from_str = from_human_size), default_value = "0")] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:239:61 [INFO] [stdout] | [INFO] [stdout] 239 | #[structopt(long = "q_block_size", parse(try_from_str = from_human_size), default_value = "256K")] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:305:76 [INFO] [stdout] | [INFO] [stdout] 305 | #[structopt(long = "where_re", name = "where_re", parse(try_from_str = field_and_regex))] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:309:84 [INFO] [stdout] | [INFO] [stdout] 309 | #[structopt(long = "where_not_re", name = "where_not_re", parse(try_from_str = field_and_regex))] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:419:8 [INFO] [stdout] | [INFO] [stdout] 415 | let regex = match Regex_pre2::new(v[1]) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 416 | Err(e) => Err(format!("regex error for \"{}\" error {}", v[1], &e))?, [INFO] [stdout] 417 | Ok(re) => re, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 418 | }; [INFO] [stdout] 419 | Ok((size, regex)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/main.rs:987:56 [INFO] [stdout] | [INFO] [stdout] 987 | ... csv::ErrorKind::Utf8 { ref err, pos } => { [INFO] [stdout] | ^^^^^^^ help: try ignoring the field: `err: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `cnt_rec` is assigned to, but never used [INFO] [stdout] --> src/main.rs:999:25 [INFO] [stdout] | [INFO] [stdout] 999 | let mut cnt_rec = 0usize; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_cnt_rec` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/main.rs:1021:56 [INFO] [stdout] | [INFO] [stdout] 1021 | ... csv::ErrorKind::Utf8 { ref err, pos } => { [INFO] [stdout] | ^^^^^^^ help: try ignoring the field: `err: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:922:9 [INFO] [stdout] | [INFO] [stdout] 922 | let mut csv_builder = create_csv_builder(&cfg); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/main.rs:1148:28 [INFO] [stdout] | [INFO] [stdout] 1148 | if let Err(e) = line { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 27 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:1215:13 [INFO] [stdout] | [INFO] [stdout] 1215 | let mut b = slice[pos]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:226:88 [INFO] [stdout] | [INFO] [stdout] 226 | let path_re: Option = clone_cfg.re_path.as_ref().and_then(|x| Some(Regex_pre2::new(&x).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:383:13 [INFO] [stdout] | [INFO] [stdout] 379 | fn re_mod_idx(_cfg: &CliCfg, v: T) -> T [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | v + 1.into() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:761:20 [INFO] [stdout] | [INFO] [stdout] 761 | panic!(err_msg); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 761 | panic!("{}", err_msg); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:908:20 [INFO] [stdout] | [INFO] [stdout] 908 | panic!(err_msg); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 908 | panic!("{}", err_msg); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:1049:20 [INFO] [stdout] | [INFO] [stdout] 1049 | panic!(err_msg); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 1049 | panic!("{}", err_msg); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `ISO_8859` should have a snake case name [INFO] [stdout] --> src/cli.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 296 | pub ISO_8859: bool, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `iso_8859` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:110:102 [INFO] [stdout] | [INFO] [stdout] 110 | #[structopt(short = "A", long, name = "field_aliases", use_delimiter(true), parse(try_from_str = alias_parser))] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:146:97 [INFO] [stdout] | [INFO] [stdout] 146 | #[structopt(short = "d", long = "input_delimiter", name = "delimiter", parse(try_from_str = escape_parser), default_value = ",", conf... [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:158:83 [INFO] [stdout] | [INFO] [stdout] 158 | #[structopt(short = "q", long = "quote", name = "quote", parse(try_from_str = escape_parser), conflicts_with_all = & ["regex"])] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:164:105 [INFO] [stdout] | [INFO] [stdout] 164 | #[structopt(short = "e", long = "escape", name = "escape", requires = "quote", parse(try_from_str = escape_parser), conflicts_with_al... [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:170:87 [INFO] [stdout] | [INFO] [stdout] 170 | #[structopt(short = "C", long = "comment", name = "comment", parse(try_from_str = escape_parser), conflicts_with_all = & ["regex"])] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:233:62 [INFO] [stdout] | [INFO] [stdout] 233 | #[structopt(long = "io_block_size", parse(try_from_str = from_human_size), default_value = "0")] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:239:61 [INFO] [stdout] | [INFO] [stdout] 239 | #[structopt(long = "q_block_size", parse(try_from_str = from_human_size), default_value = "256K")] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:305:76 [INFO] [stdout] | [INFO] [stdout] 305 | #[structopt(long = "where_re", name = "where_re", parse(try_from_str = field_and_regex))] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:309:84 [INFO] [stdout] | [INFO] [stdout] 309 | #[structopt(long = "where_not_re", name = "where_not_re", parse(try_from_str = field_and_regex))] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `csv-groupby` (bin "gb") due to 13 previous errors; 27 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:419:8 [INFO] [stdout] | [INFO] [stdout] 415 | let regex = match Regex_pre2::new(v[1]) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 416 | Err(e) => Err(format!("regex error for \"{}\" error {}", v[1], &e))?, [INFO] [stdout] 417 | Ok(re) => re, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 418 | }; [INFO] [stdout] 419 | Ok((size, regex)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 27 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `csv-groupby` (bin "gb" test) due to 13 previous errors; 27 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5ff94af3b19ffb416e4ba31ff639c85c310a0cfe179b4b36c26666acf4811728", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ff94af3b19ffb416e4ba31ff639c85c310a0cfe179b4b36c26666acf4811728", kill_on_drop: false }` [INFO] [stdout] 5ff94af3b19ffb416e4ba31ff639c85c310a0cfe179b4b36c26666acf4811728