[INFO] fetching crate crossterm 0.28.1... [INFO] checking crossterm-0.28.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate crossterm 0.28.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate crossterm 0.28.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate crossterm 0.28.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate crossterm 0.28.1 [INFO] tweaked toml for crates.io crate crossterm 0.28.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate crossterm 0.28.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cf9a1c4ca54cce0d9df647312218d99cc738db32698e9287c2b76d35f052193c [INFO] running `Command { std: "docker" "start" "-a" "cf9a1c4ca54cce0d9df647312218d99cc738db32698e9287c2b76d35f052193c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cf9a1c4ca54cce0d9df647312218d99cc738db32698e9287c2b76d35f052193c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf9a1c4ca54cce0d9df647312218d99cc738db32698e9287c2b76d35f052193c", kill_on_drop: false }` [INFO] [stdout] cf9a1c4ca54cce0d9df647312218d99cc738db32698e9287c2b76d35f052193c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6dd6cf81b4e66de367347aea7b3a51c0184e471ea3cae8c24446c2904a1543de [INFO] running `Command { std: "docker" "start" "-a" "6dd6cf81b4e66de367347aea7b3a51c0184e471ea3cae8c24446c2904a1543de", kill_on_drop: false }` [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking piper v0.2.3 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-executor v1.12.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking temp-env v0.3.6 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serial_test_derive v2.0.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking polling v3.7.2 [INFO] [stderr] Checking crossterm v0.28.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `winapi` [INFO] [stdout] --> src/lib.rs:256:11 [INFO] [stdout] | [INFO] [stdout] 256 | #[cfg(all(winapi, not(feature = "winapi")))] [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(winapi)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(winapi)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `winapi` [INFO] [stdout] --> src/lib.rs:256:23 [INFO] [stdout] | [INFO] [stdout] 256 | #[cfg(all(winapi, not(feature = "winapi")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `bracketed-paste`, `default`, `event-stream`, `events`, `filedescriptor`, `libc`, `serde`, `use-dev-tty`, and `windows` [INFO] [stdout] = help: consider adding `winapi` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `crossterm_winapi` [INFO] [stdout] --> src/lib.rs:259:11 [INFO] [stdout] | [INFO] [stdout] 259 | #[cfg(all(crossterm_winapi, not(feature = "crossterm_winapi")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(crossterm_winapi)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(crossterm_winapi)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `crossterm_winapi` [INFO] [stdout] --> src/lib.rs:259:33 [INFO] [stdout] | [INFO] [stdout] 259 | #[cfg(all(crossterm_winapi, not(feature = "crossterm_winapi")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `bracketed-paste`, `default`, `event-stream`, `events`, `filedescriptor`, `libc`, `serde`, `use-dev-tty`, and `windows` [INFO] [stdout] = help: consider adding `crossterm_winapi` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking async-io v2.3.3 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stdout] warning: struct `InternalEventFilter` is never constructed [INFO] [stdout] --> src/event/filter.rs:65:19 [INFO] [stdout] | [INFO] [stdout] 65 | pub(crate) struct InternalEventFilter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event/read.rs:25:42 [INFO] [stdout] | [INFO] [stdout] 25 | let source = source.ok().map(|x| Box::new(x) as Box); [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event/source/unix/mio.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 40 | pub(crate) fn from_file_descriptor(input_fd: FileDesc<'static>) -> io::Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let poll = Poll::new()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let mut signals = Signals::new([signal_hook::consts::SIGWINCH])?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | Ok(UnixInternalEventSource { [INFO] [stdout] | ____________^ [INFO] [stdout] 55 | | poll, [INFO] [stdout] 56 | | events: Events::with_capacity(3), [INFO] [stdout] 57 | | parser: Parser::default(), [INFO] [stdout] ... | [INFO] [stdout] 62 | | waker, [INFO] [stdout] 63 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal/sys/unix.rs:85:67 [INFO] [stdout] | [INFO] [stdout] 85 | let file = File::open("/dev/tty").map(|file| (FileDesc::Owned(file.into()))); [INFO] [stdout] | ---- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal/sys/unix.rs:102:31 [INFO] [stdout] | [INFO] [stdout] 102 | tput_size().ok_or_else(|| std::io::Error::last_os_error().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:278:18 [INFO] [stdout] | [INFO] [stdout] 255 | command: C, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | let mut adapter = Adapter { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | .map_err(|fmt::Error| match adapter.res { [INFO] [stdout] | __________________^ [INFO] [stdout] 279 | | Ok(()) => panic!( [INFO] [stdout] 280 | | "<{}>::write_ansi incorrectly errored", [INFO] [stdout] 281 | | std::any::type_name::() [INFO] [stdout] 282 | | ), [INFO] [stdout] 283 | | Err(e) => e, [INFO] [stdout] 284 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crossterm` (lib) due to 6 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6dd6cf81b4e66de367347aea7b3a51c0184e471ea3cae8c24446c2904a1543de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6dd6cf81b4e66de367347aea7b3a51c0184e471ea3cae8c24446c2904a1543de", kill_on_drop: false }` [INFO] [stdout] 6dd6cf81b4e66de367347aea7b3a51c0184e471ea3cae8c24446c2904a1543de