[INFO] fetching crate crossbow-android 0.2.3... [INFO] checking crossbow-android-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate crossbow-android 0.2.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate crossbow-android 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate crossbow-android 0.2.3 [INFO] finished tweaking crates.io crate crossbow-android 0.2.3 [INFO] tweaked toml for crates.io crate crossbow-android 0.2.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 56 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding jni v0.19.0 (latest: v0.21.1) [INFO] [stderr] Adding jni-sys v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding rust-embed v6.8.1 (latest: v8.5.0) [INFO] [stderr] Adding rust-embed-impl v6.8.1 (latest: v8.5.0) [INFO] [stderr] Adding rust-embed-utils v7.8.1 (latest: v8.5.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 414683f261bce5dd25fee49f78990b2ed6e3c7ad38f0b40422e0fd9b614178d7 [INFO] running `Command { std: "docker" "start" "-a" "414683f261bce5dd25fee49f78990b2ed6e3c7ad38f0b40422e0fd9b614178d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "414683f261bce5dd25fee49f78990b2ed6e3c7ad38f0b40422e0fd9b614178d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "414683f261bce5dd25fee49f78990b2ed6e3c7ad38f0b40422e0fd9b614178d7", kill_on_drop: false }` [INFO] [stdout] 414683f261bce5dd25fee49f78990b2ed6e3c7ad38f0b40422e0fd9b614178d7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d4b8d2a7124ed474c8397da0a887975c939d8fd1587ce435de7dabccc4cd3e52 [INFO] running `Command { std: "docker" "start" "-a" "d4b8d2a7124ed474c8397da0a887975c939d8fd1587ce435de7dabccc4cd3e52", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking jni-sys v0.3.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking cesu8 v1.1.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking ndk-context v0.1.1 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling jni v0.19.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking crossbow-android v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/mod.rs:35:60 [INFO] [stdout] | [INFO] [stdout] 32 | singleton: JniSingleton, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | ) -> Option> { [INFO] [stdout] 34 | let mut jni_signletons_guard = JNI_SINGLETONS.lock().unwrap(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | jni_signletons_guard.insert(singleton_name.to_owned(), Arc::new(singleton)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/mod.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 43 | fn insert_sender(singleton_name: &str, sender: Sender) -> Option> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | / JNI_SIGNAL_SENDERS [INFO] [stdout] 45 | | .lock() [INFO] [stdout] 46 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/mod.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 61 | let jni_signals = JNI_SIGNAL_SENDERS.lock().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(sender.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/jni_singleton.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(name: &str, instance: GlobalRef, receiver: Receiver) -> Self { [INFO] [stdout] | ------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | methods: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/jni_singleton.rs:38:22 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(name: &str, instance: GlobalRef, receiver: Receiver) -> Self { [INFO] [stdout] | ------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | signals: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crossbow-android` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/mod.rs:35:60 [INFO] [stdout] | [INFO] [stdout] 32 | singleton: JniSingleton, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | ) -> Option> { [INFO] [stdout] 34 | let mut jni_signletons_guard = JNI_SINGLETONS.lock().unwrap(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | jni_signletons_guard.insert(singleton_name.to_owned(), Arc::new(singleton)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/mod.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 43 | fn insert_sender(singleton_name: &str, sender: Sender) -> Option> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | / JNI_SIGNAL_SENDERS [INFO] [stdout] 45 | | .lock() [INFO] [stdout] 46 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/mod.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 61 | let jni_signals = JNI_SIGNAL_SENDERS.lock().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(sender.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/jni_singleton.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(name: &str, instance: GlobalRef, receiver: Receiver) -> Self { [INFO] [stdout] | ------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | methods: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/jni_singleton.rs:38:22 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(name: &str, instance: GlobalRef, receiver: Receiver) -> Self { [INFO] [stdout] | ------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | signals: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crossbow-android` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "d4b8d2a7124ed474c8397da0a887975c939d8fd1587ce435de7dabccc4cd3e52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4b8d2a7124ed474c8397da0a887975c939d8fd1587ce435de7dabccc4cd3e52", kill_on_drop: false }` [INFO] [stdout] d4b8d2a7124ed474c8397da0a887975c939d8fd1587ce435de7dabccc4cd3e52