[INFO] fetching crate crossbeam-channel 0.5.13... [INFO] checking crossbeam-channel-0.5.13 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate crossbeam-channel 0.5.13 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate crossbeam-channel 0.5.13 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate crossbeam-channel 0.5.13 [INFO] finished tweaking crates.io crate crossbeam-channel 0.5.13 [INFO] tweaked toml for crates.io crate crossbeam-channel 0.5.13 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate crossbeam-channel 0.5.13 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c8c00a39373f6eee814a24b7891801ba3491f62e04a4f968b315a152fa0a87bc [INFO] running `Command { std: "docker" "start" "-a" "c8c00a39373f6eee814a24b7891801ba3491f62e04a4f968b315a152fa0a87bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c8c00a39373f6eee814a24b7891801ba3491f62e04a4f968b315a152fa0a87bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c8c00a39373f6eee814a24b7891801ba3491f62e04a4f968b315a152fa0a87bc", kill_on_drop: false }` [INFO] [stdout] c8c00a39373f6eee814a24b7891801ba3491f62e04a4f968b315a152fa0a87bc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c2b3a37b2493b8e6b80d41f39fba647f3102fa0bbfa68f514332fdb24fb57117 [INFO] running `Command { std: "docker" "start" "-a" "c2b3a37b2493b8e6b80d41f39fba647f3102fa0bbfa68f514332fdb24fb57117", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking crossbeam-channel v0.5.13 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:436:9 [INFO] [stdout] | [INFO] [stdout] 435 | pub fn send(&self, msg: T) -> Result<(), SendError> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 436 | / match &self.flavor { [INFO] [stdout] 437 | | SenderFlavor::Array(chan) => chan.send(msg, None), [INFO] [stdout] 438 | | SenderFlavor::List(chan) => chan.send(msg, None), [INFO] [stdout] 439 | | SenderFlavor::Zero(chan) => chan.send(msg, None), [INFO] [stdout] 440 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn with(f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let mut f = Some(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | / CONTEXT [INFO] [stdout] 56 | | .try_with(|cell| match cell.take() { [INFO] [stdout] 57 | | None => f(&Context::new()), [INFO] [stdout] 58 | | Some(cx) => { [INFO] [stdout] ... | [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:56:36 [INFO] [stdout] | [INFO] [stdout] 56 | .try_with(|cell| match cell.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:65:36 [INFO] [stdout] | [INFO] [stdout] 65 | .unwrap_or_else(|_| f(&Context::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flavors/array.rs:126:22 [INFO] [stdout] | [INFO] [stdout] 109 | let buffer: Box<[Slot]> = (0..cap) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | senders: SyncWaker::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flavors/array.rs:127:24 [INFO] [stdout] | [INFO] [stdout] 109 | let buffer: Box<[Slot]> = (0..cap) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | receivers: SyncWaker::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flavors/list.rs:412:9 [INFO] [stdout] | [INFO] [stdout] 411 | pub(crate) fn try_send(&self, msg: T) -> Result<(), TrySendError> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 412 | self.send(msg, None).map_err(|err| match err { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flavors/zero.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 67 | fn message_on_stack(msg: T) -> Packet { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | msg: UnsafeCell::new(Some(msg)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flavors/zero.rs:242:23 [INFO] [stdout] | [INFO] [stdout] 222 | msg: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | let mut inner = self.inner.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | Context::with(|cx| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 243 | | // Prepare for blocking until a receiver wakes us up. [INFO] [stdout] 244 | | let oper = Operation::hook(token); [INFO] [stdout] 245 | | let mut packet = Packet::::message_on_stack(msg); [INFO] [stdout] ... | [INFO] [stdout] 272 | | } [INFO] [stdout] 273 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flavors/zero.rs:311:23 [INFO] [stdout] | [INFO] [stdout] 296 | let mut inner = self.inner.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | Context::with(|cx| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 312 | | // Prepare for blocking until a sender wakes us up. [INFO] [stdout] 313 | | let oper = Operation::hook(token); [INFO] [stdout] 314 | | let mut packet = Packet::::empty_on_stack(); [INFO] [stdout] ... | [INFO] [stdout] 351 | | } [INFO] [stdout] 352 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/waker.rs:286:29 [INFO] [stdout] | [INFO] [stdout] 286 | .unwrap_or_else(|_| thread::current().id()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crossbeam-channel` (lib) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "c2b3a37b2493b8e6b80d41f39fba647f3102fa0bbfa68f514332fdb24fb57117", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2b3a37b2493b8e6b80d41f39fba647f3102fa0bbfa68f514332fdb24fb57117", kill_on_drop: false }` [INFO] [stdout] c2b3a37b2493b8e6b80d41f39fba647f3102fa0bbfa68f514332fdb24fb57117