[INFO] fetching crate cross-socket 0.8.0... [INFO] checking cross-socket-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cross-socket 0.8.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate cross-socket 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cross-socket 0.8.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate cross-socket 0.8.0 [INFO] tweaked toml for crates.io crate cross-socket 0.8.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate cross-socket 0.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9d20bc47de36bc9cd02eb5c8e63528e5bec9858d746762078687b8967dcd0638 [INFO] running `Command { std: "docker" "start" "-a" "9d20bc47de36bc9cd02eb5c8e63528e5bec9858d746762078687b8967dcd0638", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9d20bc47de36bc9cd02eb5c8e63528e5bec9858d746762078687b8967dcd0638", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d20bc47de36bc9cd02eb5c8e63528e5bec9858d746762078687b8967dcd0638", kill_on_drop: false }` [INFO] [stdout] 9d20bc47de36bc9cd02eb5c8e63528e5bec9858d746762078687b8967dcd0638 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ffb9aca547336390811b3e08cfe949c6c7110dba7592d3f2bbcb7d9f0dd9b2b [INFO] running `Command { std: "docker" "start" "-a" "5ffb9aca547336390811b3e08cfe949c6c7110dba7592d3f2bbcb7d9f0dd9b2b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling memchr v2.6.3 [INFO] [stderr] Checking no-std-net v0.6.0 [INFO] [stderr] Compiling regex-syntax v0.7.5 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking pnet_base v0.34.0 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking pnet_macros_support v0.34.0 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling aho-corasick v1.0.5 [INFO] [stderr] Compiling rustix v0.37.23 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking pnet_sys v0.34.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking parking v2.1.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling pnet v0.34.0 [INFO] [stderr] Checking waker-fn v1.1.0 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking concurrent-queue v2.2.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling regex-automata v0.3.8 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking default-net v0.18.0 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling regex v1.9.5 [INFO] [stderr] Compiling pnet_macros v0.34.0 [INFO] [stderr] Checking pnet_packet v0.34.0 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking pnet_transport v0.34.0 [INFO] [stderr] Checking ipnetwork v0.20.0 [INFO] [stderr] Checking pnet_datalink v0.34.0 [INFO] [stderr] Checking cross-socket v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket/mod.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 131 | let socket: SystemSocket = if let Some(protocol) = socket_option.protocol { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Ok(AsyncSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | inner: Arc::new(Async::new(socket)?), [INFO] [stdout] 147 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket/mod.rs:307:12 [INFO] [stdout] | [INFO] [stdout] 291 | let socket: SystemSocket = if let Some(protocol) = socket_option.protocol { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 307 | Ok(Socket { [INFO] [stdout] | ____________^ [INFO] [stdout] 308 | | inner: Arc::new(socket), [INFO] [stdout] 309 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket/mod.rs:448:12 [INFO] [stdout] | [INFO] [stdout] 438 | let (tx, rx) = match pnet::datalink::channel(&network_interface, config) { [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 439 | Ok(pnet::datalink::Channel::Ethernet(sender, receiver)) => (sender, receiver), [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | Err(e) => return Err(io::Error::new(io::ErrorKind::Other, e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 447 | }; [INFO] [stdout] 448 | Ok(DataLinkSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 449 | | interface: interface, [INFO] [stdout] 450 | | sender: tx, [INFO] [stdout] 451 | | receiver: rx, [INFO] [stdout] 452 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket/unix.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 60 | let socket = match ip_version { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Ok(ListenerSocket { inner: socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cross-socket` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket/mod.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 131 | let socket: SystemSocket = if let Some(protocol) = socket_option.protocol { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Ok(AsyncSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | inner: Arc::new(Async::new(socket)?), [INFO] [stdout] 147 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket/mod.rs:307:12 [INFO] [stdout] | [INFO] [stdout] 291 | let socket: SystemSocket = if let Some(protocol) = socket_option.protocol { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 307 | Ok(Socket { [INFO] [stdout] | ____________^ [INFO] [stdout] 308 | | inner: Arc::new(socket), [INFO] [stdout] 309 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket/mod.rs:448:12 [INFO] [stdout] | [INFO] [stdout] 438 | let (tx, rx) = match pnet::datalink::channel(&network_interface, config) { [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 439 | Ok(pnet::datalink::Channel::Ethernet(sender, receiver)) => (sender, receiver), [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | Err(e) => return Err(io::Error::new(io::ErrorKind::Other, e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 447 | }; [INFO] [stdout] 448 | Ok(DataLinkSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 449 | | interface: interface, [INFO] [stdout] 450 | | sender: tx, [INFO] [stdout] 451 | | receiver: rx, [INFO] [stdout] 452 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket/unix.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 60 | let socket = match ip_version { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Ok(ListenerSocket { inner: socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cross-socket` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "5ffb9aca547336390811b3e08cfe949c6c7110dba7592d3f2bbcb7d9f0dd9b2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ffb9aca547336390811b3e08cfe949c6c7110dba7592d3f2bbcb7d9f0dd9b2b", kill_on_drop: false }` [INFO] [stdout] 5ffb9aca547336390811b3e08cfe949c6c7110dba7592d3f2bbcb7d9f0dd9b2b