[INFO] fetching crate croque 0.6.2... [INFO] checking croque-0.6.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate croque 0.6.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate croque 0.6.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate croque 0.6.2 [INFO] finished tweaking crates.io crate croque 0.6.2 [INFO] tweaked toml for crates.io crate croque 0.6.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate croque 0.6.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5d9286e213612f75384f544a07ed42ac1a78723ecafacb193aa0891480fc240f [INFO] running `Command { std: "docker" "start" "-a" "5d9286e213612f75384f544a07ed42ac1a78723ecafacb193aa0891480fc240f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5d9286e213612f75384f544a07ed42ac1a78723ecafacb193aa0891480fc240f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d9286e213612f75384f544a07ed42ac1a78723ecafacb193aa0891480fc240f", kill_on_drop: false }` [INFO] [stdout] 5d9286e213612f75384f544a07ed42ac1a78723ecafacb193aa0891480fc240f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 39f95cc5e3bc1e06a482d94d2ce1a3078690fc56950c3c6424795bef877ebd91 [INFO] running `Command { std: "docker" "start" "-a" "39f95cc5e3bc1e06a482d94d2ce1a3078690fc56950c3c6424795bef877ebd91", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Checking litemap v0.7.3 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking users v0.11.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling cc v1.0.99 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking nu-ansi-term v0.50.0 [INFO] [stderr] Compiling libz-sys v1.1.18 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.4 [INFO] [stderr] Compiling yoke-derive v0.7.4 [INFO] [stderr] Compiling zerovec-derive v0.10.2 [INFO] [stderr] Compiling displaydoc v0.2.4 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Checking zerofrom v0.1.4 [INFO] [stderr] Checking yoke v0.7.4 [INFO] [stderr] Checking zerovec v0.10.2 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna v1.0.0 [INFO] [stderr] Checking url v2.5.1 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking croque v0.6.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `style` and `content` are never read [INFO] [stdout] --> src/config/os.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 294 | pub struct MacOsConfig { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 295 | #[serde(default = "default_style")] [INFO] [stdout] 296 | pub style: Style, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 299 | pub content: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MacOsConfig` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `style` and `content` are never read [INFO] [stdout] --> src/config/os.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 318 | pub struct WindowsOsConfig { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 319 | #[serde(default = "default_style")] [INFO] [stdout] 320 | pub style: Style, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 323 | pub content: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WindowsOsConfig` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/style.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn deserialize<'de, D>(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Color::deserialize(deserializer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/info/git.rs:194:5 [INFO] [stdout] | [INFO] [stdout] 189 | let remote_names = match repo.remotes() { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | Ok(remotes) => remotes, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | / remote_names [INFO] [stdout] 195 | | .iter() [INFO] [stdout] 196 | | .flatten() [INFO] [stdout] 197 | | .flat_map(|name| repo.find_remote(name).ok()) [INFO] [stdout] 198 | | .flat_map(|remote| remote.url().map(str::to_string)) [INFO] [stdout] 199 | | .map(|url| RemoteStatus { url }) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/info/git.rs:197:26 [INFO] [stdout] | [INFO] [stdout] 197 | .flat_map(|name| repo.find_remote(name).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/path/mod.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | .or_else(|| std::env::current_dir().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `croque` (bin "croque") due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `style` and `content` are never read [INFO] [stdout] --> src/config/os.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 294 | pub struct MacOsConfig { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 295 | #[serde(default = "default_style")] [INFO] [stdout] 296 | pub style: Style, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 299 | pub content: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MacOsConfig` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `style` and `content` are never read [INFO] [stdout] --> src/config/os.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 318 | pub struct WindowsOsConfig { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 319 | #[serde(default = "default_style")] [INFO] [stdout] 320 | pub style: Style, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 323 | pub content: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WindowsOsConfig` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/style.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn deserialize<'de, D>(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Color::deserialize(deserializer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/info/git.rs:194:5 [INFO] [stdout] | [INFO] [stdout] 189 | let remote_names = match repo.remotes() { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | Ok(remotes) => remotes, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | / remote_names [INFO] [stdout] 195 | | .iter() [INFO] [stdout] 196 | | .flatten() [INFO] [stdout] 197 | | .flat_map(|name| repo.find_remote(name).ok()) [INFO] [stdout] 198 | | .flat_map(|remote| remote.url().map(str::to_string)) [INFO] [stdout] 199 | | .map(|url| RemoteStatus { url }) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/info/git.rs:197:26 [INFO] [stdout] | [INFO] [stdout] 197 | .flat_map(|name| repo.find_remote(name).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/path/mod.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | .or_else(|| std::env::current_dir().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `croque` (bin "croque" test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "39f95cc5e3bc1e06a482d94d2ce1a3078690fc56950c3c6424795bef877ebd91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39f95cc5e3bc1e06a482d94d2ce1a3078690fc56950c3c6424795bef877ebd91", kill_on_drop: false }` [INFO] [stdout] 39f95cc5e3bc1e06a482d94d2ce1a3078690fc56950c3c6424795bef877ebd91